Re: [PATCH 10/10] i18n: bundle: mark strings for translation

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Jonathan Niedier" <jrnieder@gmail.com>,
	"Ævar Arnfjörð" <avarab@gmail.com>,
	"Jiang Xin" <worldhello.net@gmail.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Subject: Re: [PATCH 10/10] i18n: bundle: mark strings for translation
Date: Thu, 26 Apr 2012 08:24:55 +0700	[thread overview]
Message-ID: <CACsJy8CzNx9GP2PSszs2rrkQHr0P6fPVe4+-z4QXJ8k_4hqh9w@mail.gmail.com> (raw)
In-Reply-To: <xmqqipgnbffm.fsf@junio.mtv.corp.google.com>

On Thu, Apr 26, 2012 at 5:43 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> @@ -283,13 +287,13 @@ int create_bundle(struct bundle_header *header, const char *path,
>>       strbuf_release(&buf);
>>       fclose(rls_fout);
>>       if (finish_command(&rls))
>> -             return error("rev-list died");
>> +             return error(_("rev-list died"));
>>
>>       /* write references */
>>       argc = setup_revisions(argc, argv, &revs, NULL);
>>
>>       if (argc > 1)
>> -             return error("unrecognized argument: %s'", argv[1]);
>> +             return error(_("unrecognized argument: %s'"), argv[1]);
>
> This is a problem in the original but we see an unmatched sq here.

Yeah. I searched the code and that seems the only place with
unbalanced quotes (both single and double quotes). I'll leave it to
you to either drop it or add another one there.
-- 
Duy