* [PATCH] git-gui: fix usage of themed widgets variable
@ 2010-02-20 18:01 Heiko Voigt
2010-02-20 18:47 ` Pat Thoyts
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Voigt @ 2010-02-20 18:01 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: Pat Thoyts, Johannes Schindelin, git, msysGit Mailinglist
There was one forgotten global so NS was not visible to the method
which resulted in an error.
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
git-gui/lib/status_bar.tcl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
}
constructor two_line {path} {
+ global NS
set w $path
set w_l $w.l
set w_c $w.c
--
1.7.0.m5.rc2.13.g7abfa.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-gui: fix usage of themed widgets variable
2010-02-20 18:01 [PATCH] git-gui: fix usage of themed widgets variable Heiko Voigt
@ 2010-02-20 18:47 ` Pat Thoyts
2010-02-20 18:57 ` [PATCH v2] " Heiko Voigt
0 siblings, 1 reply; 3+ messages in thread
From: Pat Thoyts @ 2010-02-20 18:47 UTC (permalink / raw)
To: Heiko Voigt
Cc: Shawn O. Pearce, Johannes Schindelin, git, msysGit Mailinglist
On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> There was one forgotten global so NS was not visible to the method
> which resulted in an error.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
> git-gui/lib/status_bar.tcl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
> index 5fe3aad..95cb449 100644
> --- a/git-gui/lib/status_bar.tcl
> +++ b/git-gui/lib/status_bar.tcl
> @@ -39,6 +39,7 @@ method _oneline_pack {} {
> }
>
> constructor two_line {path} {
> + global NS
> set w $path
> set w_l $w.l
> set w_c $w.c
> --
> 1.7.0.m5.rc2.13.g7abfa.dirty
The commit message should mention what triggered the error I think -
but this patch is clearly correct.
You can have a
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
if you like :)
Pat Thoyts.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] git-gui: fix usage of themed widgets variable
2010-02-20 18:47 ` Pat Thoyts
@ 2010-02-20 18:57 ` Heiko Voigt
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Voigt @ 2010-02-20 18:57 UTC (permalink / raw)
To: Pat Thoyts; +Cc: Shawn O. Pearce, Johannes Schindelin, git, msysGit Mailinglist
There was one forgotten global so NS was not visible to the method
which resulted in an error.
The error was triggered by using git gui to clone a local repository.
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
On Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:
> On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > There was one forgotten global so NS was not visible to the method
> > which resulted in an error.
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
[...]
>
> The commit message should mention what triggered the error I think -
> but this patch is clearly correct.
> You can have a
>
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
>
> if you like :)
Thanks, taken.
git-gui/lib/status_bar.tcl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
}
constructor two_line {path} {
+ global NS
set w $path
set w_l $w.l
set w_c $w.c
--
1.7.0.m5.rc2.13.g7abfa.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-20 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-20 18:01 [PATCH] git-gui: fix usage of themed widgets variable Heiko Voigt
2010-02-20 18:47 ` Pat Thoyts
2010-02-20 18:57 ` [PATCH v2] " Heiko Voigt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).