[PATCH 0/1] doc: fixed a typo in git-submodule.txt

[PATCH 0/1] doc: fixed a typo in git-submodule.txt

[thomas menzel via GitGitGadget]

fixed a typo in the doc of submodule

elonderin (1):
  doc: submodule: fix typo for command absorbgitdirs

 Documentation/git-submodule.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 8679ef24ed64018bb62170c43ce73e0261c0600a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-688%2Felonderin%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-688/elonderin/patch-1-v1
Pull-Request: https://github.com/git/git/pull/688
-- 
gitgitgadget

[PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

[elonderin via GitGitGadget]

From: elonderin <8225602+elonderin@users.noreply.github.com>

The sentence wants to talk about the superproject's possesive, not plural form.

Signed-off-by: thomas menzel dev@tomsit.de
---
 Documentation/git-submodule.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index 22425cbc76..5232407f68 100644
--- a/Documentation/git-submodule.txt
+++ b/Documentation/git-submodule.txt
@@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
 
 absorbgitdirs::
 	If a git directory of a submodule is inside the submodule,
-	move the git directory of the submodule into its superprojects
+	move the git directory of the submodule into its superproject's
 	`$GIT_DIR/modules` path and then connect the git directory and
 	its working directory by setting the `core.worktree` and adding
 	a .git file pointing to the git directory embedded in the
-- 
gitgitgadget

Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

[Junio C Hamano]

"elonderin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: elonderin <8225602+elonderin@users.noreply.github.com>
>
> The sentence wants to talk about the superproject's possesive, not plural form.
>
> Signed-off-by: thomas menzel dev@tomsit.de

The author of the patch must sign-off, so the above three lines
should look more like so:

	From: Thomas Menzel <dev@tomsit.de>

	The sentence wants to talk about the superproject's
	possesive, not plural form.

	From: Thomas Menzel <dev@tomsit.de>

The content of the patch obviously is correct.

Thanks.

> ---
>  Documentation/git-submodule.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index 22425cbc76..5232407f68 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
>  
>  absorbgitdirs::
>  	If a git directory of a submodule is inside the submodule,
> -	move the git directory of the submodule into its superprojects
> +	move the git directory of the submodule into its superproject's
>  	`$GIT_DIR/modules` path and then connect the git directory and
>  	its working directory by setting the `core.worktree` and adding
>  	a .git file pointing to the git directory embedded in the

Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

[Junio C Hamano]

When anybody tries to respond to the quoted message [*1*] that came
from GGG in the way recommended for the list, the
*.noreply.github.com address gets placed on the Cc:, which is
probably not wanted.

Can GGG do something about it?  As GitHub specific service, it is
not wrong for it to know what noreply.github.com means so dropping
such an address from its Cc: line shouldn't be too difficult.

Thanks.


Reference *1* 

<b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com>


"elonderin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: elonderin <8225602+elonderin@users.noreply.github.com>
>
> The sentence wants to talk about the superproject's possesive, not plural form.
>
> Signed-off-by: thomas menzel dev@tomsit.de
> ---
>  Documentation/git-submodule.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index 22425cbc76..5232407f68 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -248,7 +248,7 @@ registered submodules, and sync any nested submodules within.
>  
>  absorbgitdirs::
>  	If a git directory of a submodule is inside the submodule,
> -	move the git directory of the submodule into its superprojects
> +	move the git directory of the submodule into its superproject's
>  	`$GIT_DIR/modules` path and then connect the git directory and
>  	its working directory by setting the `core.worktree` and adding
>  	a .git file pointing to the git directory embedded in the

Re: [PATCH 1/1] doc: submodule: fix typo for command absorbgitdirs

[Johannes Schindelin]

Hi Junio,

On Mon, 6 Jan 2020, Junio C Hamano wrote:

> When anybody tries to respond to the quoted message [*1*] that came
> from GGG in the way recommended for the list, the
> *.noreply.github.com address gets placed on the Cc:, which is
> probably not wanted.
>
> Can GGG do something about it?  As GitHub specific service, it is
> not wrong for it to know what noreply.github.com means so dropping
> such an address from its Cc: line shouldn't be too difficult.
>
> Thanks.
>
>
> Reference *1*
>
> <b032358ca97df3bd5605ff356196f82a1f16a320.1578322213.git.gitgitgadget@gmail.com>

Right. I added it to the bug tracker:
https://github.com/gitgitgadget/gitgitgadget/issues/182

Ciao,
Dscho