From: Greg KH <gregkh@linuxfoundation.org>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1
Date: Thu, 27 Feb 2020 08:08:16 +0100 [thread overview]
Message-ID: <20200227070816.GA291276@kroah.com> (raw)
In-Reply-To: <87pne1nh33.fsf@nanos.tec.linutronix.de>
On Wed, Feb 26, 2020 at 11:01:36PM +0100, speck for Thomas Gleixner wrote:
> speck for Andi Kleen <speck@linutronix.de> writes:
>
> >> > > I implemented this in the way I did to avoid modifying x86_cpu_id as
> >> > > that structure is an exported ABI and any change would impact user mode
> >> > > code using the structure.
> >> >
> >> > Exported ABI? Which usermode code uses this? The module loading tools?
> >>
> >> Yeah, Andi pointed it out to me on an internal review. I don't know what tool
> >> is using it.
> >
> > Yes it's modprobe to find which module to load.
> >
> > All of mod_devicetable.h is ABI
>
> That's simply not true.
>
> mod_devicetable.h is a kernel internal header which gets analyzed by the
> kernel internal tool modpost which uses this header to generate the
> ALIAS entries in the .modinfo section of the .ko elf file.
>
> The ALIAS entries are user space ABI but not the header file.
To be pedantic, it's a string sent to userspace, _but_ not really an ABI
as it depeneds entirely on the kernel that is running at the time. It's
only used to pass back into a tool like modprobe to try to figure out
what module to load for that specific kernel.
So that string can change structure, with no side affects at all as it
is explicitly tied to that kernel version anyway.
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-27 7:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 21:45 [MODERATED] [PATCH v2 0/2] v2: more sampling fun 0 mark gross
2020-01-16 22:16 ` [MODERATED] [PATCH v2 2/2] v2: more sampling fun 2 mark gross
2020-02-06 22:11 ` [MODERATED] [PATCH v2 1/2] v2: more sampling fun 1 mark gross
2020-02-25 16:55 ` [MODERATED] Re: [PATCH v2 0/2] v2: more sampling fun 0 Josh Poimboeuf
2020-02-25 17:43 ` mark gross
2020-02-25 20:47 ` Thomas Gleixner
2020-02-25 21:51 ` [MODERATED] " mark gross
[not found] ` <5e5595e6.1c69fb81.69e80.2880SMTPIN_ADDED_BROKEN@mx.google.com>
2020-02-26 7:27 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Greg KH
2020-02-26 18:02 ` mark gross
2020-02-26 11:07 ` [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Borislav Petkov
2020-02-26 17:11 ` mark gross
2020-02-26 17:59 ` Borislav Petkov
2020-02-26 18:16 ` Thomas Gleixner
2020-02-26 22:13 ` [MODERATED] " mark gross
2020-02-26 23:53 ` Thomas Gleixner
2020-02-27 16:43 ` [MODERATED] " mark gross
2020-02-26 22:11 ` mark gross
2020-02-26 22:43 ` Borislav Petkov
2020-02-26 23:34 ` mark gross
2020-02-26 18:55 ` Thomas Gleixner
2020-02-26 22:23 ` [MODERATED] " mark gross
2020-02-26 21:13 ` Andi Kleen
2020-02-26 22:01 ` Thomas Gleixner
2020-02-27 7:08 ` Greg KH [this message]
2020-02-26 11:46 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Borislav Petkov
2020-02-26 17:35 ` mark gross
2020-02-26 18:13 ` Borislav Petkov
2020-02-26 22:37 ` mark gross
2020-02-26 22:50 ` Borislav Petkov
2020-02-26 23:42 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227070816.GA291276@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).