historical-speck.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mark gross <mgross@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH 0/5] Slow Randomizing Boosts DoS v4.4.219 backport 0
Date: Tue, 28 Apr 2020 07:54:07 -0700	[thread overview]
Message-ID: <20200428145407.GB120520@mtg-dev.jf.intel.com> (raw)
In-Reply-To: <87k120pv7k.fsf@nanos.tec.linutronix.de>

On Mon, Apr 27, 2020 at 09:47:11PM +0200, speck for Thomas Gleixner wrote:
> Thomas Gleixner <tglx@linutronix.de> writes:
> > speck for mark gross <speck@linutronix.de> writes:
> >> From: mark gross <mgross@linux.intel.com>
> >> Subject: [PATCH 0/5] Slow Ranomizing Boosts DoS linux-4.4.y backport
> >>
> >> This is a backport of the backports done by Thomas for linux-4.14.y to
> >> linux-4.4.y.
> >>
> >> The backport needed a backport of one additional dependency for
> >> cpu_data-x86_mask getting renamed to x86_stepping.
> >>
> >> This was tested by the test engineer who tested the other SRBDS implementations
> >> and it seems to work.
> >>
> >>
> >> Jia Zhang (1):
> >>   x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping
> >
> > This one is missing and rightfully so. Maybe you get your mail setup for
> > sending patches right some day in the future.
> >
> > This one has in the mail headers:
> >
> >   In-Reply-To: <cover.1588001639.git.mgross@linux.intel.com>
> >   References: <cover.1588001639.git.mgross@linux.intel.com>
> >   From: Jia Zhang <qianyue.zj@alibaba-inc.com>
> >   Date: Mon, 1 Jan 2018 09:52:10 +0800
> >
> > While it's correct that the patch is from Jia and was written on Jan. 1
> > 2018, neither the From: nor the Date: header in the mail are correct.
> >
> > That's commit b399151cb48db30ad1e0e93dd40d68c6d007b637 upstream. Do we
> > really want to backport that thing to 4.4 or just live with the uglies
> > of x86_cpuinfo::x86_mask ?
> 
> Fished it out from the moderator mail, applied it to 4.4.y and then ran:
> 
> # git grep 'x86_mask'
> arch/x86/kernel/cpu/amd.c:      if (c->x86_model <= 1 && c->x86_mask <= 1)
yeah, I caught that in my backport that failed to send for some reason.  There
were a few places needing fixups.

> I clearly can see how that was tested.
I didn't test your backport of course.
But, I did do a allyesconfig build that hit that and then I followed up with a
similar git grep.


FWIW :
1915  git checkout srbs-linux-4.4.y
1916  git cherry-pick 06be007aa436a

Then I did a few fixups including the same git grep x86_mask and allyes and
allmod builds.

--mark

  reply	other threads:[~2020-04-28 14:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 15:33 [MODERATED] " mark gross
2018-01-01  1:52 ` [MODERATED] [MODERATED] [PATCH 1/5] Slow Randomizing Boosts DoS v4.4.219 backport 1 Jia Zhang
2020-04-16 15:23 ` [MODERATED] [PATCH 2/5] Slow Randomizing Boosts DoS v4.4.219 backport 2 Mark Gross
2020-04-16 15:32 ` [MODERATED] [PATCH 3/5] Slow Randomizing Boosts DoS v4.4.219 backport 3 Mark Gross
2020-04-16 15:54 ` [MODERATED] [PATCH 4/5] Slow Randomizing Boosts DoS v4.4.219 backport 4 Mark Gross
2020-04-16 16:21 ` [MODERATED] [PATCH 5/5] Slow Randomizing Boosts DoS v4.4.219 backport 5 Mark Gross
2020-04-27 19:37 ` [PATCH 0/5] Slow Randomizing Boosts DoS v4.4.219 backport 0 Thomas Gleixner
2020-04-27 19:47   ` Thomas Gleixner
2020-04-28 14:54     ` mark gross [this message]
2020-04-28 15:35     ` Thomas Gleixner
2020-04-28 21:27       ` [MODERATED] " mark gross
2020-04-28 14:39   ` mark gross
2020-04-28 15:22     ` Greg KH
2020-04-28 21:38       ` mark gross
2020-04-28 22:25         ` Thomas Gleixner
2020-04-29 15:04           ` [MODERATED] " mark gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428145407.GB120520@mtg-dev.jf.intel.com \
    --to=mgross@linux.intel.com \
    --cc=speck@linutronix.de \
    --subject='[MODERATED] Re: [PATCH 0/5] Slow Randomizing Boosts DoS v4.4.219 backport 0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).