intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/4] drm/i915: Fix the sgt.pfn sanity check
@ 2021-01-19 13:31 Matthew Auld
  2021-01-19 13:31 ` [Intel-gfx] [PATCH 2/4] drm/i915/error: Fix object page offset within a region Matthew Auld
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Matthew Auld @ 2021-01-19 13:31 UTC (permalink / raw)
  To: intel-gfx; +Cc: Kui Wen, Chris Wilson

From: Kui Wen <kui.wen@intel.com>

For the device local-memory case, sgt.pfn will always be equal to zero,
since we instead use sgt.dma. Also, for device local-memory it is
perfectly valid for it to start from zero anyway, so no need to add a
new check for that either.

Signed-off-by: Kui Wen <kui.wen@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c
index 43039dc8c607..666808cb3a32 100644
--- a/drivers/gpu/drm/i915/i915_mm.c
+++ b/drivers/gpu/drm/i915/i915_mm.c
@@ -62,7 +62,7 @@ static int remap_sg(pte_t *pte, unsigned long addr, void *data)
 {
 	struct remap_pfn *r = data;
 
-	if (GEM_WARN_ON(!r->sgt.pfn))
+	if (GEM_WARN_ON(!r->sgt.sgp))
 		return -EINVAL;
 
 	/* Special PTE are not associated with any struct page */
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-19 20:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 13:31 [Intel-gfx] [PATCH 1/4] drm/i915: Fix the sgt.pfn sanity check Matthew Auld
2021-01-19 13:31 ` [Intel-gfx] [PATCH 2/4] drm/i915/error: Fix object page offset within a region Matthew Auld
2021-01-19 13:31 ` [Intel-gfx] [PATCH 3/4] drm/i915: move i915_map_type into i915_gem_object_types.h Matthew Auld
2021-01-19 13:31 ` [Intel-gfx] [PATCH 4/4] drm/i915/pool: constrain pool objects by mapping type Matthew Auld
2021-01-19 17:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Fix the sgt.pfn sanity check Patchwork
2021-01-19 20:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).