From: Daniel Vetter <daniel@ffwll.ch>
To: Carsten Emde <C.Emde@osadl.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4
Date: Mon, 23 Apr 2012 15:39:34 +0200 [thread overview]
Message-ID: <20120423133934.GG4935@phenom.ffwll.local> (raw)
In-Reply-To: <4F9555D6.2020708@osadl.org>
On Mon, Apr 23, 2012 at 03:15:02PM +0200, Carsten Emde wrote:
> On 04/23/2012 02:36 PM, Daniel Vetter wrote:
> >On Mon, Apr 23, 2012 at 02:32:57PM +0200, Daniel Vetter wrote:
> >>On Mon, Apr 23, 2012 at 01:54:23PM +0200, Carsten Emde wrote:
> >>>On 04/23/2012 11:32 AM, Daniel Vetter wrote:
> >>>>There's a bit in the docs for gen4 only that says whether the
> >>>>backlight control is inverted. And both the quirk we have and
> >>>>all bugs only concern i965gm and gm45 (and mostly Acer) afaics.
> >>>>
> >>>>So lets drop the quirk and use the bit instead.
> >>>>
> >>>>Also clean up the BLC register definitions a bit by correctly
> >>>>grouping the CTL and CTL2 definitions together.
> >>>>[..]
> >>>>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> >>>>index 4c844c6..5d215f0 100644
> >>>>--- a/drivers/gpu/drm/i915/intel_display.c
> >>>>+++ b/drivers/gpu/drm/i915/intel_display.c
> >>>>@@ -6482,9 +6482,6 @@ static struct intel_quirk intel_quirks[] = {
> >>>>
> >>>> /* Sony Vaio Y cannot use SSC on LVDS */
> >>>> { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
> >>>>-
> >>>>- /* Acer Aspire 5734Z must invert backlight brightness */
> >>>>- { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
> >>>Made a first test with these lines removed and the new mechanism
> >>>added. Unfortunately, the screen is now dark again. Works after
> >>>re-adding the quirk.
> >>>
> >>>>+ /* gen4 has a polarity bit */
> >>>>+ if (IS_GEN4(dev) && (I915_READ(BLC_PWM_CTL2) & BLM_POLARITY_I965))
> >>>>+ return intel_panel_get_max_backlight(dev) - val;
> >>>>+
> >>>Apparently, these conditions are not met on the Acer Aspire 5734Z.
> >>>Will add some debug output and evaluate further. For the time being,
> >>>please leave the quirk in place.
> >>
> >>Hm, I've tried this and when I set this bit, panel brightness is inverted
> >>on my gm45. Can you install intel-gpu-tools and read out the 2 backlight
> >>control registers with
> >>
> >># intel_reg_read 0x61254
> >># intel_reg_read 0x61250
> >
> >I've forgotten to add: Also please grab these register values when booting
> >with nomodeset, so that we can compare the values the bios sets with
> >whatever i915 sets.
>
> Without nomodeset:
> # intel_reg_read 0x61254
> 0x61254 : 0xB4A0B4A
> # intel_reg_read 0x61250
> 0x61250 : 0xE0000000
>
> With nomodeset:
> # intel_reg_read 0x61254
> 0x61254 : 0xB4A0B4A
> # intel_reg_read 0x61250
> 0x61250 : 0xE0000000
>
> Thus, (I915_READ(BLC_PWM_CTL2) & BLM_POLARITY_I965) is never set.
> But bit 29 would work, so we could add another conditional such as:
> #define BLM_POLARITY_PCH_I965 (1 << 29) /* PCH only */
> if (PCH)
> try (I915_READ(BLC_PWM_CTL2) & BLM_POLARITY_PCH_I965)
Ok, let's try something funny. Please boot with kms enabled and try out
what the following values for CTL1 do:
# intel_reg_write 0x61250 0x80000000
# intel_reg_write 0x61250 0xa0000000
# intel_reg_write 0x61250 0x90000000
# intel_reg_write 0x61250 0xb0000000
Thanks, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-04-23 13:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 9:32 [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4 Daniel Vetter
2012-04-23 9:32 ` [PATCH 2/2] drm/i915: pnv has a backlight polarity control bit, too Daniel Vetter
2012-04-23 10:27 ` Chris Wilson
2012-04-23 9:53 ` [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4 Chris Wilson
2012-04-23 12:21 ` Daniel Vetter
2012-04-23 12:32 ` Chris Wilson
2012-04-23 13:48 ` Daniel Vetter
[not found] ` <4F9542EF.3010208@osadl.org>
2012-04-23 12:32 ` Daniel Vetter
2012-04-23 12:36 ` Daniel Vetter
2012-04-23 13:15 ` Carsten Emde
2012-04-23 13:39 ` Daniel Vetter [this message]
2012-04-23 14:00 ` Carsten Emde
2012-04-23 14:22 ` Daniel Vetter
2012-04-23 15:06 ` Carsten Emde
2012-04-23 15:22 ` Daniel Vetter
2012-04-23 15:38 ` Carsten Emde
2012-04-23 15:56 ` Daniel Vetter
2012-04-23 16:55 ` Carsten Emde
2012-04-26 16:48 ` [PATCH 0/4] drm/i915: " Carsten Emde
2012-04-26 16:48 ` [PATCH 1/4] drm/i915: " Carsten Emde
2012-04-26 16:48 ` [PATCH 2/4] drm/i915: completely revert the invert brightness quirk Carsten Emde
2012-04-26 16:48 ` [PATCH 3/4] drm/i915: add quirk to indicate that an alt bit is used for brightness inversion Carsten Emde
2012-04-26 17:08 ` Daniel Vetter
2012-04-26 17:25 ` [PATCH] properly enable the blc controller on the right pipe Daniel Vetter
2012-04-26 17:27 ` Daniel Vetter
2012-04-26 19:12 ` Carsten Emde
2012-04-26 19:30 ` Daniel Vetter
2012-04-27 20:18 ` Carsten Emde
2012-06-02 23:08 ` Daniel Vetter
2012-06-11 8:51 ` Daniel Vetter
2012-07-19 14:00 ` Carsten Emde
2012-07-19 14:40 ` Daniel Vetter
2012-07-19 22:51 ` Carsten Emde
2012-07-20 8:10 ` Daniel Vetter
2012-07-24 7:30 ` Carsten Emde
2012-07-25 22:35 ` Carsten Emde
2012-07-26 11:55 ` [PATCH] drm/i915 disable combination mode Daniel Vetter
2012-07-26 12:20 ` Daniel Vetter
2012-07-26 12:36 ` Daniel Vetter
2012-07-26 14:09 ` Daniel Vetter
2012-04-26 16:48 ` [PATCH 4/4] drm/i915: assign the brightness inversion quirk to Acer Aspire 5734Z Carsten Emde
2012-04-27 16:17 ` [PATCH 0/4] drm/i915: Re: clear up backlight inversion confusion on gen4 Monark Gondaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423133934.GG4935@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=C.Emde@osadl.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).