Re: [PATCH] properly enable the blc controller on the right pipe

From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Carsten Emde <C.Emde@osadl.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] properly enable the blc controller on the right pipe
Date: Thu, 19 Jul 2012 16:40:03 +0200	[thread overview]
Message-ID: <CAKMK7uFDXLNt3Sps-6Nc8OZssFbXTB3Bo4oJGDGUA7CSkEGxsQ@mail.gmail.com> (raw)
In-Reply-To: <50081313.8070206@osadl.org>

On Thu, Jul 19, 2012 at 4:00 PM, Carsten Emde <C.Emde@osadl.org> wrote:
> On 06/11/2012 10:51 AM, Daniel Vetter wrote:
>> I've updated my backlight-confusion branch with new patches for gen4
>> (it doesn't seem to work for these machines yet). Can you please test
>> the updated branch?
>
> I have added an additional test rack (#6) to our QA farm (osadl.org/QA) and
> populated this rack solely with notebooks that are equipped with Intel
> graphics board:
>
> Slot #1: Lenovo T61/7661W4G, Intel GMA X3100
> Slot #2: IBM T601951-A47, Intel GMA 950
> Slot #4: Acer Homa/Extensa 5230E-901G16N, Intel GMA 4500MHD
> Slot #5: Acer Morar/TravelMate 2410, Intel GMA 900
> Slot #6: Dell Inspirion 1300/0RJ272, Intel GMA 900
> Slot #7: Acer Aspire 5734Z, Intel GMA 4500M
>
> With the exception of slot #4 that runs a 3.2-based kernel, all other
> notebooks run a 3.4-based kernel. The notebook in Slot #7 is the one with
> the backlight headache. Unfortunately :-; no other notebook had any
> backlight problem when running a vanilla kernel, even the two new Acers are
> behaving well.
>
> In the meantime, however, I have received a report that the Acer 5732Z has
> the same problem. I am sure that the reporter will be willing to help with
> testing. Looks like the backlight problem is very specific to Acer Aspire
> 573xZ. But I agree that a generic solution always is better than a quirk.
>
> I've checked out the backlight-confusion branch of your git tree and tested
> it with and without the Acer quirk. I can report that the backlight works
> correctly with either version. I will now contact the owner of the Acer
> Aspire 5732Z and ask him to test the backlight-confusion branch without the
> Acer quirk on his notebook as well.
>
> Do you wish me to do any other test?

Well, the backlight-confusion branch had a bug and outright disabled
the intel backlight :( drm-intel-next-queued should have fixes for all
the backlight goofus I've accidentally created, so testing feedback on
that branch would be highly appreciated.

Thanks, Daniel
-- 
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch