From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Carsten Emde <C.Emde@osadl.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] properly enable the blc controller on the right pipe
Date: Mon, 11 Jun 2012 10:51:19 +0200 [thread overview]
Message-ID: <CAKMK7uEb_F8eaif2YH4eTHfDPGnOC1NYPxEK1N9AnPJ05sNU3w@mail.gmail.com> (raw)
In-Reply-To: <20120602230800.GB4737@phenom.ffwll.local>
On Sun, Jun 3, 2012 at 1:08 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Apr 27, 2012 at 10:18:08PM +0200, Carsten Emde wrote:
>> Daniel,
>>
>> >>>Depending upon how things are set up, this might help.
>> >>Yeah, thanks a lot, works great now!
>> >>I removed patch 3/4 and 4/4 and pushed this one; so currently applied are:
>> >>[PATCH 1/4] drm/i915: clear up backlight inversion confusion on gen4
>> >>[PATCH 2/4] drm/i915: completely revert the invert brightness quirk
>> >>[PATCH] properly enable the blc controller on the right pipe
>> >Hey, that was just a quick hack to check things ;-)
>> Sorry, too many things in parallel.
>>
>> Spent some time reading the docs you mentioned - will continue to
>> work on the backlight brightness problem and prepare another patch.
>> I just need some more time.
>
> Ok, I've stitched together some real patches and actually tested them.
> While doing so I've noticed that the patch you've tested essentially
> disables the i915 backlight control and leaves everything to the legacy or
> platform backlight control.
>
> New patches are at
>
> http://cgit.freedesktop.org/~danvet/drm/log/?h=backlight-confusion
>
> Note that these do not include the revert for the backlight inversion
> quirk. You either have to revert that yourself for testing or disable the
> backlight inversion on the kernel bootline.
>
> Testing feedback highly welcome.
I've updated my backlight-confusion branch with new patches for gen4
(it doesn't seem to work for these machines yet). Can you please test
the updated branch?
Thanks, Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-06-11 8:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 9:32 [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4 Daniel Vetter
2012-04-23 9:32 ` [PATCH 2/2] drm/i915: pnv has a backlight polarity control bit, too Daniel Vetter
2012-04-23 10:27 ` Chris Wilson
2012-04-23 9:53 ` [PATCH 1/2] drm/i915: clear up backlight inversion confusion on gen4 Chris Wilson
2012-04-23 12:21 ` Daniel Vetter
2012-04-23 12:32 ` Chris Wilson
2012-04-23 13:48 ` Daniel Vetter
[not found] ` <4F9542EF.3010208@osadl.org>
2012-04-23 12:32 ` Daniel Vetter
2012-04-23 12:36 ` Daniel Vetter
2012-04-23 13:15 ` Carsten Emde
2012-04-23 13:39 ` Daniel Vetter
2012-04-23 14:00 ` Carsten Emde
2012-04-23 14:22 ` Daniel Vetter
2012-04-23 15:06 ` Carsten Emde
2012-04-23 15:22 ` Daniel Vetter
2012-04-23 15:38 ` Carsten Emde
2012-04-23 15:56 ` Daniel Vetter
2012-04-23 16:55 ` Carsten Emde
2012-04-26 16:48 ` [PATCH 0/4] drm/i915: " Carsten Emde
2012-04-26 16:48 ` [PATCH 1/4] drm/i915: " Carsten Emde
2012-04-26 16:48 ` [PATCH 2/4] drm/i915: completely revert the invert brightness quirk Carsten Emde
2012-04-26 16:48 ` [PATCH 3/4] drm/i915: add quirk to indicate that an alt bit is used for brightness inversion Carsten Emde
2012-04-26 17:08 ` Daniel Vetter
2012-04-26 17:25 ` [PATCH] properly enable the blc controller on the right pipe Daniel Vetter
2012-04-26 17:27 ` Daniel Vetter
2012-04-26 19:12 ` Carsten Emde
2012-04-26 19:30 ` Daniel Vetter
2012-04-27 20:18 ` Carsten Emde
2012-06-02 23:08 ` Daniel Vetter
2012-06-11 8:51 ` Daniel Vetter [this message]
2012-07-19 14:00 ` Carsten Emde
2012-07-19 14:40 ` Daniel Vetter
2012-07-19 22:51 ` Carsten Emde
2012-07-20 8:10 ` Daniel Vetter
2012-07-24 7:30 ` Carsten Emde
2012-07-25 22:35 ` Carsten Emde
2012-07-26 11:55 ` [PATCH] drm/i915 disable combination mode Daniel Vetter
2012-07-26 12:20 ` Daniel Vetter
2012-07-26 12:36 ` Daniel Vetter
2012-07-26 14:09 ` Daniel Vetter
2012-04-26 16:48 ` [PATCH 4/4] drm/i915: assign the brightness inversion quirk to Acer Aspire 5734Z Carsten Emde
2012-04-27 16:17 ` [PATCH 0/4] drm/i915: Re: clear up backlight inversion confusion on gen4 Monark Gondaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uEb_F8eaif2YH4eTHfDPGnOC1NYPxEK1N9AnPJ05sNU3w@mail.gmail.com \
--to=daniel.vetter@ffwll.ch \
--cc=C.Emde@osadl.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).