From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Scale ring, rather than ia, frequency on Haswell
Date: Wed, 10 Apr 2013 22:08:20 +0200 [thread overview]
Message-ID: <20130410200820.GL27612@phenom.ffwll.local> (raw)
In-Reply-To: <1365623111-3133-1-git-send-email-chris@chris-wilson.co.uk>
On Wed, Apr 10, 2013 at 08:45:11PM +0100, Chris Wilson wrote:
> Haswell introduces a separate frequency domain for the ring (uncore). So
> where we used to increase the CPU (IA) clock with GPU busyness, we now
> need to scale the ring frequency directly instead. As the ring limits
> our memory bandwidth, it is vital for performance that when the GPU is
> busy, we increase the frequency of the ring to increase the available
> memory bandwidth.
>
> v2: Fix the algorithm to actually use the scaled gpu frequency for the ring.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
I think this is another reason to split hsw rps code from snb/ivb. I think
I'll wait until Rodrigo's patch is in, and then apply this.
Call me a scared chicken, but I kinda am wrt rps stuff ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-04-10 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 19:22 [PATCH] drm/i915: Scale ring, rather than ia, frequency on Haswell Chris Wilson
2013-04-10 19:45 ` Chris Wilson
2013-04-10 20:08 ` Daniel Vetter [this message]
2013-04-10 21:41 ` Jesse Barnes
2013-04-10 21:53 ` Chris Wilson
2013-04-12 18:10 ` Chris Wilson
2013-04-16 7:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410200820.GL27612@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).