intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor
@ 2020-01-03  1:57 AJ_Cheng
  2020-01-03  9:16 ` [Intel-gfx] [alsa-devel] " Takashi Iwai
  0 siblings, 1 reply; 9+ messages in thread
From: AJ_Cheng @ 2020-01-03  1:57 UTC (permalink / raw)
  To: intel-gfx, alsa-devel
  Cc: CindyXT_Wang, Nelson_Ye, Shane_Yap, Lucien_Kao, Evan_Tseng


[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]

Hi Sirs,
        Here is chromebook SW team from Compal.
As the mail title, we hit issue that the external monitor will flash once when play video after hot pluging.
We can reproduce not only on chromebook but also ubuntu 16.04.
There has higher failure rate with Dell Solomon dock and Dell S2718D monitor.

We found adding the delay in "sound/pci/hda/patch_hdmi.c " can fix this issue.(as the attachment)
May need your help to review and advice. Thanks.

Here is the issue number in gitlab for more detail.
https://gitlab.freedesktop.org/drm/intel/issues/318



AJ Cheng
NID/NID1
e-mail: AJ_Cheng@compal.com<mailto:AJ_Cheng@compal.com>
Tel:  +886-2-8797-8599 ext. 17561
Mobile : +886-932827829
COMPAL Electronics, Inc.


[-- Attachment #1.2: Type: text/html, Size: 8485 bytes --]

[-- Attachment #2: flash_once.diff --]
[-- Type: application/octet-stream, Size: 593 bytes --]

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 4448ab6..77dc6b9 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -854,7 +854,7 @@ static void haswell_verify_D0(struct hda_codec *codec,
 	 * converters are in correct power state */
 	if (!snd_hda_check_power_state(codec, cvt_nid, AC_PWRST_D0))
 		snd_hda_codec_write(codec, cvt_nid, 0, AC_VERB_SET_POWER_STATE, AC_PWRST_D0);
-
+	msleep(40);
 	if (!snd_hda_check_power_state(codec, nid, AC_PWRST_D0)) {
 		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_POWER_STATE,
 				    AC_PWRST_D0);

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-02-12 16:54 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-03  1:57 [Intel-gfx] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor AJ_Cheng
2020-01-03  9:16 ` [Intel-gfx] [alsa-devel] " Takashi Iwai
2020-01-06  8:08   ` Lucien_Kao
2020-01-07 17:24     ` Nathan Ciobanu
2020-01-07 18:57       ` Takashi Iwai
2020-01-08  3:07         ` Lucien_Kao
2020-01-08  6:17           ` Takashi Iwai
2020-02-12  9:37             ` Lucien_Kao
2020-02-12 10:03               ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).