* [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps
@ 2021-07-19 22:13 Anusha Srivatsa
2021-07-19 22:13 ` [Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info() Anusha Srivatsa
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Anusha Srivatsa @ 2021-07-19 22:13 UTC (permalink / raw)
To: intel-gfx
With the addition of stepping info for
all platforms, lets use macros for handling them
and autogenerating code for all steps at a time.
Suggested-by: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_step.c | 14 ++++++++++++
drivers/gpu/drm/i915/intel_step.h | 37 +++++++++++++++++++------------
2 files changed, 37 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c
index 9fcf17708cc8..e9ec111d6232 100644
--- a/drivers/gpu/drm/i915/intel_step.c
+++ b/drivers/gpu/drm/i915/intel_step.c
@@ -182,3 +182,17 @@ void intel_step_init(struct drm_i915_private *i915)
RUNTIME_INFO(i915)->step = step;
}
+
+#define STEP_NAME_CASE(name) \
+ case STEP_##name: \
+ return #name;
+
+const char *intel_step_name(enum intel_step step)
+{
+ switch (step) {
+ STEP_NAME_LIST(STEP_NAME_CASE);
+
+ default:
+ return "**";
+ }
+}
diff --git a/drivers/gpu/drm/i915/intel_step.h b/drivers/gpu/drm/i915/intel_step.h
index 88a77159703e..f6641e2a3c77 100644
--- a/drivers/gpu/drm/i915/intel_step.h
+++ b/drivers/gpu/drm/i915/intel_step.h
@@ -15,30 +15,39 @@ struct intel_step_info {
u8 display_step;
};
+#define STEP_ENUM_VAL(name) STEP_##name,
+
+#define STEP_NAME_LIST(func) \
+ func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0)
+
/*
* Symbolic steppings that do not match the hardware. These are valid both as gt
* and display steppings as symbolic names.
*/
enum intel_step {
STEP_NONE = 0,
- STEP_A0,
- STEP_A2,
- STEP_B0,
- STEP_B1,
- STEP_C0,
- STEP_D0,
- STEP_D1,
- STEP_E0,
- STEP_F0,
- STEP_G0,
- STEP_H0,
- STEP_I0,
- STEP_I1,
- STEP_J0,
+ STEP_NAME_LIST(STEP_ENUM_VAL)
STEP_FUTURE,
STEP_FOREVER,
};
void intel_step_init(struct drm_i915_private *i915);
+const char *intel_step_name(enum intel_step step);
#endif /* __INTEL_STEP_H__ */
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info()
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
@ 2021-07-19 22:13 ` Anusha Srivatsa
2021-07-19 22:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Anusha Srivatsa @ 2021-07-19 22:13 UTC (permalink / raw)
To: intel-gfx
Lets use RUNTIME_INFO->step since all platforms now have their
stepping info in intel_step.c. This makes intel_get_stepping_info()
a lot simpler.
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dmc.c | 50 ++++--------------------
1 file changed, 8 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index f8789d4543bf..1f6c32932331 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -247,50 +247,15 @@ bool intel_dmc_has_payload(struct drm_i915_private *i915)
return i915->dmc.dmc_info[DMC_FW_MAIN].payload;
}
-static const struct stepping_info skl_stepping_info[] = {
- {'A', '0'}, {'B', '0'}, {'C', '0'},
- {'D', '0'}, {'E', '0'}, {'F', '0'},
- {'G', '0'}, {'H', '0'}, {'I', '0'},
- {'J', '0'}, {'K', '0'}
-};
-
-static const struct stepping_info bxt_stepping_info[] = {
- {'A', '0'}, {'A', '1'}, {'A', '2'},
- {'B', '0'}, {'B', '1'}, {'B', '2'}
-};
-
-static const struct stepping_info icl_stepping_info[] = {
- {'A', '0'}, {'A', '1'}, {'A', '2'},
- {'B', '0'}, {'B', '2'},
- {'C', '0'}
-};
-
-static const struct stepping_info no_stepping_info = { '*', '*' };
-
static const struct stepping_info *
-intel_get_stepping_info(struct drm_i915_private *dev_priv)
+intel_get_stepping_info(struct drm_i915_private *i915,
+ struct stepping_info *si)
{
- const struct stepping_info *si;
- unsigned int size;
-
- if (IS_ICELAKE(dev_priv)) {
- size = ARRAY_SIZE(icl_stepping_info);
- si = icl_stepping_info;
- } else if (IS_SKYLAKE(dev_priv)) {
- size = ARRAY_SIZE(skl_stepping_info);
- si = skl_stepping_info;
- } else if (IS_BROXTON(dev_priv)) {
- size = ARRAY_SIZE(bxt_stepping_info);
- si = bxt_stepping_info;
- } else {
- size = 0;
- si = NULL;
- }
-
- if (INTEL_REVID(dev_priv) < size)
- return si + INTEL_REVID(dev_priv);
+ const char *step_name = intel_step_name(RUNTIME_INFO(i915)->step.display_step);
- return &no_stepping_info;
+ si->stepping = step_name[0];
+ si->substepping = step_name[1];
+ return si;
}
static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
@@ -616,7 +581,8 @@ static void parse_dmc_fw(struct drm_i915_private *dev_priv,
struct intel_package_header *package_header;
struct intel_dmc_header_base *dmc_header;
struct intel_dmc *dmc = &dev_priv->dmc;
- const struct stepping_info *si = intel_get_stepping_info(dev_priv);
+ struct stepping_info display_info = { '*', '*'};
+ const struct stepping_info *si = intel_get_stepping_info(dev_priv, &display_info);
u32 readcount = 0;
u32 r, offset;
int id;
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
2021-07-19 22:13 ` [Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info() Anusha Srivatsa
@ 2021-07-19 22:32 ` Patchwork
2021-07-19 22:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-19 22:32 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
URL : https://patchwork.freedesktop.org/series/92735/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
29663fa4daa2 drm/i915/step: Add macro magic for handling steps
-:24: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name) \
+ case STEP_##name: \
+ return #name;
-:24: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#24: FILE: drivers/gpu/drm/i915/intel_step.c:186:
+#define STEP_NAME_CASE(name) \
+ case STEP_##name: \
+ return #name;
-:47: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func) \
+ func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0)
-:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects?
#47: FILE: drivers/gpu/drm/i915/intel_step.h:20:
+#define STEP_NAME_LIST(func) \
+ func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0)
total: 2 errors, 1 warnings, 1 checks, 70 lines checked
e9092fbd9b75 drm/i915/dmc: Change intel_get_stepping_info()
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
2021-07-19 22:13 ` [Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info() Anusha Srivatsa
2021-07-19 22:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps Patchwork
@ 2021-07-19 22:33 ` Patchwork
2021-07-19 22:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-19 22:33 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
URL : https://patchwork.freedesktop.org/series/92735/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1896:21: expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1896:21: got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1896:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gem/i915_gem_context.c:1412:34: expected struct i915_address_space *vm
+drivers/gpu/drm/i915/gem/i915_gem_context.c:1412:34: got struct i915_address_space [noderef] __rcu *vm
+drivers/gpu/drm/i915/gem/i915_gem_context.c:1412:34: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: expected struct i915_address_space [noderef] __rcu *vm
+drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: got struct i915_address_space *
+drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: expected struct i915_address_space *vm
+drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: got struct i915_address_space [noderef] __rcu *vm
+drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+drivers/gpu/drm/i915/gt/intel_ring_submission.c:1210:24: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
` (2 preceding siblings ...)
2021-07-19 22:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2021-07-19 22:37 ` Patchwork
2021-07-19 23:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-20 2:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-19 22:37 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
URL : https://patchwork.freedesktop.org/series/92735/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Function parameter or member 'trampoline' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
` (3 preceding siblings ...)
2021-07-19 22:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
@ 2021-07-19 23:01 ` Patchwork
2021-07-20 2:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-19 23:01 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3299 bytes --]
== Series Details ==
Series: series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
URL : https://patchwork.freedesktop.org/series/92735/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10354 -> Patchwork_20649
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/index.html
Known issues
------------
Here are the changes found in Patchwork_20649 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +23 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#3718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@gt_pm:
- fi-icl-y: [PASS][3] -> [DMESG-FAIL][4] ([i915#2291])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/fi-icl-y/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/fi-icl-y/igt@i915_selftest@live@gt_pm.html
* igt@runner@aborted:
- fi-kbl-7500u: NOTRUN -> [FAIL][5] ([i915#1814] / [i915#3363])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/fi-kbl-7500u/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][6] ([i915#1888]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
Participating hosts (38 -> 35)
------------------------------
Additional (1): fi-kbl-7500u
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10354 -> Patchwork_20649
CI-20190529: 20190529
CI_DRM_10354: 5b085adbd699d92f00f191551e35ed14dab681f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6146: 6caef22e4aafed275771f564d4ea4cab09896ebc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20649: e9092fbd9b753c01c1bfdd0d86dea376cbff4c32 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e9092fbd9b75 drm/i915/dmc: Change intel_get_stepping_info()
29663fa4daa2 drm/i915/step: Add macro magic for handling steps
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/index.html
[-- Attachment #1.2: Type: text/html, Size: 4028 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
` (4 preceding siblings ...)
2021-07-19 23:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-07-20 2:21 ` Patchwork
5 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2021-07-20 2:21 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30302 bytes --]
== Series Details ==
Series: series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps
URL : https://patchwork.freedesktop.org/series/92735/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10354_full -> Patchwork_20649_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20649_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_20649_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20649_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@engines-hostile@vcs1:
- shard-tglb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-tglb2/igt@gem_ctx_persistence@engines-hostile@vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb2/igt@gem_ctx_persistence@engines-hostile@vcs1.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- shard-skl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl1/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
Known issues
------------
Here are the changes found in Patchwork_20649_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-4x:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk2/igt@feature_discovery@display-4x.html
- shard-tglb: NOTRUN -> [SKIP][6] ([i915#1839])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb6/igt@feature_discovery@display-4x.html
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-snb5/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][8] ([i915#2846])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
- shard-glk: NOTRUN -> [FAIL][15] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_pread@exhaustion:
- shard-iclb: NOTRUN -> [WARN][16] ([i915#2658]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@gem_pread@exhaustion.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][17] ([i915#2724])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-snb2/igt@gem_userptr_blits@vma-merge.html
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#3318])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb7/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@allowed-all:
- shard-skl: [PASS][19] -> [DMESG-WARN][20] ([i915#1436] / [i915#716])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl4/igt@gen9_exec_parse@allowed-all.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl3/igt@gen9_exec_parse@allowed-all.html
* igt@i915_selftest@mock@vma:
- shard-snb: NOTRUN -> [DMESG-WARN][21] ([i915#3746]) +17 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-snb5/igt@i915_selftest@mock@vma.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: NOTRUN -> [DMESG-WARN][22] ([i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][23] ([i915#3722])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#110725] / [fdo#111614])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_big_fb@y-tiled-8bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3777])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111615])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_chamelium@dp-crc-fast:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109284] / [fdo#111827]) +6 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +16 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_color_chamelium@pipe-c-ctm-negative.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-glk: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk2/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109284] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb6/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +8 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#3116])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_cursor_crc@pipe-a-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3359])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-32x10-sliding.html
* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][36] ([fdo#109271]) +351 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-snb2/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109274] / [fdo#109278]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][38] -> [FAIL][39] ([i915#2346])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: NOTRUN -> [FAIL][40] ([i915#2346] / [i915#533])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-flip-vs-modeset-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109274]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#79])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][44] -> [FAIL][45] ([i915#79])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [PASS][48] -> [FAIL][49] ([i915#2122])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl5/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#2587])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#111825]) +6 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271]) +30 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271]) +36 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109280]) +9 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_hdr@static-toggle-suspend:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#1187])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@kms_hdr@static-toggle-suspend.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl3/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][57] -> [DMESG-WARN][58] ([i915#180]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [PASS][59] -> [INCOMPLETE][60] ([i915#198])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][61] ([fdo#108145] / [i915#265]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][62] ([fdo#108145] / [i915#265])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][63] -> [FAIL][64] ([fdo#108145] / [i915#265])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-b-tiling-none:
- shard-iclb: NOTRUN -> [SKIP][65] ([i915#3536])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@kms_plane_lowres@pipe-b-tiling-none.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#658]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-iclb: NOTRUN -> [SKIP][67] ([i915#658])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#658]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][70] -> [SKIP][71] ([fdo#109642] / [fdo#111068] / [i915#658])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb2/igt@kms_psr2_su@page_flip.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109441])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [PASS][73] -> [SKIP][74] ([fdo#109441])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb2/igt@kms_psr@psr2_primary_render.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@kms_psr@psr2_primary_render.html
* igt@kms_psr@psr2_sprite_blt:
- shard-tglb: NOTRUN -> [FAIL][75] ([i915#132] / [i915#3467])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb7/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-d-ts-continuation-idle-hang:
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109278]) +21 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@kms_vblank@pipe-d-ts-continuation-idle-hang.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271]) +103 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl8/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@perf@blocking:
- shard-skl: [PASS][78] -> [FAIL][79] ([i915#1542])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl8/igt@perf@blocking.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl9/igt@perf@blocking.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][80] -> [FAIL][81] ([i915#1722])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl10/igt@perf@polling-small-buf.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl1/igt@perf@polling-small-buf.html
* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109291])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@prime_nv_test@i915_blt_fill_nv_read.html
* igt@prime_vgem@coherency-gtt:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#111656])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb7/igt@prime_vgem@coherency-gtt.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@sema-10:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2994])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@sysfs_clients@sema-10.html
#### Possible fixes ####
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][86] ([i915#2410]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][88] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-tglb3/igt@gem_eio@unwedge-stress.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb2/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][90] ([i915#2842]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [FAIL][92] ([i915#2842]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-tglb5/igt@gem_exec_fair@basic-pace@vcs1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-tglb3/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][94] ([i915#2842]) -> [PASS][95] +2 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
- shard-iclb: [FAIL][96] ([i915#2842]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb3/igt@gem_exec_fair@basic-pace@vecs0.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_flush@basic-uc-rw-default:
- shard-glk: [INCOMPLETE][98] ([i915#2369]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-glk6/igt@gem_exec_flush@basic-uc-rw-default.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk2/igt@gem_exec_flush@basic-uc-rw-default.html
* igt@gem_exec_whisper@basic-fds-priority:
- shard-glk: [DMESG-WARN][100] ([i915#118] / [i915#95]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-glk4/igt@gem_exec_whisper@basic-fds-priority.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk1/igt@gem_exec_whisper@basic-fds-priority.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][102] ([i915#2428]) -> [PASS][103] +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb6/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
- shard-glk: [FAIL][104] ([i915#307]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-glk5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-glk7/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [DMESG-FAIL][106] ([i915#3698]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb6/igt@i915_pm_dc@dc5-dpms.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb7/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [INCOMPLETE][108] ([i915#151]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl1/igt@i915_pm_rpm@system-suspend-modeset.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl8/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][110] ([i915#2782]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-snb6/igt@i915_selftest@live@hangcheck.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-snb5/igt@i915_selftest@live@hangcheck.html
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [DMESG-WARN][112] ([i915#1982]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl5/igt@kms_color@pipe-c-ctm-0-75.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl2/igt@kms_color@pipe-c-ctm-0-75.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [FAIL][116] ([i915#2346]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled:
- shard-skl: [FAIL][118] -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][120] ([i915#180] / [i915#1982]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][122] ([fdo#108145] / [i915#265]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][124] ([fdo#109441]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][126] ([i915#1542]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl3/igt@perf@polling-parameterized.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl10/igt@perf@polling-parameterized.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][128] ([i915#1982] / [i915#262]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-skl1/igt@perf_pmu@module-unload.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-skl2/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][130] ([i915#2851]) -> [FAIL][131] ([i915#2842])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][132] ([i915#2684]) -> [WARN][133] ([i915#1804] / [i915#2684])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-iclb: [SKIP][134] ([i915#658]) -> [SKIP][135] ([i915#2920])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-iclb8/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139]) ([i915#1814] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146]) ([i915#180] / [i915#1814] / [i915#2292] / [i915#3002] / [i915#3363])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl4/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl6/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl7/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10354/shard-kbl6/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl2/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl4/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl7/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl7/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl4/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl7/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/shard-kbl4/igt@runner@aborted.html
- shard-iclb: ([FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150]) ([i915#1814] / [i915#3002]) -> ([FAIL][151], [FAIL][152
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20649/index.html
[-- Attachment #1.2: Type: text/html, Size: 34039 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps
2021-08-12 9:59 ` Jani Nikula
@ 2021-08-12 16:05 ` Srivatsa, Anusha
0 siblings, 0 replies; 11+ messages in thread
From: Srivatsa, Anusha @ 2021-08-12 16:05 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Roper, Matthew D, De Marchi, Lucas
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Thursday, August 12, 2021 2:59 AM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Roper, Matthew D <matthew.d.roper@intel.com>; De Marchi, Lucas
> <lucas.demarchi@intel.com>
> Subject: Re: [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling
> steps
>
> On Mon, 19 Jul 2021, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> > With the addition of stepping info for all platforms, lets use macros
> > for handling them and autogenerating code for all steps at a time.
> >
> > Suggested-by: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_step.c | 14 ++++++++++++
> > drivers/gpu/drm/i915/intel_step.h | 37 +++++++++++++++++++------------
> > 2 files changed, 37 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_step.c
> > b/drivers/gpu/drm/i915/intel_step.c
> > index 9fcf17708cc8..d150d138e889 100644
> > --- a/drivers/gpu/drm/i915/intel_step.c
> > +++ b/drivers/gpu/drm/i915/intel_step.c
> > @@ -182,3 +182,17 @@ void intel_step_init(struct drm_i915_private
> > *i915)
> >
> > RUNTIME_INFO(i915)->step = step;
> > }
> > +
> > +#define STEP_NAME_CASE(name) \
> > + (case STEP_##name: \
> > + return #name)
> > +
> > +const char *intel_step_name(enum intel_step step) {
> > + switch (step) {
> > + STEP_NAME_LIST(STEP_NAME_CASE);
> > +
> > + default:
> > + return "**";
> > + }
> > +}
> > diff --git a/drivers/gpu/drm/i915/intel_step.h
> > b/drivers/gpu/drm/i915/intel_step.h
> > index 88a77159703e..f6641e2a3c77 100644
> > --- a/drivers/gpu/drm/i915/intel_step.h
> > +++ b/drivers/gpu/drm/i915/intel_step.h
> > @@ -15,30 +15,39 @@ struct intel_step_info {
> > u8 display_step;
> > };
> >
> > +#define STEP_ENUM_VAL(name) STEP_##name,
> > +
> > +#define STEP_NAME_LIST(func) \
> > + func(A0) \
> > + func(A1) \
> > + func(A2) \
> > + func(B0) \
> > + func(B1) \
> > + func(B2) \
> > + func(C0) \
> > + func(C1) \
> > + func(D0) \
> > + func(D1) \
> > + func(E0) \
> > + func(F0) \
> > + func(G0) \
> > + func(H0) \
> > + func(I0) \
> > + func(I1) \
> > + func(J0)
> > +
> > /*
> > * Symbolic steppings that do not match the hardware. These are valid
> both as gt
> > * and display steppings as symbolic names.
> > */
> > enum intel_step {
> > STEP_NONE = 0,
> > - STEP_A0,
> > - STEP_A2,
> > - STEP_B0,
> > - STEP_B1,
> > - STEP_C0,
> > - STEP_D0,
> > - STEP_D1,
> > - STEP_E0,
> > - STEP_F0,
> > - STEP_G0,
> > - STEP_H0,
> > - STEP_I0,
> > - STEP_I1,
> > - STEP_J0,
> > + STEP_NAME_LIST(STEP_ENUM_VAL)
> > STEP_FUTURE,
> > STEP_FOREVER,
> > };
>
> It's been merged already, and so be it.
>
> I'll just note that the main reason I don't like adding this kind of macro
> abstractions is that it throws off source code tagging tools like ctags and gnu
> global. I can no longer navigate the definition and all the references of
> STEP_* using the tools, and it degenerates to git grep which is much worse as
> it doesn't know about C syntax or semantics. It's not always about how the
> code looks, it's also about how people can navigate the code base.
Had not considered that :-/ will keep this in mind from now on.
Thanks for the feedback.
Anusha
> BR,
> Jani.
>
>
> >
> > void intel_step_init(struct drm_i915_private *i915);
> > +const char *intel_step_name(enum intel_step step);
> >
> > #endif /* __INTEL_STEP_H__ */
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps
2021-07-19 21:38 [Intel-gfx] [CI 1/2] " Anusha Srivatsa
@ 2021-08-12 9:59 ` Jani Nikula
2021-08-12 16:05 ` Srivatsa, Anusha
0 siblings, 1 reply; 11+ messages in thread
From: Jani Nikula @ 2021-08-12 9:59 UTC (permalink / raw)
To: Anusha Srivatsa, intel-gfx; +Cc: Matt Roper, Lucas De Marchi
On Mon, 19 Jul 2021, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> With the addition of stepping info for
> all platforms, lets use macros for handling them
> and autogenerating code for all steps at a time.
>
> Suggested-by: Matt Roper <matthew.d.roper@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_step.c | 14 ++++++++++++
> drivers/gpu/drm/i915/intel_step.h | 37 +++++++++++++++++++------------
> 2 files changed, 37 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c
> index 9fcf17708cc8..d150d138e889 100644
> --- a/drivers/gpu/drm/i915/intel_step.c
> +++ b/drivers/gpu/drm/i915/intel_step.c
> @@ -182,3 +182,17 @@ void intel_step_init(struct drm_i915_private *i915)
>
> RUNTIME_INFO(i915)->step = step;
> }
> +
> +#define STEP_NAME_CASE(name) \
> + (case STEP_##name: \
> + return #name)
> +
> +const char *intel_step_name(enum intel_step step)
> +{
> + switch (step) {
> + STEP_NAME_LIST(STEP_NAME_CASE);
> +
> + default:
> + return "**";
> + }
> +}
> diff --git a/drivers/gpu/drm/i915/intel_step.h b/drivers/gpu/drm/i915/intel_step.h
> index 88a77159703e..f6641e2a3c77 100644
> --- a/drivers/gpu/drm/i915/intel_step.h
> +++ b/drivers/gpu/drm/i915/intel_step.h
> @@ -15,30 +15,39 @@ struct intel_step_info {
> u8 display_step;
> };
>
> +#define STEP_ENUM_VAL(name) STEP_##name,
> +
> +#define STEP_NAME_LIST(func) \
> + func(A0) \
> + func(A1) \
> + func(A2) \
> + func(B0) \
> + func(B1) \
> + func(B2) \
> + func(C0) \
> + func(C1) \
> + func(D0) \
> + func(D1) \
> + func(E0) \
> + func(F0) \
> + func(G0) \
> + func(H0) \
> + func(I0) \
> + func(I1) \
> + func(J0)
> +
> /*
> * Symbolic steppings that do not match the hardware. These are valid both as gt
> * and display steppings as symbolic names.
> */
> enum intel_step {
> STEP_NONE = 0,
> - STEP_A0,
> - STEP_A2,
> - STEP_B0,
> - STEP_B1,
> - STEP_C0,
> - STEP_D0,
> - STEP_D1,
> - STEP_E0,
> - STEP_F0,
> - STEP_G0,
> - STEP_H0,
> - STEP_I0,
> - STEP_I1,
> - STEP_J0,
> + STEP_NAME_LIST(STEP_ENUM_VAL)
> STEP_FUTURE,
> STEP_FOREVER,
> };
It's been merged already, and so be it.
I'll just note that the main reason I don't like adding this kind of
macro abstractions is that it throws off source code tagging tools like
ctags and gnu global. I can no longer navigate the definition and all
the references of STEP_* using the tools, and it degenerates to git grep
which is much worse as it doesn't know about C syntax or semantics. It's
not always about how the code looks, it's also about how people can
navigate the code base.
BR,
Jani.
>
> void intel_step_init(struct drm_i915_private *i915);
> +const char *intel_step_name(enum intel_step step);
>
> #endif /* __INTEL_STEP_H__ */
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps
@ 2021-07-19 21:38 Anusha Srivatsa
2021-08-12 9:59 ` Jani Nikula
0 siblings, 1 reply; 11+ messages in thread
From: Anusha Srivatsa @ 2021-07-19 21:38 UTC (permalink / raw)
To: intel-gfx
With the addition of stepping info for
all platforms, lets use macros for handling them
and autogenerating code for all steps at a time.
Suggested-by: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_step.c | 14 ++++++++++++
drivers/gpu/drm/i915/intel_step.h | 37 +++++++++++++++++++------------
2 files changed, 37 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c
index 9fcf17708cc8..d150d138e889 100644
--- a/drivers/gpu/drm/i915/intel_step.c
+++ b/drivers/gpu/drm/i915/intel_step.c
@@ -182,3 +182,17 @@ void intel_step_init(struct drm_i915_private *i915)
RUNTIME_INFO(i915)->step = step;
}
+
+#define STEP_NAME_CASE(name) \
+ (case STEP_##name: \
+ return #name)
+
+const char *intel_step_name(enum intel_step step)
+{
+ switch (step) {
+ STEP_NAME_LIST(STEP_NAME_CASE);
+
+ default:
+ return "**";
+ }
+}
diff --git a/drivers/gpu/drm/i915/intel_step.h b/drivers/gpu/drm/i915/intel_step.h
index 88a77159703e..f6641e2a3c77 100644
--- a/drivers/gpu/drm/i915/intel_step.h
+++ b/drivers/gpu/drm/i915/intel_step.h
@@ -15,30 +15,39 @@ struct intel_step_info {
u8 display_step;
};
+#define STEP_ENUM_VAL(name) STEP_##name,
+
+#define STEP_NAME_LIST(func) \
+ func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0)
+
/*
* Symbolic steppings that do not match the hardware. These are valid both as gt
* and display steppings as symbolic names.
*/
enum intel_step {
STEP_NONE = 0,
- STEP_A0,
- STEP_A2,
- STEP_B0,
- STEP_B1,
- STEP_C0,
- STEP_D0,
- STEP_D1,
- STEP_E0,
- STEP_F0,
- STEP_G0,
- STEP_H0,
- STEP_I0,
- STEP_I1,
- STEP_J0,
+ STEP_NAME_LIST(STEP_ENUM_VAL)
STEP_FUTURE,
STEP_FOREVER,
};
void intel_step_init(struct drm_i915_private *i915);
+const char *intel_step_name(enum intel_step step);
#endif /* __INTEL_STEP_H__ */
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps
@ 2021-07-19 20:00 Anusha Srivatsa
0 siblings, 0 replies; 11+ messages in thread
From: Anusha Srivatsa @ 2021-07-19 20:00 UTC (permalink / raw)
To: intel-gfx
With the addition of stepping info for
all platforms, lets use macros for handling them
and autogenerating code for all steps at a time.
Suggested-by: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/intel_step.c | 14 ++++++++++++
drivers/gpu/drm/i915/intel_step.h | 37 +++++++++++++++++++------------
2 files changed, 37 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_step.c b/drivers/gpu/drm/i915/intel_step.c
index 9fcf17708cc8..d150d138e889 100644
--- a/drivers/gpu/drm/i915/intel_step.c
+++ b/drivers/gpu/drm/i915/intel_step.c
@@ -182,3 +182,17 @@ void intel_step_init(struct drm_i915_private *i915)
RUNTIME_INFO(i915)->step = step;
}
+
+#define STEP_NAME_CASE(name) \
+ (case STEP_##name: \
+ return #name)
+
+const char *intel_step_name(enum intel_step step)
+{
+ switch (step) {
+ STEP_NAME_LIST(STEP_NAME_CASE);
+
+ default:
+ return "**";
+ }
+}
diff --git a/drivers/gpu/drm/i915/intel_step.h b/drivers/gpu/drm/i915/intel_step.h
index 88a77159703e..d8888ac4e94f 100644
--- a/drivers/gpu/drm/i915/intel_step.h
+++ b/drivers/gpu/drm/i915/intel_step.h
@@ -15,30 +15,39 @@ struct intel_step_info {
u8 display_step;
};
+#define STEP_ENUM_VAL(name) STEP_##name,
+
+#define STEP_NAME_LIST(func) \
+ (func(A0) \
+ func(A1) \
+ func(A2) \
+ func(B0) \
+ func(B1) \
+ func(B2) \
+ func(C0) \
+ func(C1) \
+ func(D0) \
+ func(D1) \
+ func(E0) \
+ func(F0) \
+ func(G0) \
+ func(H0) \
+ func(I0) \
+ func(I1) \
+ func(J0))
+
/*
* Symbolic steppings that do not match the hardware. These are valid both as gt
* and display steppings as symbolic names.
*/
enum intel_step {
STEP_NONE = 0,
- STEP_A0,
- STEP_A2,
- STEP_B0,
- STEP_B1,
- STEP_C0,
- STEP_D0,
- STEP_D1,
- STEP_E0,
- STEP_F0,
- STEP_G0,
- STEP_H0,
- STEP_I0,
- STEP_I1,
- STEP_J0,
+ STEP_NAME_LIST(STEP_ENUM_VAL)
STEP_FUTURE,
STEP_FOREVER,
};
void intel_step_init(struct drm_i915_private *i915);
+const char *intel_step_name(enum intel_step step);
#endif /* __INTEL_STEP_H__ */
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-08-12 16:10 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 22:13 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
2021-07-19 22:13 ` [Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info() Anusha Srivatsa
2021-07-19 22:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps Patchwork
2021-07-19 22:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-19 22:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-07-19 23:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-20 2:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-07-19 21:38 [Intel-gfx] [CI 1/2] " Anusha Srivatsa
2021-08-12 9:59 ` Jani Nikula
2021-08-12 16:05 ` Srivatsa, Anusha
2021-07-19 20:00 Anusha Srivatsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).