* [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers
[not found] <20210721175526.22020-1-sean@poorly.run>
@ 2021-07-21 17:55 ` Sean Paul
2021-07-28 14:39 ` jim.cromie
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog Sean Paul
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 12/14] drm/i915: Use debug category printer for welcome message Sean Paul
2 siblings, 1 reply; 4+ messages in thread
From: Sean Paul @ 2021-07-21 17:55 UTC (permalink / raw)
To: dri-devel, ppaalanen, maarten.lankhorst, tzimmermann, airlied,
daniel.vetter
Cc: intel-gfx, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
Use drm logging helpers to add support for the upcoming tracefs
implementation.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-sean@poorly.run #v5
Changes in v5:
-Added to the set
Changes in v6:
-None
---
drivers/gpu/drm/i915/i915_utils.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
index f9e780dee9de..d858c92c6997 100644
--- a/drivers/gpu/drm/i915/i915_utils.c
+++ b/drivers/gpu/drm/i915/i915_utils.c
@@ -30,10 +30,9 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
vaf.va = &args;
if (is_error)
- dev_printk(level, kdev, "%pV", &vaf);
+ drm_dev_printk(kdev, level, "%pV", &vaf);
else
- dev_printk(level, kdev, "[" DRM_NAME ":%ps] %pV",
- __builtin_return_address(0), &vaf);
+ drm_err(&dev_priv->drm, "%pV", &vaf);
va_end(args);
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
@ 2021-07-28 14:39 ` jim.cromie
0 siblings, 0 replies; 4+ messages in thread
From: jim.cromie @ 2021-07-28 14:39 UTC (permalink / raw)
To: Sean Paul
Cc: David Airlie, daniel.vetter, intel-gfx, dri-devel, ppaalanen,
Sean Paul, Thomas Zimmermann
On Wed, Jul 21, 2021 at 1:55 PM Sean Paul <sean@poorly.run> wrote:
>
> From: Sean Paul <seanpaul@chromium.org>
>
> Use drm logging helpers to add support for the upcoming tracefs
> implementation.
>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-4-sean@poorly.run #v5
>
> Changes in v5:
> -Added to the set
> Changes in v6:
> -None
> ---
> drivers/gpu/drm/i915/i915_utils.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c
> index f9e780dee9de..d858c92c6997 100644
> --- a/drivers/gpu/drm/i915/i915_utils.c
> +++ b/drivers/gpu/drm/i915/i915_utils.c
> @@ -30,10 +30,9 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
> vaf.va = &args;
>
> if (is_error)
> - dev_printk(level, kdev, "%pV", &vaf);
> + drm_dev_printk(kdev, level, "%pV", &vaf);
> else
> - dev_printk(level, kdev, "[" DRM_NAME ":%ps] %pV",
> - __builtin_return_address(0), &vaf);
> + drm_err(&dev_priv->drm, "%pV", &vaf);
its slightly jarring to see drm_err() in the !is_err branch.
warn or notice seems better.
>
> va_end(args);
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] [RESEND PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog
[not found] <20210721175526.22020-1-sean@poorly.run>
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
@ 2021-07-21 17:55 ` Sean Paul
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 12/14] drm/i915: Use debug category printer for welcome message Sean Paul
2 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2021-07-21 17:55 UTC (permalink / raw)
To: dri-devel, ppaalanen, maarten.lankhorst, tzimmermann, airlied,
daniel.vetter
Cc: intel-gfx, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
Since the logs protected by these checks specifically target syslog,
use the new drm_debug_syslog_enabled() call to avoid triggering
these prints when only trace is enabled.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-10-sean@poorly.run #v5
Changes in v5:
-Added to the set
Changes in v6:
-None
---
drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 65ddb6ca16e6..048d7335196b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7494,7 +7494,7 @@ static void
intel_dump_infoframe(struct drm_i915_private *dev_priv,
const union hdmi_infoframe *frame)
{
- if (!drm_debug_enabled(DRM_UT_KMS))
+ if (!drm_debug_syslog_enabled(DRM_UT_KMS))
return;
hdmi_infoframe_log(KERN_DEBUG, dev_priv->drm.dev, frame);
@@ -8215,7 +8215,7 @@ pipe_config_infoframe_mismatch(struct drm_i915_private *dev_priv,
const union hdmi_infoframe *b)
{
if (fastset) {
- if (!drm_debug_enabled(DRM_UT_KMS))
+ if (!drm_debug_syslog_enabled(DRM_UT_KMS))
return;
drm_dbg_kms(&dev_priv->drm,
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] [RESEND PATCH v6 12/14] drm/i915: Use debug category printer for welcome message
[not found] <20210721175526.22020-1-sean@poorly.run>
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
2021-07-21 17:55 ` [Intel-gfx] [RESEND PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog Sean Paul
@ 2021-07-21 17:55 ` Sean Paul
2 siblings, 0 replies; 4+ messages in thread
From: Sean Paul @ 2021-07-21 17:55 UTC (permalink / raw)
To: dri-devel, ppaalanen, maarten.lankhorst, tzimmermann, airlied,
daniel.vetter
Cc: intel-gfx, Sean Paul
From: Sean Paul <seanpaul@chromium.org>
The welcome printer is meant to be gated on DRM_UT_DRIVER, so use the
debug category printer to avoid dumping the message in the wrong
place.
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-13-sean@poorly.run #v5
Changes in v5:
-Added to the set
Changes in v6:
-None
---
drivers/gpu/drm/i915/i915_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index c43b698bf0b9..93299af1e853 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -731,7 +731,8 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
static void i915_welcome_messages(struct drm_i915_private *dev_priv)
{
if (drm_debug_enabled(DRM_UT_DRIVER)) {
- struct drm_printer p = drm_debug_printer("i915 device info:");
+ struct drm_printer p = drm_debug_category_printer(DRM_UT_DRIVER,
+ "i915 device info:");
drm_printf(&p, "pciid=0x%04x rev=0x%02x platform=%s (subplatform=0x%x) gen=%i\n",
INTEL_DEVID(dev_priv),
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread