From: Eric Anholt <eric@anholt.net>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 3/3] drm/i915/ringbuffer: embed pipe_control into struct ring_buffer
Date: Wed, 27 Apr 2011 16:24:25 -0700 [thread overview]
Message-ID: <8739l3jn12.fsf@pollan.anholt.net> (raw)
In-Reply-To: <1303937166-1756-4-git-send-email-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 674 bytes --]
On Wed, 27 Apr 2011 22:46:06 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Pipecontrol is also required to implement gfdt flushing on gen6+.
> And if we ever switch to pipecontrol based cache management in the
> kernel, also required on gen4. I don't see the point in saving that
> little bit of storge.
>
> In the process make cleanup_pipe_control more robust and call it
> unconditionally.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Nice. I thought about this when reviewing the first, then decided I
didn't care enough. But if you've already cleaned it up, great!
these two are:
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2011-04-27 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 20:46 [PATCH 0/3] a few small cleanups in intel_ringbuffer.c Daniel Vetter
2011-04-27 20:46 ` [PATCH 1/3] drm/i915/ringbuffer: kill snb blt workaround Daniel Vetter
2011-04-28 8:42 ` Daniel Vetter
2011-04-27 20:46 ` [PATCH 2/3] drm/i915/ringbuffer: kill pipe_control->gtt_offset Daniel Vetter
2011-04-27 20:46 ` [PATCH 3/3] drm/i915/ringbuffer: embed pipe_control into struct ring_buffer Daniel Vetter
2011-04-27 23:24 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739l3jn12.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).