[Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

[Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

[Chris Wilson]

Only a couple of tests from gem_ctx_switch are run in BAT, to check we
have multiple contexts on RCS. It doesn't actually verify the switch,
just that the execbuf API accepts the context argument.

This test is redundant as actual context switching (and more) is verified by
live_gem_contexts and live_gt_contexts selftests.

Instead of using the mediocre gem_ctx_switch stress test in BAT, use
gem_exec_parallel/contexs and gem_exec_parallel/fds as both ensure
multiple contexts are supported for simultaneous use, in a fraction of
the time.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/intel-ci/fast-feedback.testlist | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 37a92b4e7..f697eb0cf 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -14,8 +14,6 @@ igt@gem_ctx_create@basic-files
 igt@gem_ctx_exec@basic
 igt@gem_ctx_param@basic
 igt@gem_ctx_param@basic-default
-igt@gem_ctx_switch@legacy-render
-igt@gem_ctx_switch@rcs0
 igt@gem_exec_basic@basic
 igt@gem_exec_create@basic
 igt@gem_exec_fence@basic-busy-default
@@ -24,6 +22,8 @@ igt@gem_exec_fence@basic-await-default
 igt@gem_exec_fence@nb-await-default
 igt@gem_exec_gttfill@basic
 igt@gem_exec_parallel@basic
+igt@gem_exec_parallel@contexts
+igt@gem_exec_parallel@fds
 igt@gem_exec_store@basic-all
 igt@gem_exec_suspend@basic
 igt@gem_exec_suspend@basic-s0
-- 
2.25.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 2/3] intel-ci: Reduce variety of gem_sync in BAT

[Chris Wilson]

Historically, we've had many problems with missed interrupt/seqno
syndrome and so have focus on testing with gem_sync. However, these
tests rely on the kernel itself reporting the issue which it no longer
does. So why the extra variety may impose different timing of execution
on the HW (and so different interrupt timings which may or may not help
uncover issues), they do not have any variety in driver coverage. Reduce
the variety (halving the associated runtime) as they are no more likely
to spot an issue than multiple runs through BAT.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/intel-ci/fast-feedback.testlist | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index f697eb0cf..8c574d910 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -45,9 +45,6 @@ igt@gem_ringfill@basic-default-forked
 igt@gem_ringfill@basic-default-fd
 igt@gem_sync@basic-all
 igt@gem_sync@basic-each
-igt@gem_sync@basic-many-each
-igt@gem_sync@basic-store-all
-igt@gem_sync@basic-store-each
 igt@gem_tiled_blits@basic
 igt@gem_tiled_fence_blits@basic
 igt@gem_tiled_pread_basic
-- 
2.25.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 2/3] intel-ci: Reduce variety of gem_sync in BAT

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Historically, we've had many problems with missed interrupt/seqno
> syndrome and so have focus on testing with gem_sync. However, these
> tests rely on the kernel itself reporting the issue which it no longer
> does. So why the extra variety may impose different timing of execution
> on the HW (and so different interrupt timings which may or may not help
> uncover issues), they do not have any variety in driver coverage. Reduce
> the variety (halving the associated runtime) as they are no more likely
> to spot an issue than multiple runs through BAT.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/intel-ci/fast-feedback.testlist | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index f697eb0cf..8c574d910 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -45,9 +45,6 @@ igt@gem_ringfill@basic-default-forked
>  igt@gem_ringfill@basic-default-fd
>  igt@gem_sync@basic-all
>  igt@gem_sync@basic-each
> -igt@gem_sync@basic-many-each
> -igt@gem_sync@basic-store-all
> -igt@gem_sync@basic-store-each
>  igt@gem_tiled_blits@basic
>  igt@gem_tiled_fence_blits@basic
>  igt@gem_tiled_pread_basic
> -- 
> 2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Use one ringfull example

[Chris Wilson]

The principle under test is that we fill the ring and the kernel waits
rather than overrun the ring buffer. We only need one test to exercise
that basic behaviour in BAT.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/intel-ci/fast-feedback.testlist | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index 8c574d910..40d273c1d 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -39,10 +39,7 @@ igt@gem_mmap@basic
 igt@gem_mmap_gtt@basic
 igt@gem_render_linear_blits@basic
 igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-default
-igt@gem_ringfill@basic-default-interruptible
 igt@gem_ringfill@basic-default-forked
-igt@gem_ringfill@basic-default-fd
 igt@gem_sync@basic-all
 igt@gem_sync@basic-each
 igt@gem_tiled_blits@basic
-- 
2.25.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Use one ringfull example

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> The principle under test is that we fill the ring and the kernel waits
> rather than overrun the ring buffer. We only need one test to exercise
> that basic behaviour in BAT.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/intel-ci/fast-feedback.testlist | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 8c574d910..40d273c1d 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -39,10 +39,7 @@ igt@gem_mmap@basic
>  igt@gem_mmap_gtt@basic
>  igt@gem_render_linear_blits@basic
>  igt@gem_render_tiled_blits@basic
> -igt@gem_ringfill@basic-default
> -igt@gem_ringfill@basic-default-interruptible
>  igt@gem_ringfill@basic-default-forked
> -igt@gem_ringfill@basic-default-fd
>  igt@gem_sync@basic-all
>  igt@gem_sync@basic-each
>  igt@gem_tiled_blits@basic
> -- 
> 2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Only a couple of tests from gem_ctx_switch are run in BAT, to check we
> have multiple contexts on RCS. It doesn't actually verify the switch,
> just that the execbuf API accepts the context argument.
>
> This test is redundant as actual context switching (and more) is verified by
> live_gem_contexts and live_gt_contexts selftests.
>
> Instead of using the mediocre gem_ctx_switch stress test in BAT, use
> gem_exec_parallel/contexs and gem_exec_parallel/fds as both ensure
s/contexs/contexts

The gem_exec_parallel seems to use new topology api to set the context.
But the aim is to check the context id delivery through rsvd field
into execbuf?

> multiple contexts are supported for simultaneous use, in a fraction of
> the time.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/intel-ci/fast-feedback.testlist | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index 37a92b4e7..f697eb0cf 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -14,8 +14,6 @@ igt@gem_ctx_create@basic-files
>  igt@gem_ctx_exec@basic
>  igt@gem_ctx_param@basic
>  igt@gem_ctx_param@basic-default
> -igt@gem_ctx_switch@legacy-render
> -igt@gem_ctx_switch@rcs0
>  igt@gem_exec_basic@basic
>  igt@gem_exec_create@basic
>  igt@gem_exec_fence@basic-busy-default
> @@ -24,6 +22,8 @@ igt@gem_exec_fence@basic-await-default
>  igt@gem_exec_fence@nb-await-default
>  igt@gem_exec_gttfill@basic
>  igt@gem_exec_parallel@basic
> +igt@gem_exec_parallel@contexts
> +igt@gem_exec_parallel@fds
>  igt@gem_exec_store@basic-all
>  igt@gem_exec_suspend@basic
>  igt@gem_exec_suspend@basic-s0
> -- 
> 2.25.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

[Chris Wilson]

Quoting Mika Kuoppala (2020-01-20 13:50:46)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > Only a couple of tests from gem_ctx_switch are run in BAT, to check we
> > have multiple contexts on RCS. It doesn't actually verify the switch,
> > just that the execbuf API accepts the context argument.
> >
> > This test is redundant as actual context switching (and more) is verified by
> > live_gem_contexts and live_gt_contexts selftests.
> >
> > Instead of using the mediocre gem_ctx_switch stress test in BAT, use
> > gem_exec_parallel/contexs and gem_exec_parallel/fds as both ensure
> s/contexs/contexts
> 
> The gem_exec_parallel seems to use new topology api to set the context.
> But the aim is to check the context id delivery through rsvd field
> into execbuf?

gem_ctx_switch was nothing more than see if we can switch without
blowing up, and spitting out a rough number for context switch latency --
mostly it was interesting wrt to signal interrupts (for
intel_ring_submission really). The tests we are _not_ using in BAT.

So as far as basic HW capability goes, we have that covered in selftests.

The question then remains, how best to quickly cover the execbuf.rsvd1
use cases. gem_exec_parallel seems to be quite good as catching edge
cases that we overlooked (i.e. has spotted bugs in pre-merging) so seemed
like the candidate to use here as well.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/3] intel-ci: Drop gem_ctx_switch from fast feedback

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2020-01-20 13:50:46)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>> 
>> > Only a couple of tests from gem_ctx_switch are run in BAT, to check we
>> > have multiple contexts on RCS. It doesn't actually verify the switch,
>> > just that the execbuf API accepts the context argument.
>> >
>> > This test is redundant as actual context switching (and more) is verified by
>> > live_gem_contexts and live_gt_contexts selftests.
>> >
>> > Instead of using the mediocre gem_ctx_switch stress test in BAT, use
>> > gem_exec_parallel/contexs and gem_exec_parallel/fds as both ensure
>> s/contexs/contexts
>> 
>> The gem_exec_parallel seems to use new topology api to set the context.
>> But the aim is to check the context id delivery through rsvd field
>> into execbuf?
>
> gem_ctx_switch was nothing more than see if we can switch without
> blowing up, and spitting out a rough number for context switch latency --
> mostly it was interesting wrt to signal interrupts (for
> intel_ring_submission really). The tests we are _not_ using in BAT.
>
> So as far as basic HW capability goes, we have that covered in selftests.
>
> The question then remains, how best to quickly cover the execbuf.rsvd1
> use cases. gem_exec_parallel seems to be quite good as catching edge
> cases that we overlooked (i.e. has spotted bugs in pre-merging) so seemed
> like the candidate to use here as well.

Ok, thanks for explanation. Yeah interruptible was there but not used
in gem_ctx_switch.

Acked-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] intel-ci: Drop gem_ctx_switch from fast feedback

[Patchwork]

== Series Details ==

Series: series starting with [1/3] intel-ci: Drop gem_ctx_switch from fast feedback
URL   : https://patchwork.freedesktop.org/series/72275/
State : failure

== Summary ==

CI Bug Log - changes from IGT_5373 -> IGTPW_3951
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_3951 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_3951, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3951:

### IGT changes ###

#### Possible regressions ####

  * igt@runner@aborted:
    - fi-byt-n2820:       NOTRUN -> [FAIL][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-byt-n2820/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in IGTPW_3951 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-bxt-dsi:         [PASS][2] -> [INCOMPLETE][3] ([fdo#103927])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-bxt-dsi/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_gem_contexts:
    - fi-hsw-peppy:       [PASS][4] -> [DMESG-FAIL][5] ([i915#722])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
    - fi-cfl-guc:         [PASS][6] -> [INCOMPLETE][7] ([fdo#106070] / [i915#424])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][8] -> [FAIL][9] ([fdo#111096] / [i915#323])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_close_race@basic-threads:
    - fi-byt-j1900:       [TIMEOUT][10] ([fdo#112271] / [i915#816]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-byt-j1900/igt@gem_close_race@basic-threads.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-byt-j1900/igt@gem_close_race@basic-threads.html

  * igt@i915_module_load@reload-with-fault-injection:
    - fi-kbl-7500u:       [INCOMPLETE][12] ([i915#879]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-kbl-7500u/igt@i915_module_load@reload-with-fault-injection.html
    - fi-skl-lmem:        [INCOMPLETE][14] ([i915#671]) -> [PASS][15]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-skl-lmem/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_selftest@live_blt:
    - fi-ivb-3770:        [DMESG-FAIL][16] ([i915#563]) -> [PASS][17]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-ivb-3770/igt@i915_selftest@live_blt.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-ivb-3770/igt@i915_selftest@live_blt.html
    - fi-hsw-4770:        [DMESG-FAIL][18] ([i915#563]) -> [PASS][19]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5373/fi-hsw-4770/igt@i915_selftest@live_blt.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/fi-hsw-4770/igt@i915_selftest@live_blt.html

  
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#106070]: https://bugs.freedesktop.org/show_bug.cgi?id=106070
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
  [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
  [i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
  [i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
  [i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
  [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722
  [i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
  [i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879


Participating hosts (49 -> 43)
------------------------------

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5373 -> IGTPW_3951

  CI-20190529: 20190529
  CI_DRM_7778: 8442e59b2b3aa0f081ee31fc13dcd0f31e5981e5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3951: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/index.html
  IGT_5373: 224e565df36693ab8ae8f58eb6ae42600c2464e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3951/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx