* [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes
@ 2021-06-30 9:52 Thomas Zimmermann
2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume Thomas Zimmermann
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Thomas Zimmermann @ 2021-06-30 9:52 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel,
chris, mika.kuoppala, matthew.brost, maarten.lankhorst,
lucas.demarchi, ville.syrjala
Cc: intel-gfx, Thomas Zimmermann, dri-devel
Fix a bug in the usage of IRQs and cleanup references to the DRM
IRQ midlayer.
Preferably this patchset would be merged through drm-misc-next.
v3:
* also use intel_synchronize_hardirq() from other callsite
v2:
* split patch
* also fix comment
* add intel_synchronize_hardirq() (Ville)
* update Fixes tag (Daniel)
Thomas Zimmermann (2):
drm/i915: Use the correct IRQ during resume
drm/i915: Drop all references to DRM IRQ midlayer
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +-
drivers/gpu/drm/i915/i915_drv.c | 1 -
drivers/gpu/drm/i915/i915_irq.c | 10 +++++-----
drivers/gpu/drm/i915/i915_irq.h | 1 +
5 files changed, 8 insertions(+), 8 deletions(-)
base-commit: 67f5a18128770817e4218a9e496d2bf5047c51e8
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume 2021-06-30 9:52 [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes Thomas Zimmermann @ 2021-06-30 9:52 ` Thomas Zimmermann 2021-06-30 10:49 ` Daniel Vetter 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann ` (3 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Thomas Zimmermann @ 2021-06-30 9:52 UTC (permalink / raw) To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel, chris, mika.kuoppala, matthew.brost, maarten.lankhorst, lucas.demarchi, ville.syrjala Cc: Daniel Vetter, intel-gfx, Thomas Zimmermann, dri-devel The code in xcs_resume() probably didn't work as intended. It uses struct drm_device.irq, which is allocated to 0, but never initialized by i915 to the device's interrupt number. v3: * also use intel_synchronize_hardirq() at another callsite v2: * wrap irq code in intel_synchronize_hardirq() (Ville) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again") Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- drivers/gpu/drm/i915/i915_irq.c | 5 +++++ drivers/gpu/drm/i915/i915_irq.h | 1 + 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 88694822716a..5ca3d1664335 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -1229,7 +1229,7 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine) return true; /* Waiting to drain ELSP? */ - synchronize_hardirq(to_pci_dev(engine->i915->drm.dev)->irq); + intel_synchronize_hardirq(engine->i915); intel_engine_flush_submission(engine); /* ELSP is empty, but there are ready requests? E.g. after reset */ diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c index 5d42a12ef3d6..1b5a22a83db6 100644 --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c @@ -185,7 +185,7 @@ static int xcs_resume(struct intel_engine_cs *engine) ring->head, ring->tail); /* Double check the ring is empty & disabled before we resume */ - synchronize_hardirq(engine->i915->drm.irq); + intel_synchronize_hardirq(engine->i915); if (!stop_ring(engine)) goto err; diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 7d0ce8b9f8ed..2203dca19895 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -4575,3 +4575,8 @@ void intel_synchronize_irq(struct drm_i915_private *i915) { synchronize_irq(to_pci_dev(i915->drm.dev)->irq); } + +void intel_synchronize_hardirq(struct drm_i915_private *i915) +{ + synchronize_hardirq(to_pci_dev(i915->drm.dev)->irq); +} diff --git a/drivers/gpu/drm/i915/i915_irq.h b/drivers/gpu/drm/i915/i915_irq.h index db34d5dbe402..e43b6734f21b 100644 --- a/drivers/gpu/drm/i915/i915_irq.h +++ b/drivers/gpu/drm/i915/i915_irq.h @@ -94,6 +94,7 @@ void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv); void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv); bool intel_irqs_enabled(struct drm_i915_private *dev_priv); void intel_synchronize_irq(struct drm_i915_private *i915); +void intel_synchronize_hardirq(struct drm_i915_private *i915); int intel_get_crtc_scanline(struct intel_crtc *crtc); void gen8_irq_power_well_post_enable(struct drm_i915_private *dev_priv, -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume Thomas Zimmermann @ 2021-06-30 10:49 ` Daniel Vetter 2021-06-30 14:18 ` Thomas Zimmermann 0 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2021-06-30 10:49 UTC (permalink / raw) To: Thomas Zimmermann Cc: airlied, intel-gfx, chris, Daniel Vetter, dri-devel, lucas.demarchi On Wed, Jun 30, 2021 at 11:52:27AM +0200, Thomas Zimmermann wrote: > The code in xcs_resume() probably didn't work as intended. It uses > struct drm_device.irq, which is allocated to 0, but never initialized > by i915 to the device's interrupt number. > > v3: > * also use intel_synchronize_hardirq() at another callsite > v2: > * wrap irq code in intel_synchronize_hardirq() (Ville) > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again") > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- > drivers/gpu/drm/i915/i915_irq.c | 5 +++++ > drivers/gpu/drm/i915/i915_irq.h | 1 + > 4 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > index 88694822716a..5ca3d1664335 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > @@ -1229,7 +1229,7 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine) > return true; > > /* Waiting to drain ELSP? */ > - synchronize_hardirq(to_pci_dev(engine->i915->drm.dev)->irq); > + intel_synchronize_hardirq(engine->i915); > intel_engine_flush_submission(engine); > > /* ELSP is empty, but there are ready requests? E.g. after reset */ > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > index 5d42a12ef3d6..1b5a22a83db6 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > @@ -185,7 +185,7 @@ static int xcs_resume(struct intel_engine_cs *engine) > ring->head, ring->tail); > > /* Double check the ring is empty & disabled before we resume */ > - synchronize_hardirq(engine->i915->drm.irq); > + intel_synchronize_hardirq(engine->i915); > if (!stop_ring(engine)) > goto err; > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 7d0ce8b9f8ed..2203dca19895 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -4575,3 +4575,8 @@ void intel_synchronize_irq(struct drm_i915_private *i915) > { > synchronize_irq(to_pci_dev(i915->drm.dev)->irq); > } > + > +void intel_synchronize_hardirq(struct drm_i915_private *i915) > +{ > + synchronize_hardirq(to_pci_dev(i915->drm.dev)->irq); I honestly think the hardirq here is about as much cargo-culted as using the wrong irq number. I'd just use intel_synchronize_irq in both places and see whether CI complains, then go with that. -Daniel > +} > diff --git a/drivers/gpu/drm/i915/i915_irq.h b/drivers/gpu/drm/i915/i915_irq.h > index db34d5dbe402..e43b6734f21b 100644 > --- a/drivers/gpu/drm/i915/i915_irq.h > +++ b/drivers/gpu/drm/i915/i915_irq.h > @@ -94,6 +94,7 @@ void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv); > void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv); > bool intel_irqs_enabled(struct drm_i915_private *dev_priv); > void intel_synchronize_irq(struct drm_i915_private *i915); > +void intel_synchronize_hardirq(struct drm_i915_private *i915); > > int intel_get_crtc_scanline(struct intel_crtc *crtc); > void gen8_irq_power_well_post_enable(struct drm_i915_private *dev_priv, > -- > 2.32.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume 2021-06-30 10:49 ` Daniel Vetter @ 2021-06-30 14:18 ` Thomas Zimmermann 2021-06-30 17:02 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Thomas Zimmermann @ 2021-06-30 14:18 UTC (permalink / raw) To: Daniel Vetter Cc: airlied, Daniel Vetter, intel-gfx, lucas.demarchi, dri-devel, chris [-- Attachment #1.1.1: Type: text/plain, Size: 4410 bytes --] Hi Am 30.06.21 um 12:49 schrieb Daniel Vetter: > On Wed, Jun 30, 2021 at 11:52:27AM +0200, Thomas Zimmermann wrote: >> The code in xcs_resume() probably didn't work as intended. It uses >> struct drm_device.irq, which is allocated to 0, but never initialized >> by i915 to the device's interrupt number. >> >> v3: >> * also use intel_synchronize_hardirq() at another callsite >> v2: >> * wrap irq code in intel_synchronize_hardirq() (Ville) >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again") >> Cc: Chris Wilson <chris@chris-wilson.co.uk> >> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Cc: Lucas De Marchi <lucas.demarchi@intel.com> >> --- >> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- >> drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- >> drivers/gpu/drm/i915/i915_irq.c | 5 +++++ >> drivers/gpu/drm/i915/i915_irq.h | 1 + >> 4 files changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> index 88694822716a..5ca3d1664335 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c >> @@ -1229,7 +1229,7 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine) >> return true; >> >> /* Waiting to drain ELSP? */ >> - synchronize_hardirq(to_pci_dev(engine->i915->drm.dev)->irq); >> + intel_synchronize_hardirq(engine->i915); >> intel_engine_flush_submission(engine); >> >> /* ELSP is empty, but there are ready requests? E.g. after reset */ >> diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c >> index 5d42a12ef3d6..1b5a22a83db6 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c >> +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c >> @@ -185,7 +185,7 @@ static int xcs_resume(struct intel_engine_cs *engine) >> ring->head, ring->tail); >> >> /* Double check the ring is empty & disabled before we resume */ >> - synchronize_hardirq(engine->i915->drm.irq); >> + intel_synchronize_hardirq(engine->i915); >> if (!stop_ring(engine)) >> goto err; >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c >> index 7d0ce8b9f8ed..2203dca19895 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -4575,3 +4575,8 @@ void intel_synchronize_irq(struct drm_i915_private *i915) >> { >> synchronize_irq(to_pci_dev(i915->drm.dev)->irq); >> } >> + >> +void intel_synchronize_hardirq(struct drm_i915_private *i915) >> +{ >> + synchronize_hardirq(to_pci_dev(i915->drm.dev)->irq); > > I honestly think the hardirq here is about as much cargo-culted as using > the wrong irq number. > > I'd just use intel_synchronize_irq in both places and see whether CI > complains, then go with that. Well, ok. I don't think I have Sandybridge HW available. Would the Intel CI infrastructure catch any problems with such a change? Best regards Thomas > -Daniel > >> +} >> diff --git a/drivers/gpu/drm/i915/i915_irq.h b/drivers/gpu/drm/i915/i915_irq.h >> index db34d5dbe402..e43b6734f21b 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.h >> +++ b/drivers/gpu/drm/i915/i915_irq.h >> @@ -94,6 +94,7 @@ void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv); >> void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv); >> bool intel_irqs_enabled(struct drm_i915_private *dev_priv); >> void intel_synchronize_irq(struct drm_i915_private *i915); >> +void intel_synchronize_hardirq(struct drm_i915_private *i915); >> >> int intel_get_crtc_scanline(struct intel_crtc *crtc); >> void gen8_irq_power_well_post_enable(struct drm_i915_private *dev_priv, >> -- >> 2.32.0 >> > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume 2021-06-30 14:18 ` Thomas Zimmermann @ 2021-06-30 17:02 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2021-06-30 17:02 UTC (permalink / raw) To: Thomas Zimmermann Cc: Dave Airlie, intel-gfx, Lucas De Marchi, dri-devel, Wilson, Chris On Wed, Jun 30, 2021 at 4:18 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > Hi > > Am 30.06.21 um 12:49 schrieb Daniel Vetter: > > On Wed, Jun 30, 2021 at 11:52:27AM +0200, Thomas Zimmermann wrote: > >> The code in xcs_resume() probably didn't work as intended. It uses > >> struct drm_device.irq, which is allocated to 0, but never initialized > >> by i915 to the device's interrupt number. > >> > >> v3: > >> * also use intel_synchronize_hardirq() at another callsite > >> v2: > >> * wrap irq code in intel_synchronize_hardirq() (Ville) > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > >> Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again") > >> Cc: Chris Wilson <chris@chris-wilson.co.uk> > >> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > >> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > >> Cc: Lucas De Marchi <lucas.demarchi@intel.com> > >> --- > >> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > >> drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +- > >> drivers/gpu/drm/i915/i915_irq.c | 5 +++++ > >> drivers/gpu/drm/i915/i915_irq.h | 1 + > >> 4 files changed, 8 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > >> index 88694822716a..5ca3d1664335 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c > >> @@ -1229,7 +1229,7 @@ bool intel_engine_is_idle(struct intel_engine_cs *engine) > >> return true; > >> > >> /* Waiting to drain ELSP? */ > >> - synchronize_hardirq(to_pci_dev(engine->i915->drm.dev)->irq); > >> + intel_synchronize_hardirq(engine->i915); > >> intel_engine_flush_submission(engine); > >> > >> /* ELSP is empty, but there are ready requests? E.g. after reset */ > >> diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > >> index 5d42a12ef3d6..1b5a22a83db6 100644 > >> --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > >> +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > >> @@ -185,7 +185,7 @@ static int xcs_resume(struct intel_engine_cs *engine) > >> ring->head, ring->tail); > >> > >> /* Double check the ring is empty & disabled before we resume */ > >> - synchronize_hardirq(engine->i915->drm.irq); > >> + intel_synchronize_hardirq(engine->i915); > >> if (!stop_ring(engine)) > >> goto err; > >> > >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > >> index 7d0ce8b9f8ed..2203dca19895 100644 > >> --- a/drivers/gpu/drm/i915/i915_irq.c > >> +++ b/drivers/gpu/drm/i915/i915_irq.c > >> @@ -4575,3 +4575,8 @@ void intel_synchronize_irq(struct drm_i915_private *i915) > >> { > >> synchronize_irq(to_pci_dev(i915->drm.dev)->irq); > >> } > >> + > >> +void intel_synchronize_hardirq(struct drm_i915_private *i915) > >> +{ > >> + synchronize_hardirq(to_pci_dev(i915->drm.dev)->irq); > > > > I honestly think the hardirq here is about as much cargo-culted as using > > the wrong irq number. > > > > I'd just use intel_synchronize_irq in both places and see whether CI > > complains, then go with that. > > Well, ok. I don't think I have Sandybridge HW available. Would the Intel > CI infrastructure catch any problems with such a change? If there's anything obvious busted with it it should catch it (like if we end up calling synchronize_irq from softirq context, where only synchronize_hardirq is allowed, but I don't think that's the case). And if I'm wrong we know what kind of comment to put there to explain why things are different. -Daniel > Best regards > Thomas > > > -Daniel > > > >> +} > >> diff --git a/drivers/gpu/drm/i915/i915_irq.h b/drivers/gpu/drm/i915/i915_irq.h > >> index db34d5dbe402..e43b6734f21b 100644 > >> --- a/drivers/gpu/drm/i915/i915_irq.h > >> +++ b/drivers/gpu/drm/i915/i915_irq.h > >> @@ -94,6 +94,7 @@ void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv); > >> void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv); > >> bool intel_irqs_enabled(struct drm_i915_private *dev_priv); > >> void intel_synchronize_irq(struct drm_i915_private *i915); > >> +void intel_synchronize_hardirq(struct drm_i915_private *i915); > >> > >> int intel_get_crtc_scanline(struct intel_crtc *crtc); > >> void gen8_irq_power_well_post_enable(struct drm_i915_private *dev_priv, > >> -- > >> 2.32.0 > >> > > > > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Maxfeldstr. 5, 90409 Nürnberg, Germany > (HRB 36809, AG Nürnberg) > Geschäftsführer: Felix Imendörffer > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer 2021-06-30 9:52 [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes Thomas Zimmermann 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume Thomas Zimmermann @ 2021-06-30 9:52 ` Thomas Zimmermann 2021-06-30 10:06 ` Greg KH 2021-06-30 16:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: IRQ fixes (rev2) Patchwork ` (2 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Thomas Zimmermann @ 2021-06-30 9:52 UTC (permalink / raw) To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel, chris, mika.kuoppala, matthew.brost, maarten.lankhorst, lucas.demarchi, ville.syrjala Cc: stable, intel-gfx, Thomas Zimmermann, dri-devel Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt functions directly. v2: * also remove an outdated comment * move IRQ fix into separate patch * update Fixes tag (Daniel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: b318b82455bd ("drm/i915: Nuke drm_driver irq vfuncs") Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: intel-gfx@lists.freedesktop.org Cc: <stable@vger.kernel.org> # v5.4+ --- drivers/gpu/drm/i915/i915_drv.c | 1 - drivers/gpu/drm/i915/i915_irq.c | 5 ----- 2 files changed, 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 850b499c71c8..73de45472f60 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -42,7 +42,6 @@ #include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_ioctl.h> -#include <drm/drm_irq.h> #include <drm/drm_managed.h> #include <drm/drm_probe_helper.h> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 2203dca19895..1d4c683c9de9 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -33,7 +33,6 @@ #include <linux/sysrq.h> #include <drm/drm_drv.h> -#include <drm/drm_irq.h> #include "display/intel_de.h" #include "display/intel_display_types.h" @@ -4564,10 +4563,6 @@ void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv) bool intel_irqs_enabled(struct drm_i915_private *dev_priv) { - /* - * We only use drm_irq_uninstall() at unload and VT switch, so - * this is the only thing we need to check. - */ return dev_priv->runtime_pm.irqs_enabled; } -- 2.32.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann @ 2021-06-30 10:06 ` Greg KH 2021-06-30 11:46 ` Thomas Zimmermann 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2021-06-30 10:06 UTC (permalink / raw) To: Thomas Zimmermann Cc: airlied, intel-gfx, chris, dri-devel, stable, lucas.demarchi On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: > Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt > functions directly. > > v2: > * also remove an outdated comment > * move IRQ fix into separate patch > * update Fixes tag (Daniel) > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: b318b82455bd ("drm/i915: Nuke drm_driver irq vfuncs") > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Cc: <stable@vger.kernel.org> # v5.4+ > --- > drivers/gpu/drm/i915/i915_drv.c | 1 - > drivers/gpu/drm/i915/i915_irq.c | 5 ----- > 2 files changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 850b499c71c8..73de45472f60 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -42,7 +42,6 @@ > #include <drm/drm_aperture.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_ioctl.h> > -#include <drm/drm_irq.h> > #include <drm/drm_managed.h> > #include <drm/drm_probe_helper.h> > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 2203dca19895..1d4c683c9de9 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -33,7 +33,6 @@ > #include <linux/sysrq.h> > > #include <drm/drm_drv.h> > -#include <drm/drm_irq.h> > > #include "display/intel_de.h" > #include "display/intel_display_types.h" > @@ -4564,10 +4563,6 @@ void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv) > > bool intel_irqs_enabled(struct drm_i915_private *dev_priv) > { > - /* > - * We only use drm_irq_uninstall() at unload and VT switch, so > - * this is the only thing we need to check. > - */ > return dev_priv->runtime_pm.irqs_enabled; > } > > -- > 2.32.0 > How is this a stable-kernel-related fix? thanks, greg k-h _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer 2021-06-30 10:06 ` Greg KH @ 2021-06-30 11:46 ` Thomas Zimmermann 0 siblings, 0 replies; 11+ messages in thread From: Thomas Zimmermann @ 2021-06-30 11:46 UTC (permalink / raw) To: Greg KH; +Cc: airlied, intel-gfx, lucas.demarchi, dri-devel, chris, stable [-- Attachment #1.1.1: Type: text/plain, Size: 2596 bytes --] Hi Am 30.06.21 um 12:06 schrieb Greg KH: > On Wed, Jun 30, 2021 at 11:52:28AM +0200, Thomas Zimmermann wrote: >> Remove all references to DRM's IRQ midlayer. i915 uses Linux' interrupt >> functions directly. >> >> v2: >> * also remove an outdated comment >> * move IRQ fix into separate patch >> * update Fixes tag (Daniel) >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> Fixes: b318b82455bd ("drm/i915: Nuke drm_driver irq vfuncs") >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Cc: Chris Wilson <chris@chris-wilson.co.uk> >> Cc: Jani Nikula <jani.nikula@linux.intel.com> >> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> >> Cc: intel-gfx@lists.freedesktop.org >> Cc: <stable@vger.kernel.org> # v5.4+ >> --- >> drivers/gpu/drm/i915/i915_drv.c | 1 - >> drivers/gpu/drm/i915/i915_irq.c | 5 ----- >> 2 files changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c >> index 850b499c71c8..73de45472f60 100644 >> --- a/drivers/gpu/drm/i915/i915_drv.c >> +++ b/drivers/gpu/drm/i915/i915_drv.c >> @@ -42,7 +42,6 @@ >> #include <drm/drm_aperture.h> >> #include <drm/drm_atomic_helper.h> >> #include <drm/drm_ioctl.h> >> -#include <drm/drm_irq.h> >> #include <drm/drm_managed.h> >> #include <drm/drm_probe_helper.h> >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c >> index 2203dca19895..1d4c683c9de9 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -33,7 +33,6 @@ >> #include <linux/sysrq.h> >> >> #include <drm/drm_drv.h> >> -#include <drm/drm_irq.h> >> >> #include "display/intel_de.h" >> #include "display/intel_display_types.h" >> @@ -4564,10 +4563,6 @@ void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv) >> >> bool intel_irqs_enabled(struct drm_i915_private *dev_priv) >> { >> - /* >> - * We only use drm_irq_uninstall() at unload and VT switch, so >> - * this is the only thing we need to check. >> - */ >> return dev_priv->runtime_pm.irqs_enabled; >> } >> >> -- >> 2.32.0 >> > > How is this a stable-kernel-related fix? Sorry, it isn't. I forgot to remove the rsp Cc tag. Best regards Thomas > > thanks, > > greg k-h > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: IRQ fixes (rev2) 2021-06-30 9:52 [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes Thomas Zimmermann 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume Thomas Zimmermann 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann @ 2021-06-30 16:41 ` Patchwork 2021-06-30 17:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-01 0:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 4 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2021-06-30 16:41 UTC (permalink / raw) To: Thomas Zimmermann; +Cc: intel-gfx == Series Details == Series: drm/i915: IRQ fixes (rev2) URL : https://patchwork.freedesktop.org/series/92053/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1896:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1896:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1896:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: IRQ fixes (rev2) 2021-06-30 9:52 [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes Thomas Zimmermann ` (2 preceding siblings ...) 2021-06-30 16:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: IRQ fixes (rev2) Patchwork @ 2021-06-30 17:06 ` Patchwork 2021-07-01 0:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 4 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2021-06-30 17:06 UTC (permalink / raw) To: Thomas Zimmermann; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 4208 bytes --] == Series Details == Series: drm/i915: IRQ fixes (rev2) URL : https://patchwork.freedesktop.org/series/92053/ State : success == Summary == CI Bug Log - changes from CI_DRM_10295 -> Patchwork_20491 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20491: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * {igt@i915_selftest@live@gem_migrate}: - {fi-dg1-1}: [PASS][1] -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-dg1-1/igt@i915_selftest@live@gem_migrate.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-dg1-1/igt@i915_selftest@live@gem_migrate.html * igt@i915_selftest@live@gt_heartbeat: - {fi-ehl-2}: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-ehl-2/igt@i915_selftest@live@gt_heartbeat.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-ehl-2/igt@i915_selftest@live@gt_heartbeat.html * igt@runner@aborted: - {fi-dg1-1}: NOTRUN -> [FAIL][5] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-dg1-1/igt@runner@aborted.html Known issues ------------ Here are the changes found in Patchwork_20491 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@requests: - fi-kbl-soraka: [PASS][6] -> [INCOMPLETE][7] ([i915#2782]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-kbl-soraka/igt@i915_selftest@live@requests.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-kbl-soraka/igt@i915_selftest@live@requests.html * igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1: - fi-bsw-kefka: [PASS][8] -> [FAIL][9] ([i915#2122]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-bsw-kefka/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html * igt@runner@aborted: - fi-bdw-5557u: NOTRUN -> [FAIL][10] ([i915#1602] / [i915#2029]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-bdw-5557u/igt@runner@aborted.html - fi-kbl-soraka: NOTRUN -> [FAIL][11] ([i915#1436] / [i915#3363]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/fi-kbl-soraka/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363 Participating hosts (39 -> 36) ------------------------------ Missing (3): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_10295 -> Patchwork_20491 CI-20190529: 20190529 CI_DRM_10295: 683b7f160eb6993ccfc19e67e3c7111f12946bea @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6124: 357d5477c93f2bdd3354afe91b89ccfd4ee4fd56 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20491: c59dbcab463129aebc932254b2d1ba366629118d @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == c59dbcab4631 drm/i915: Drop all references to DRM IRQ midlayer 2d086f7fab68 drm/i915: Use the correct IRQ during resume == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/index.html [-- Attachment #1.2: Type: text/html, Size: 4861 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: IRQ fixes (rev2) 2021-06-30 9:52 [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes Thomas Zimmermann ` (3 preceding siblings ...) 2021-06-30 17:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-07-01 0:07 ` Patchwork 4 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2021-07-01 0:07 UTC (permalink / raw) To: Thomas Zimmermann; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30249 bytes --] == Series Details == Series: drm/i915: IRQ fixes (rev2) URL : https://patchwork.freedesktop.org/series/92053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10295_full -> Patchwork_20491_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20491_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20491_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20491_full: ### IGT changes ### #### Possible regressions #### * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-skl: NOTRUN -> [FAIL][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl9/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_ctx_persistence@many-contexts: - {shard-rkl}: [PASS][2] -> [FAIL][3] +5 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-2/igt@gem_ctx_persistence@many-contexts.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-2/igt@gem_ctx_persistence@many-contexts.html * igt@i915_pm_dc@dc6-psr: - {shard-rkl}: [FAIL][4] ([i915#2951]) -> [SKIP][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@i915_pm_dc@dc6-psr.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@i915_pm_dc@dc6-psr.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip: - {shard-rkl}: NOTRUN -> [SKIP][6] +59 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_ccs: - {shard-rkl}: NOTRUN -> [FAIL][7] +14 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_ccs.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs: - {shard-rkl}: [SKIP][8] -> [FAIL][9] +6 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs.html * igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_ccs: - {shard-rkl}: [FAIL][10] -> [SKIP][11] +6 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_ccs.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_ccs.html * igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_ccs: - {shard-rkl}: [SKIP][12] ([i915#533]) -> [FAIL][13] +2 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_ccs.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_ccs.html * igt@kms_content_protection@dp-mst-type-0: - {shard-rkl}: [SKIP][14] ([i915#3116]) -> [SKIP][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_content_protection@dp-mst-type-0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_content_protection@dp-mst-type-0.html * igt@kms_content_protection@lic: - {shard-rkl}: [SKIP][16] ([fdo#109300]) -> [SKIP][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_content_protection@lic.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen: - {shard-rkl}: [SKIP][18] ([fdo#112022]) -> [SKIP][19] +27 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-1/igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen.html * igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen: - {shard-rkl}: [SKIP][20] ([i915#3359]) -> [SKIP][21] +4 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_cursor_crc@pipe-a-cursor-32x10-onscreen.html * igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled: - {shard-rkl}: [SKIP][22] ([fdo#111314]) -> [SKIP][23] +3 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - {shard-rkl}: [INCOMPLETE][24] -> [SKIP][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile: - {shard-rkl}: NOTRUN -> [INCOMPLETE][26] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt: - {shard-rkl}: [SKIP][27] ([fdo#111825]) -> [SKIP][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-2p-indfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-blt: - {shard-rkl}: [SKIP][29] ([i915#1849]) -> [SKIP][30] +100 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-blt.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-blt.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b: - {shard-rkl}: [PASS][31] -> [SKIP][32] +17 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3: - {shard-rkl}: [SKIP][33] ([i915#658]) -> [SKIP][34] +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html * igt@kms_psr@psr2_sprite_plane_move: - {shard-rkl}: [SKIP][35] ([i915#1072]) -> [SKIP][36] +9 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-5/igt@kms_psr@psr2_sprite_plane_move.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-1/igt@kms_psr@psr2_sprite_plane_move.html Known issues ------------ Here are the changes found in Patchwork_20491_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-apl: NOTRUN -> [DMESG-WARN][37] ([i915#3002]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl6/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@legacy-engines-hostile-preempt: - shard-snb: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#1099]) +3 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-snb6/igt@gem_ctx_persistence@legacy-engines-hostile-preempt.html * igt@gem_ctx_sseu@engines: - shard-tglb: NOTRUN -> [SKIP][39] ([i915#280]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@gem_ctx_sseu@engines.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][40] -> [TIMEOUT][41] ([i915#2369] / [i915#3063] / [i915#3648]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb7/igt@gem_eio@unwedge-stress.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb3/igt@gem_eio@unwedge-stress.html - shard-skl: [PASS][42] -> [TIMEOUT][43] ([i915#2369] / [i915#3063]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@gem_eio@unwedge-stress.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl8/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-deadline: - shard-kbl: [PASS][44] -> [FAIL][45] ([i915#2846]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl6/igt@gem_exec_fair@basic-deadline.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl6/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [PASS][46] -> [FAIL][47] ([i915#2842]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [PASS][48] -> [SKIP][49] ([fdo#109271]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [PASS][50] -> [FAIL][51] ([i915#2842]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_whisper@basic-queues-priority-all: - shard-iclb: [PASS][52] -> [INCOMPLETE][53] ([i915#1895]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb7/igt@gem_exec_whisper@basic-queues-priority-all.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-iclb4/igt@gem_exec_whisper@basic-queues-priority-all.html * igt@gem_mmap_gtt@cpuset-medium-copy-odd: - shard-iclb: [PASS][54] -> [FAIL][55] ([i915#307]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb4/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-iclb1/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html * igt@gem_ppgtt@flink-and-close-vma-leak: - shard-skl: [PASS][56] -> [FAIL][57] ([i915#644]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl5/igt@gem_ppgtt@flink-and-close-vma-leak.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl1/igt@gem_ppgtt@flink-and-close-vma-leak.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][58] ([i915#2658]) +1 similar issue [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl3/igt@gem_pread@exhaustion.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][59] ([i915#2658]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-snb5/igt@gem_pwrite@basic-exhaustion.html * igt@gem_userptr_blits@coherency-sync: - shard-tglb: NOTRUN -> [SKIP][60] ([fdo#110542]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@gem_userptr_blits@coherency-sync.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][61] ([i915#3318]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl7/igt@gem_userptr_blits@vma-merge.html * igt@gen9_exec_parse@allowed-single: - shard-tglb: NOTRUN -> [SKIP][62] ([fdo#112306]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@gen9_exec_parse@allowed-single.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp: - shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#1937]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html * igt@i915_selftest@live@hangcheck: - shard-snb: NOTRUN -> [INCOMPLETE][64] ([i915#2782]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [PASS][65] -> [FAIL][66] ([i915#2521]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl2/igt@kms_async_flips@alternate-sync-async-flip.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl9/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][67] ([fdo#111615]) +1 similar issue [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0: - shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271]) +293 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][69] ([i915#3689]) +3 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html * igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs: - shard-snb: NOTRUN -> [SKIP][70] ([fdo#109271]) +345 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-snb6/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html * igt@kms_chamelium@hdmi-mode-timings: - shard-kbl: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +14 similar issues [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl1/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_color@pipe-c-ctm-negative: - shard-skl: [PASS][72] -> [DMESG-WARN][73] ([i915#1982]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl3/igt@kms_color@pipe-c-ctm-negative.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl5/igt@kms_color@pipe-c-ctm-negative.html * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: - shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271] / [fdo#111827]) +15 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-b-degamma: - shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109284] / [fdo#111827]) +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_color_chamelium@pipe-b-degamma.html * igt@kms_color_chamelium@pipe-c-ctm-0-25: - shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [fdo#111827]) +26 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl6/igt@kms_color_chamelium@pipe-c-ctm-0-25.html * igt@kms_color_chamelium@pipe-c-degamma: - shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +4 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl8/igt@kms_color_chamelium@pipe-c-degamma.html * igt@kms_content_protection@legacy: - shard-kbl: NOTRUN -> [TIMEOUT][78] ([i915#1319]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl1/igt@kms_content_protection@legacy.html * igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][79] ([i915#3319]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][80] ([i915#180]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-suspend: - shard-kbl: NOTRUN -> [SKIP][81] ([fdo#109271]) +158 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-suspend.html * igt@kms_cursor_legacy@pipe-d-torture-bo: - shard-kbl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533]) +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][83] -> [DMESG-WARN][84] ([i915#180]) +6 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [PASS][85] -> [DMESG-WARN][86] ([i915#180]) +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1: - shard-skl: [PASS][87] -> [FAIL][88] ([i915#2122]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl2/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl7/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt: - shard-skl: [PASS][89] -> [FAIL][90] ([i915#2546] / [i915#49]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu: - shard-tglb: NOTRUN -> [SKIP][91] ([fdo#111825]) +3 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html * igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence: - shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#533]) +3 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl8/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#533]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-apl: NOTRUN -> [FAIL][94] ([fdo#108145] / [i915#265]) +3 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][95] ([fdo#108145] / [i915#265]) +1 similar issue [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_lowres@pipe-d-tiling-y: - shard-tglb: NOTRUN -> [SKIP][96] ([i915#3536]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_plane_lowres@pipe-d-tiling-y.html * igt@kms_plane_lowres@pipe-d-tiling-yf: - shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271]) +49 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl8/igt@kms_plane_lowres@pipe-d-tiling-yf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#658]) +6 similar issues [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#658]) +2 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][100] -> [SKIP][101] ([fdo#109441]) +2 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-iclb1/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_psr@psr2_primary_blt: - shard-tglb: NOTRUN -> [FAIL][102] ([i915#132] / [i915#3467]) [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@kms_psr@psr2_primary_blt.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][103] -> [DMESG-WARN][104] ([i915#180] / [i915#295]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_writeback@writeback-invalid-parameters: - shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2437]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl8/igt@kms_writeback@writeback-invalid-parameters.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2437]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl7/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-d-source-rg: - shard-tglb: NOTRUN -> [SKIP][107] ([i915#2530]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@nouveau_crc@pipe-d-source-rg.html * igt@prime_nv_api@i915_nv_import_vs_close: - shard-tglb: NOTRUN -> [SKIP][108] ([fdo#109291]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb7/igt@prime_nv_api@i915_nv_import_vs_close.html * igt@sysfs_clients@fair-0: - shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [i915#2994]) +3 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-apl8/igt@sysfs_clients@fair-0.html * igt@sysfs_clients@fair-3: - shard-skl: NOTRUN -> [SKIP][110] ([fdo#109271] / [i915#2994]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-skl8/igt@sysfs_clients@fair-3.html * igt@sysfs_clients@sema-10: - shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2994]) +2 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl2/igt@sysfs_clients@sema-10.html #### Possible fixes #### * igt@fbdev@eof: - {shard-rkl}: [SKIP][112] ([i915#2582]) -> [PASS][113] [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@fbdev@eof.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@fbdev@eof.html * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-kbl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +6 similar issues [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl2/igt@gem_ctx_isolation@preservation-s3@vecs0.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_ctx_persistence@many-contexts: - shard-tglb: [FAIL][116] ([i915#2410]) -> [PASS][117] [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb1/igt@gem_ctx_persistence@many-contexts.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb6/igt@gem_ctx_persistence@many-contexts.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][118] ([i915#2842]) -> [PASS][119] +2 similar issues [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-kbl: [FAIL][120] ([i915#2842]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-glk: [FAIL][122] ([i915#2842]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [SKIP][124] ([fdo#109271]) -> [PASS][125] +1 similar issue [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [SKIP][126] ([i915#2190]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-tglb6/igt@gem_huc_copy@huc-copy.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-tglb5/igt@gem_huc_copy@huc-copy.html * igt@gem_mmap_gtt@cpuset-medium-copy: - {shard-rkl}: [FAIL][128] ([i915#2428]) -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@gem_mmap_gtt@cpuset-medium-copy.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@gem_mmap_gtt@cpuset-medium-copy.html * igt@i915_pm_rpm@gem-pread: - {shard-rkl}: [SKIP][130] ([fdo#109308]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@i915_pm_rpm@gem-pread.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@i915_pm_rpm@gem-pread.html * igt@i915_suspend@debugfs-reader: - {shard-rkl}: [FAIL][132] ([fdo#103375]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-6/igt@i915_suspend@debugfs-reader.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-5/igt@i915_suspend@debugfs-reader.html * igt@kms_big_fb@x-tiled-32bpp-rotate-0: - shard-glk: [DMESG-WARN][134] ([i915#118] / [i915#95]) -> [PASS][135] +1 similar issue [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-glk8/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html * igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs: - {shard-rkl}: [FAIL][136] -> [PASS][137] +3 similar issues [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs.html * igt@kms_color@pipe-b-degamma: - {shard-rkl}: [SKIP][138] ([i915#1149]) -> [PASS][139] +1 similar issue [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@kms_color@pipe-b-degamma.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@kms_color@pipe-b-degamma.html * igt@kms_cursor_legacy@cursora-vs-flipa-toggle: - {shard-rkl}: [SKIP][140] ([fdo#111825]) -> [PASS][141] +3 similar issues [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10295/shard-rkl-1/igt@kms_cursor_legacy@cursora-vs-flipa-toggle.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/shard-rkl-6/igt@kms_cursor_legacy@cursora-vs-flipa-toggle.html * igt@kms_draw_crc@draw-method-xrgb8888-blt-xtiled: - shard-skl: [DMESG-WARN][142] ([i915#1982]) -> [PASS][143] [142]: https://intel-gfx == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20491/index.html [-- Attachment #1.2: Type: text/html, Size: 33425 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-07-01 0:07 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-30 9:52 [Intel-gfx] [PATCH v3 0/2] drm/i915: IRQ fixes Thomas Zimmermann 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Use the correct IRQ during resume Thomas Zimmermann 2021-06-30 10:49 ` Daniel Vetter 2021-06-30 14:18 ` Thomas Zimmermann 2021-06-30 17:02 ` Daniel Vetter 2021-06-30 9:52 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann 2021-06-30 10:06 ` Greg KH 2021-06-30 11:46 ` Thomas Zimmermann 2021-06-30 16:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: IRQ fixes (rev2) Patchwork 2021-06-30 17:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-01 0:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).