From: Daniel Vetter <daniel@ffwll.ch>
To: Christoph Hellwig <hch@lst.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
linux-mm@kvack.org, dri-devel@lists.freedesktop.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Intel-gfx] add remap_pfn_range_notrack instead of reinventing it in i915 v2
Date: Thu, 8 Apr 2021 12:36:21 +0200 [thread overview]
Message-ID: <YG7cpchVvBAVgew7@phenom.ffwll.local> (raw)
In-Reply-To: <20210326055505.1424432-1-hch@lst.de>
On Fri, Mar 26, 2021 at 06:55:01AM +0100, Christoph Hellwig wrote:
> Hi all,
>
> i915 has some reason to want to avoid the track_pfn_remap overhead in
> remap_pfn_range. Add a function to the core VM to do just that rather
> than reinventing the functionality poorly in the driver.
>
> Note that the remap_io_sg path does get exercises when using Xorg on my
> Thinkpad X1, so this should be considered lightly tested, I've not
> managed to hit the remap_io_mapping path at all.
>
> Changes since v1:
> - create a io_mapping_map_user wrapper instead of exporting
> remap_pfn_range_notrack
> - switch to plain remap_pfn_range for remap_sg as it does not use
> a pre-verified pgprot from an iomap
I'm burried under patches and stuff so no in-depth review. But from a
quick scan lgtm. On the series:
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I've seen it's landed already in some tree, maybe if you can add the acks
ftr?
Cheers, Daniel
>
> Diffstat:
> drivers/gpu/drm/i915/Kconfig | 1
> drivers/gpu/drm/i915/gem/i915_gem_mman.c | 9 +-
> drivers/gpu/drm/i915/i915_drv.h | 3
> drivers/gpu/drm/i915/i915_mm.c | 117 ++++++-------------------------
> include/linux/io-mapping.h | 3
> include/linux/mm.h | 2
> mm/Kconfig | 3
> mm/Makefile | 1
> mm/io-mapping.c | 29 +++++++
> mm/memory.c | 51 ++++++++-----
> 10 files changed, 97 insertions(+), 122 deletions(-)
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-08 10:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 5:55 [Intel-gfx] add remap_pfn_range_notrack instead of reinventing it in i915 v2 Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 1/4] mm: add remap_pfn_range_notrack Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 2/4] mm: add a io_mapping_map_user helper Christoph Hellwig
2021-10-20 15:40 ` Lucas De Marchi
2021-10-20 19:37 ` Peter Zijlstra
2021-10-21 6:18 ` Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 3/4] i915: use io_mapping_map_user Christoph Hellwig
2021-03-26 5:55 ` [Intel-gfx] [PATCH 4/4] i915: fix remap_io_sg to verify the pgprot Christoph Hellwig
2021-05-08 19:33 ` youling257
2021-05-10 8:58 ` Christoph Hellwig
2021-05-16 16:06 ` Serge Belyshev
2021-05-17 12:37 ` Christoph Hellwig
2021-05-17 13:09 ` Serge Belyshev
2021-05-17 13:11 ` Christoph Hellwig
2021-05-17 17:06 ` Matthew Auld
2021-05-18 13:21 ` Christoph Hellwig
2021-05-18 15:00 ` Matthew Auld
2021-05-19 5:46 ` Thomas Hellström (Intel)
2021-05-17 21:46 ` Thomas Hellström
2021-05-18 6:46 ` Thomas Hellström
2021-05-18 13:24 ` Christoph Hellwig
2021-05-18 13:33 ` Thomas Hellström
2021-05-18 13:23 ` Christoph Hellwig
2021-05-19 5:51 ` Thomas Hellström
2021-03-26 7:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] mm: add remap_pfn_range_notrack Patchwork
2021-03-26 7:31 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-26 7:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-03-26 7:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-04-08 10:36 ` Daniel Vetter [this message]
2021-04-08 11:28 ` [Intel-gfx] add remap_pfn_range_notrack instead of reinventing it in i915 v2 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG7cpchVvBAVgew7@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).