* [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control @ 2022-06-28 10:43 Anatolii Gerasymenko 2022-06-28 10:49 ` [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) Paul Menzel 2022-06-28 20:36 ` [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Zvi Effron 0 siblings, 2 replies; 6+ messages in thread From: Anatolii Gerasymenko @ 2022-06-28 10:43 UTC (permalink / raw) To: intel-wired-lan; +Cc: Anatolii Gerasymenko Implement possibility to change FCS/CRC stripping feature using ethtool command. Having FCS/CRC could be useful for: - network sniffers to inspect FCS/CRC correctness - for benchmarking use cases - XDP programs Anatolii Gerasymenko (1): ice: Implement FCS/CRC and VLAN stripping co-existence policy Jesse Brandeburg (1): ice: Implement control of FCS/CRC stripping drivers/net/ethernet/intel/ice/ice.h | 1 + drivers/net/ethernet/intel/ice/ice_base.c | 2 +- drivers/net/ethernet/intel/ice/ice_ethtool.c | 5 +- drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++ drivers/net/ethernet/intel/ice/ice_lib.h | 2 + drivers/net/ethernet/intel/ice/ice_main.c | 73 ++++++++++++++++++-- drivers/net/ethernet/intel/ice/ice_txrx.h | 3 +- 7 files changed, 96 insertions(+), 11 deletions(-) -- 2.25.1 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) 2022-06-28 10:43 [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Anatolii Gerasymenko @ 2022-06-28 10:49 ` Paul Menzel 2022-06-30 6:22 ` Anatolii Gerasymenko 2022-06-28 20:36 ` [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Zvi Effron 1 sibling, 1 reply; 6+ messages in thread From: Paul Menzel @ 2022-06-28 10:49 UTC (permalink / raw) To: Anatolii Gerasymenko; +Cc: intel-wired-lan, Jesse Brandeburg Dear Anatolii, Thank you for the patches. Am 28.06.22 um 12:43 schrieb Anatolii Gerasymenko: > Implement possibility to change FCS/CRC stripping feature using > ethtool command. > > Having FCS/CRC could be useful for: > - network sniffers to inspect FCS/CRC correctness > - for benchmarking use cases > - XDP programs > > Anatolii Gerasymenko (1): > ice: Implement FCS/CRC and VLAN stripping co-existence policy > > Jesse Brandeburg (1): > ice: Implement control of FCS/CRC stripping […] For some reason the two patches are not threaded below the cover letter although you use git-send-email: X-Mailer: git-send-email 2.25.1 Can you please check you setup? Kind regards, Paul _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) 2022-06-28 10:49 ` [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) Paul Menzel @ 2022-06-30 6:22 ` Anatolii Gerasymenko 0 siblings, 0 replies; 6+ messages in thread From: Anatolii Gerasymenko @ 2022-06-30 6:22 UTC (permalink / raw) To: Paul Menzel; +Cc: intel-wired-lan, Jesse Brandeburg On 28.06.2022 12:49, Paul Menzel wrote: > Dear Anatolii, > > > Thank you for the patches. > > Am 28.06.22 um 12:43 schrieb Anatolii Gerasymenko: >> Implement possibility to change FCS/CRC stripping feature using >> ethtool command. >> >> Having FCS/CRC could be useful for: >> - network sniffers to inspect FCS/CRC correctness >> - for benchmarking use cases >> - XDP programs >> >> Anatolii Gerasymenko (1): >> ice: Implement FCS/CRC and VLAN stripping co-existence policy >> >> Jesse Brandeburg (1): >> ice: Implement control of FCS/CRC stripping > > […] > > For some reason the two patches are not threaded below the cover letter although you use git-send-email: > > X-Mailer: git-send-email 2.25.1 > > Can you please check you setup? > Yes, that is strange. I will check. Thank you, Paul. > > Kind regards, > > Paul _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control 2022-06-28 10:43 [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Anatolii Gerasymenko 2022-06-28 10:49 ` [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) Paul Menzel @ 2022-06-28 20:36 ` Zvi Effron 2022-06-30 6:26 ` Anatolii Gerasymenko 1 sibling, 1 reply; 6+ messages in thread From: Zvi Effron @ 2022-06-28 20:36 UTC (permalink / raw) To: Anatolii Gerasymenko; +Cc: intel-wired-lan, Jesper Dangaard Brouer On Tue, Jun 28, 2022 at 3:45 AM Anatolii Gerasymenko <anatolii.gerasymenko@intel.com> wrote: > > Implement possibility to change FCS/CRC stripping feature using > ethtool command. > > Having FCS/CRC could be useful for: > - network sniffers to inspect FCS/CRC correctness > - for benchmarking use cases > - XDP programs > Have you thought of exposing this through the XDP hints paradigm that Jesper is working on? That could make it available to XDP programs that want it without breaking those that assume they won't have it, allowing both programs to coexist on the same machine? > Anatolii Gerasymenko (1): > ice: Implement FCS/CRC and VLAN stripping co-existence policy > > Jesse Brandeburg (1): > ice: Implement control of FCS/CRC stripping > > drivers/net/ethernet/intel/ice/ice.h | 1 + > drivers/net/ethernet/intel/ice/ice_base.c | 2 +- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 5 +- > drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++ > drivers/net/ethernet/intel/ice/ice_lib.h | 2 + > drivers/net/ethernet/intel/ice/ice_main.c | 73 ++++++++++++++++++-- > drivers/net/ethernet/intel/ice/ice_txrx.h | 3 +- > 7 files changed, 96 insertions(+), 11 deletions(-) > > -- > 2.25.1 > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control 2022-06-28 20:36 ` [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Zvi Effron @ 2022-06-30 6:26 ` Anatolii Gerasymenko 2022-07-20 5:23 ` Mekala, SunithaX D 0 siblings, 1 reply; 6+ messages in thread From: Anatolii Gerasymenko @ 2022-06-30 6:26 UTC (permalink / raw) To: Zvi Effron; +Cc: intel-wired-lan, Jesper Dangaard Brouer On 28.06.2022 22:36, Zvi Effron wrote: > On Tue, Jun 28, 2022 at 3:45 AM Anatolii Gerasymenko > <anatolii.gerasymenko@intel.com> wrote: >> >> Implement possibility to change FCS/CRC stripping feature using >> ethtool command. >> >> Having FCS/CRC could be useful for: >> - network sniffers to inspect FCS/CRC correctness >> - for benchmarking use cases >> - XDP programs >> > > Have you thought of exposing this through the XDP hints paradigm that Jesper > is working on? That could make it available to XDP programs that want it > without breaking those that assume they won't have it, allowing both programs > to coexist on the same machine? > No, this hasn't been considered, thank you for the idea. > >> Anatolii Gerasymenko (1): >> ice: Implement FCS/CRC and VLAN stripping co-existence policy >> >> Jesse Brandeburg (1): >> ice: Implement control of FCS/CRC stripping >> >> drivers/net/ethernet/intel/ice/ice.h | 1 + >> drivers/net/ethernet/intel/ice/ice_base.c | 2 +- >> drivers/net/ethernet/intel/ice/ice_ethtool.c | 5 +- >> drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++ >> drivers/net/ethernet/intel/ice/ice_lib.h | 2 + >> drivers/net/ethernet/intel/ice/ice_main.c | 73 ++++++++++++++++++-- >> drivers/net/ethernet/intel/ice/ice_txrx.h | 3 +- >> 7 files changed, 96 insertions(+), 11 deletions(-) >> >> -- >> 2.25.1 >> >> _______________________________________________ >> Intel-wired-lan mailing list >> Intel-wired-lan@osuosl.org >> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control 2022-06-30 6:26 ` Anatolii Gerasymenko @ 2022-07-20 5:23 ` Mekala, SunithaX D 0 siblings, 0 replies; 6+ messages in thread From: Mekala, SunithaX D @ 2022-07-20 5:23 UTC (permalink / raw) To: Gerasymenko, Anatolii, Effron, Zvi; +Cc: intel-wired-lan, Brouer, Jesper > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Anatolii Gerasymenko > Sent: Wednesday, June 29, 2022 11:27 PM > To: Effron, Zvi <zeffron@riotgames.com> > Cc: intel-wired-lan@lists.osuosl.org; Brouer, Jesper <brouer@redhat.com> > Subject: Re: [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control > > On 28.06.2022 22:36, Zvi Effron wrote: > On Tue, Jun 28, 2022 at 3:45 AM Anatolii Gerasymenko > <anatolii.gerasymenko@intel.com> wrote: >> >> Implement possibility to change FCS/CRC stripping feature using >> ethtool command. >> >> Having FCS/CRC could be useful for: >> - network sniffers to inspect FCS/CRC correctness >> - for benchmarking use cases >> - XDP programs >> > > Have you thought of exposing this through the XDP hints paradigm that > Jesper is working on? That could make it available to XDP programs > that want it without breaking those that assume they won't have it, > allowing both programs to coexist on the same machine? > > > No, this hasn't been considered, thank you for the idea. > > >> Anatolii Gerasymenko (1): >> ice: Implement FCS/CRC and VLAN stripping co-existence policy >> >> Jesse Brandeburg (1): >> ice: Implement control of FCS/CRC stripping >> >> drivers/net/ethernet/intel/ice/ice.h | 1 + >> drivers/net/ethernet/intel/ice/ice_base.c | 2 +- >> drivers/net/ethernet/intel/ice/ice_ethtool.c | 5 +- >> drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++ >> drivers/net/ethernet/intel/ice/ice_lib.h | 2 + >> drivers/net/ethernet/intel/ice/ice_main.c | 73 ++++++++++++++++++-- >> drivers/net/ethernet/intel/ice/ice_txrx.h | 3 +- >> 7 files changed, 96 insertions(+), 11 deletions(-) > Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel) _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-20 5:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-06-28 10:43 [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Anatolii Gerasymenko 2022-06-28 10:49 ` [Intel-wired-lan] Patches not threaded below the cover letter (was: [PATCH net-next 0/2] ice: FCS/CRC stripping control) Paul Menzel 2022-06-30 6:22 ` Anatolii Gerasymenko 2022-06-28 20:36 ` [Intel-wired-lan] [PATCH net-next 0/2] ice: FCS/CRC stripping control Zvi Effron 2022-06-30 6:26 ` Anatolii Gerasymenko 2022-07-20 5:23 ` Mekala, SunithaX D
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).