intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Anusha Srivatsa <anusha.srivatsa@intel.com>,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-xe] [PATCH 1/3] drm/xe: Remove unused revid from firmware name
Date: Fri, 31 Mar 2023 14:35:29 -0700	[thread overview]
Message-ID: <20230331213529.p4th6rtasyj7s2wq@ldmartin-desk2.lan> (raw)
In-Reply-To: <20230327165955.GI4085390@mdroper-desk1.amr.corp.intel.com>

On Mon, Mar 27, 2023 at 09:59:55AM -0700, Matt Roper wrote:
>On Thu, Mar 23, 2023 at 10:17:52PM -0700, Lucas De Marchi wrote:
>> The rev field is always 0 so it ends up never used. In i915 it was
>> introduced because of CML: up to rev 5 it reuses the guc and huc
>> firmware blobs from KBL. After that there is a specific firmware for
>> that platform.  This can be reintroduced later if ever needed.
>
>I doubt we'd ever need the revid again; more likely we'd want a way to
>select different firmwares for a given subplatform (which is something I
>think we need to add anyway for ADL-N).
>
>Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

thanks, applied this first patch.

Lucas De Marchi

  reply	other threads:[~2023-03-31 21:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  5:17 [Intel-xe] [PATCH 0/3] drm/xe: Update GuC/HuC firmware autoselection Lucas De Marchi
2023-03-24  5:17 ` [Intel-xe] [PATCH 1/3] drm/xe: Remove unused revid from firmware name Lucas De Marchi
2023-03-27 16:59   ` Matt Roper
2023-03-31 21:35     ` Lucas De Marchi [this message]
2023-03-24  5:17 ` [Intel-xe] [PATCH 2/3] drm/xe: Fix platform order Lucas De Marchi
2023-03-27 17:02   ` Matt Roper
2023-03-31 13:22     ` Lucas De Marchi
2023-03-31 20:47       ` Matt Roper
2023-03-31 21:13         ` Lucas De Marchi
2023-03-24  5:17 ` [Intel-xe] [PATCH 3/3] drm/xe: Update GuC/HuC firmware autoselect logic Lucas De Marchi
2023-03-28 23:31   ` Srivatsa, Anusha
2023-03-30  3:46     ` Lucas De Marchi
2023-04-03 18:09       ` Srivatsa, Anusha
2023-04-04 18:59         ` Lucas De Marchi
2023-03-24  5:27 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: Update GuC/HuC firmware autoselection Patchwork
2023-03-24  5:28 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-03-24  5:32 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-03-24  5:54 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230331213529.p4th6rtasyj7s2wq@ldmartin-desk2.lan \
    --to=lucas.demarchi@intel.com \
    --cc=airlied@redhat.com \
    --cc=anusha.srivatsa@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).