From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
io-uring <io-uring@vger.kernel.org>
Subject: Re: io_close()
Date: Fri, 7 Feb 2020 14:14:22 -0700 [thread overview]
Message-ID: <6052650b-4deb-4a4c-8efb-a85e4781cce2@kernel.dk> (raw)
In-Reply-To: <45f22c50-1ffe-4b73-f213-08dd49233597@gmail.com>
On 2/7/20 1:52 PM, Pavel Begunkov wrote:
> Hi,
>
> I noticed, that io_close() is broken for some use cases, and was thinking about
> the best way to fix it. Is fput(req->close.put_file) really need to be done in
> wq? It seems, fput_many() implementation just calls schedule_delayed_work(), so
> it's already delayed.
It's not the fput(), it's the f_op->flush().
--
Jens Axboe
next prev parent reply other threads:[~2020-02-07 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 20:52 io_close() Pavel Begunkov
2020-02-07 21:14 ` Jens Axboe [this message]
2020-02-07 21:19 ` io_close() Pavel Begunkov
2020-02-07 21:35 ` io_close() Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6052650b-4deb-4a4c-8efb-a85e4781cce2@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).