IO-Uring Archive on lore.kernel.org
 help / color / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Stefan Metzmacher <metze@samba.org>, io-uring@vger.kernel.org
Subject: Re: [PATCH v1] io_uring_cqe_get_data() only requires a const struct io_uring_cqe *cqe
Date: Thu, 6 Feb 2020 09:04:15 -0700
Message-ID: <94d5b40d-a5d8-706f-ab5c-3a8bd512d831@kernel.dk> (raw)
In-Reply-To: <20200206160209.14432-1-metze@samba.org>

On 2/6/20 9:02 AM, Stefan Metzmacher wrote:
> Signed-off-by: Stefan Metzmacher <metze@samba.org>
> ---
>  src/include/liburing.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/include/liburing.h b/src/include/liburing.h
> index faed2e7..44f18fd 100644
> --- a/src/include/liburing.h
> +++ b/src/include/liburing.h
> @@ -179,7 +179,7 @@ static inline void io_uring_sqe_set_data(struct io_uring_sqe *sqe, void *data)
>  	sqe->user_data = (unsigned long) data;
>  }
>  
> -static inline void *io_uring_cqe_get_data(struct io_uring_cqe *cqe)
> +static inline void *io_uring_cqe_get_data(const struct io_uring_cqe *cqe)
>  {
>  	return (void *) (uintptr_t) cqe->user_data;
>  }

Applied, thanks.

Unrelated to this patch, but I'd like to release a 0.4 sooner rather
than later. Let me know if you see any immediate work that needs doing
before that happens.

-- 
Jens Axboe


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 16:02 Stefan Metzmacher
2020-02-06 16:04 ` Jens Axboe [this message]
2020-02-06 16:37   ` Stefan Metzmacher
2020-02-06 16:42     ` Jens Axboe
2020-02-06 17:05       ` Stefan Metzmacher
2020-02-06 19:13         ` Jens Axboe
2020-02-07 23:45   ` Stefan Metzmacher
2020-02-08 19:53     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94d5b40d-a5d8-706f-ab5c-3a8bd512d831@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=metze@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/io-uring/0 io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ https://lore.kernel.org/io-uring \
		io-uring@vger.kernel.org
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.io-uring


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git