IO-Uring Archive on
 help / color / Atom feed
From: Stefan Metzmacher <>
To: Jens Axboe <>,
Subject: Re: [PATCH v1] io_uring_cqe_get_data() only requires a const struct io_uring_cqe *cqe
Date: Thu, 6 Feb 2020 17:37:41 +0100
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1.1: Type: text/plain, Size: 2481 bytes --]

Am 06.02.20 um 17:04 schrieb Jens Axboe:
> On 2/6/20 9:02 AM, Stefan Metzmacher wrote:
>> Signed-off-by: Stefan Metzmacher <>
>> ---
>>  src/include/liburing.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/src/include/liburing.h b/src/include/liburing.h
>> index faed2e7..44f18fd 100644
>> --- a/src/include/liburing.h
>> +++ b/src/include/liburing.h
>> @@ -179,7 +179,7 @@ static inline void io_uring_sqe_set_data(struct io_uring_sqe *sqe, void *data)
>>  	sqe->user_data = (unsigned long) data;
>>  }
>> -static inline void *io_uring_cqe_get_data(struct io_uring_cqe *cqe)
>> +static inline void *io_uring_cqe_get_data(const struct io_uring_cqe *cqe)
>>  {
>>  	return (void *) (uintptr_t) cqe->user_data;
>>  }
> Applied, thanks.


> Unrelated to this patch, but I'd like to release a 0.4 sooner rather
> than later.

Funny, I thought about that today:-)
I prepared debian packaging for liburing-0.4 I'll send the patches soon.

While doing that I found the following incompatible change against

 static inline void io_uring_prep_files_update(struct io_uring_sqe *sqe,
-                                             int *fds, unsigned nr_fds)
+                                             int *fds, unsigned nr_fds,
+                                             int offset)

I'm not sure if we should do something about that.

It's also strange that in src/ LIBURING_0.3 doesn't
inherit LIBURING_0.2. There's not a single symbol with @LIBURING_0.3.
Also io_uring_{setup,enter,register} are still
listed under LIBURING_0.1, but they're not in the library anymore.

> Let me know if you see any immediate work that needs doing
> before that happens.

I had the idea to have a simple version of fd compounding.
We already have IORING_OP_FILES_UPDATE in order to update
specific indexes in the files array.
I'm wondering if we could have specify an index where
could store the generated fd into the fixed array.
The index 0 is not valid, correct? So we can have it
without a flag similar to the personality, and for
all of these buf_index is not used.

While researching that I noticed that IOSQE_FIXED_FILE
seems to be ignored for some new commands, I think that
all commands with on input fd, should be able to use that flag.
Can this be fixed before 5.6 final?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 16:02 Stefan Metzmacher
2020-02-06 16:04 ` Jens Axboe
2020-02-06 16:37   ` Stefan Metzmacher [this message]
2020-02-06 16:42     ` Jens Axboe
2020-02-06 17:05       ` Stefan Metzmacher
2020-02-06 19:13         ` Jens Axboe
2020-02-07 23:45   ` Stefan Metzmacher
2020-02-08 19:53     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

IO-Uring Archive on

Archives are clonable:
	git clone --mirror io-uring/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 io-uring io-uring/ \
	public-inbox-index io-uring

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone