[PATCH 1/2] client: fix spurious newlines in station show

[PATCH 1/2] client: fix spurious newlines in station show

[eNV25]

This change removes duplicated calls to display_table_footer(), in
station show.

Before this change, the bug caused an extra newline to be output every
time the table updated. This only occurred when the network was
disconnected.

    $ iwctl
    [iwd]# station wlan0 show

---
 client/station.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/client/station.c b/client/station.c
index b070807b..1d958ef2 100644
--- a/client/station.c
+++ b/client/station.c
@@ -217,15 +217,9 @@ static void display_station(const char *device_name,
 			47, network_get_name(station->connected_network));
 
 		display_addresses(device_name);
-
-		/*
-		 * If connected the diagnostic interface is presumably up so
-		 * don't add the table footer just yet.
-		 */
-		return;
 	}
 
-	display_table_footer();
+	/* The table footer is handled by cmd_show. */
 }
 
 static void display_station_inline(const char *margin, const void *data)
-- 
2.38.1

[PATCH 2/2] gitignore: add .cache

[eNV25]

This directory is used by clangd.

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index cde22889..61b3638d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,6 +4,7 @@
 .libs
 .deps
 .dirstamp
+.cache
 tags
 cscope.*
 Makefile
-- 
2.38.1

Re: [PATCH 1/2] client: fix spurious newlines in station show

[James Prestwood]

On Wed, 2022-11-02 at 14:51 +0530, eNV25 wrote:
> This change removes duplicated calls to display_table_footer(), in
> station show.
> 
> Before this change, the bug caused an extra newline to be output
> every
> time the table updated. This only occurred when the network was
> disconnected.
> 
>     $ iwctl
>     [iwd]# station wlan0 show
> 
> ---
>  client/station.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/client/station.c b/client/station.c
> index b070807b..1d958ef2 100644
> --- a/client/station.c
> +++ b/client/station.c
> @@ -217,15 +217,9 @@ static void display_station(const char
> *device_name,
>                         47, network_get_name(station-
> >connected_network));
>  
>                 display_addresses(device_name);
> -
> -               /*
> -                * If connected the diagnostic interface is
> presumably up so
> -                * don't add the table footer just yet.
> -                */
> -               return;
>         }
>  
> -       display_table_footer();
> +       /* The table footer is handled by cmd_show. */
>  }
>  
>  static void display_station_inline(const char *margin, const void
> *data)

LGTM, I noticed this happening but never spent the time to diagnose it.
Thanks!

Re: [PATCH 1/2] client: fix spurious newlines in station show

[Denis Kenzior]

Hi,

On 11/2/22 04:21, eNV25 wrote:
> This change removes duplicated calls to display_table_footer(), in
> station show.
> 
> Before this change, the bug caused an extra newline to be output every
> time the table updated. This only occurred when the network was
> disconnected.
> 
>      $ iwctl
>      [iwd]# station wlan0 show
> 
> ---
>   client/station.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 


Can I get a proper full name please?  I can't take this into the repo otherwise.

Regards,
-Denis

Re: [PATCH 1/2] client: fix spurious newlines in station show

[eNV25]

On Thu, Nov 3, 2022 at 1:29 AM Denis Kenzior <denkenz@gmail.com> wrote:
> Can I get a proper full name please?  I can't take this into the repo otherwise.

My name is Neehar Vijay.

Do I need to send a v2 patch with the name?

> Regards,
> -Denis