[patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()

[patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()

[Dan Carpenter]

"data" is always NULL in this function.  I think we should be passing
"&data" to sst_prepare_and_post_msg() instead of "data".

Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Not tested.

diff --git a/sound/soc/intel/atom/sst/sst_stream.c b/sound/soc/intel/atom/sst/sst_stream.c
index a74c64c..4ccc80e 100644
--- a/sound/soc/intel/atom/sst/sst_stream.c
+++ b/sound/soc/intel/atom/sst/sst_stream.c
@@ -108,7 +108,7 @@ int sst_alloc_stream_mrfld(struct intel_sst_drv *sst_drv_ctx, void *params)
 			str_id, pipe_id);
 	ret = sst_prepare_and_post_msg(sst_drv_ctx, task_id, IPC_CMD,
 			IPC_IA_ALLOC_STREAM_MRFLD, pipe_id, sizeof(alloc_param),
-			&alloc_param, data, true, true, false, true);
+			&alloc_param, &data, true, true, false, true);
 
 	if (ret < 0) {
 		dev_err(sst_drv_ctx->dev, "FW alloc failed ret %d\n", ret);

Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()

[Vinod Koul]

On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote:
> "data" is always NULL in this function.  I think we should be passing
> "&data" to sst_prepare_and_post_msg() instead of "data".
> 
> Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.

This looks right to me but this should have resulted in broken stuff, I will
test this tomorrow and get back

-- 
~Vinod

Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()

[Vinod Koul]

On Wed, Nov 18, 2015 at 11:52:49PM +0530, Vinod Koul wrote:
> On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote:
> > "data" is always NULL in this function.  I think we should be passing
> > "&data" to sst_prepare_and_post_msg() instead of "data".
> > 
> > Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Not tested.
> 
> This looks right to me but this should have resulted in broken stuff, I will
> test this tomorrow and get back

we tested and looks right, so

Tested-by: Dinesh Mirche <dinesh.mirche@intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>

-- 
~Vinod