* [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()
@ 2015-11-18 10:04 Dan Carpenter
2015-11-18 18:34 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2015-11-18 10:04 UTC (permalink / raw)
To: Liam Girdwood, Vinod Koul
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Jie Yang,
Jarkko Nikula, alsa-devel, kernel-janitors
"data" is always NULL in this function. I think we should be passing
"&data" to sst_prepare_and_post_msg() instead of "data".
Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Not tested.
diff --git a/sound/soc/intel/atom/sst/sst_stream.c b/sound/soc/intel/atom/sst/sst_stream.c
index a74c64c..4ccc80e 100644
--- a/sound/soc/intel/atom/sst/sst_stream.c
+++ b/sound/soc/intel/atom/sst/sst_stream.c
@@ -108,7 +108,7 @@ int sst_alloc_stream_mrfld(struct intel_sst_drv *sst_drv_ctx, void *params)
str_id, pipe_id);
ret = sst_prepare_and_post_msg(sst_drv_ctx, task_id, IPC_CMD,
IPC_IA_ALLOC_STREAM_MRFLD, pipe_id, sizeof(alloc_param),
- &alloc_param, data, true, true, false, true);
+ &alloc_param, &data, true, true, false, true);
if (ret < 0) {
dev_err(sst_drv_ctx->dev, "FW alloc failed ret %d\n", ret);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()
2015-11-18 10:04 [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld() Dan Carpenter
@ 2015-11-18 18:34 ` Vinod Koul
2015-11-19 10:47 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2015-11-18 18:34 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Jie Yang, Jarkko Nikula, alsa-devel, kernel-janitors
On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote:
> "data" is always NULL in this function. I think we should be passing
> "&data" to sst_prepare_and_post_msg() instead of "data".
>
> Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
This looks right to me but this should have resulted in broken stuff, I will
test this tomorrow and get back
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld()
2015-11-18 18:34 ` Vinod Koul
@ 2015-11-19 10:47 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2015-11-19 10:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Jie Yang, Jarkko Nikula, alsa-devel, kernel-janitors, Mirche,
Dinesh
On Wed, Nov 18, 2015 at 11:52:49PM +0530, Vinod Koul wrote:
> On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote:
> > "data" is always NULL in this function. I think we should be passing
> > "&data" to sst_prepare_and_post_msg() instead of "data".
> >
> > Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Not tested.
>
> This looks right to me but this should have resulted in broken stuff, I will
> test this tomorrow and get back
we tested and looks right, so
Tested-by: Dinesh Mirche <dinesh.mirche@intel.com>
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-19 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-18 10:04 [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld() Dan Carpenter
2015-11-18 18:34 ` Vinod Koul
2015-11-19 10:47 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).