* [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz
@ 2020-05-07 15:16 Colin King
2020-05-07 18:24 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Colin King @ 2020-05-07 15:16 UTC (permalink / raw)
To: Leon Romanovsky, Doug Ledford, Jason Gunthorpe, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable rcqe_sz is being unnecessarily assigned twice, fix this
by removing one of the duplicates.
Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/mlx5/qp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index e5891d3da945..0d292d93f5e7 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2043,8 +2043,7 @@ static int create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd,
if ((qp->flags_en & MLX5_QP_FLAG_SCATTER_CQE) &&
(init_attr->qp_type = IB_QPT_RC ||
init_attr->qp_type = IB_QPT_UC)) {
- int rcqe_sz = rcqe_sz - mlx5_ib_get_cqe_size(init_attr->recv_cq);
+ int rcqe_sz = mlx5_ib_get_cqe_size(init_attr->recv_cq);
MLX5_SET(qpc, qpc, cs_res,
rcqe_sz = 128 ? MLX5_RES_SCAT_DATA64_CQE :
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz
2020-05-07 15:16 [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Colin King
@ 2020-05-07 18:24 ` Leon Romanovsky
2020-05-08 0:04 ` Jason Gunthorpe
2020-06-04 14:39 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length Colin King
2 siblings, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2020-05-07 18:24 UTC (permalink / raw)
To: Colin King
Cc: Doug Ledford, Jason Gunthorpe, linux-rdma, kernel-janitors, linux-kernel
On Thu, May 07, 2020 at 04:16:10PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable rcqe_sz is being unnecessarily assigned twice, fix this
> by removing one of the duplicates.
>
> Addresses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Fixes: 8bde2c509e40 ("RDMA/mlx5: Update all DRIVER QP places to use QP subtype")
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz
2020-05-07 15:16 [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Colin King
2020-05-07 18:24 ` Leon Romanovsky
@ 2020-05-08 0:04 ` Jason Gunthorpe
2020-06-04 14:39 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length Colin King
2 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2020-05-08 0:04 UTC (permalink / raw)
To: Colin King
Cc: Leon Romanovsky, Doug Ledford, linux-rdma, kernel-janitors, linux-kernel
On Thu, May 07, 2020 at 04:16:10PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable rcqe_sz is being unnecessarily assigned twice, fix this
> by removing one of the duplicates.
>
> Addresses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length
2020-05-07 15:16 [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Colin King
2020-05-07 18:24 ` Leon Romanovsky
2020-05-08 0:04 ` Jason Gunthorpe
@ 2020-06-04 14:39 ` Colin King
2020-06-07 6:40 ` Leon Romanovsky
2020-06-15 18:39 ` Jason Gunthorpe
2 siblings, 2 replies; 6+ messages in thread
From: Colin King @ 2020-06-04 14:39 UTC (permalink / raw)
To: Leon Romanovsky, Doug Ledford, Jason Gunthorpe, linux-rdma
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment to resp.response_length is never read since it is being
updated again on the next statement. The assignment is redundant so
removed it.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/mlx5/qp.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 81bf6b975e0e..d61ca85033de 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -4162,8 +4162,6 @@ static int mlx5_ib_modify_dct(struct ib_qp *ibqp, struct ib_qp_attr *attr,
if (udata->outlen < min_resp_len)
return -EINVAL;
- resp.response_length = min_resp_len;
-
/*
* If we don't have enough space for the ECE options,
* simply indicate it with resp.response_length.
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length
2020-06-04 14:39 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length Colin King
@ 2020-06-07 6:40 ` Leon Romanovsky
2020-06-15 18:39 ` Jason Gunthorpe
1 sibling, 0 replies; 6+ messages in thread
From: Leon Romanovsky @ 2020-06-07 6:40 UTC (permalink / raw)
To: Colin King
Cc: Doug Ledford, Jason Gunthorpe, linux-rdma, kernel-janitors, linux-kernel
On Thu, Jun 04, 2020 at 03:39:02PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment to resp.response_length is never read since it is being
> updated again on the next statement. The assignment is redundant so
> removed it.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length
2020-06-04 14:39 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length Colin King
2020-06-07 6:40 ` Leon Romanovsky
@ 2020-06-15 18:39 ` Jason Gunthorpe
1 sibling, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2020-06-15 18:39 UTC (permalink / raw)
To: Colin King
Cc: Leon Romanovsky, Doug Ledford, linux-rdma, kernel-janitors, linux-kernel
On Thu, Jun 04, 2020 at 03:39:02PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment to resp.response_length is never read since it is being
> updated again on the next statement. The assignment is redundant so
> removed it.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 2 --
> 1 file changed, 2 deletions(-)
Applied to for-rc, with a fixes line
Thanks,
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-15 18:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 15:16 [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Colin King
2020-05-07 18:24 ` Leon Romanovsky
2020-05-08 0:04 ` Jason Gunthorpe
2020-06-04 14:39 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length Colin King
2020-06-07 6:40 ` Leon Romanovsky
2020-06-15 18:39 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).