* [PATCH] vdpa: fix error code in vp_vdpa_probe()
@ 2021-06-05 12:47 Dan Carpenter
2021-06-07 2:23 ` Jason Wang
2021-06-07 7:51 ` Stefano Garzarella
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-06-05 12:47 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Jason Wang, Eli Cohen, Stefano Garzarella, virtualization,
kernel-janitors
Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it
returns success.
Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
index c76ebb531212..e5d92db728d3 100644
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
vp_modern_map_vq_notify(mdev, i,
&vp_vdpa->vring[i].notify_pa);
if (!vp_vdpa->vring[i].notify) {
+ ret = -ENOMEM;
dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
goto err;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa: fix error code in vp_vdpa_probe()
2021-06-05 12:47 [PATCH] vdpa: fix error code in vp_vdpa_probe() Dan Carpenter
@ 2021-06-07 2:23 ` Jason Wang
2021-06-07 7:51 ` Stefano Garzarella
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2021-06-07 2:23 UTC (permalink / raw)
To: Dan Carpenter, Michael S. Tsirkin
Cc: Eli Cohen, Stefano Garzarella, virtualization, kernel-janitors
在 2021/6/5 下午8:47, Dan Carpenter 写道:
> Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it
> returns success.
>
> Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index c76ebb531212..e5d92db728d3 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> vp_modern_map_vq_notify(mdev, i,
> &vp_vdpa->vring[i].notify_pa);
> if (!vp_vdpa->vring[i].notify) {
> + ret = -ENOMEM;
> dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
> goto err;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa: fix error code in vp_vdpa_probe()
2021-06-05 12:47 [PATCH] vdpa: fix error code in vp_vdpa_probe() Dan Carpenter
2021-06-07 2:23 ` Jason Wang
@ 2021-06-07 7:51 ` Stefano Garzarella
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2021-06-07 7:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Michael S. Tsirkin, Jason Wang, Eli Cohen, virtualization,
kernel-janitors
On Sat, Jun 05, 2021 at 03:47:28PM +0300, Dan Carpenter wrote:
>Return -ENOMEM if vp_modern_map_vq_notify() fails. Currently it
>returns success.
>
>Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
>index c76ebb531212..e5d92db728d3 100644
>--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
>+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
>@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> vp_modern_map_vq_notify(mdev, i,
> &vp_vdpa->vring[i].notify_pa);
> if (!vp_vdpa->vring[i].notify) {
>+ ret = -ENOMEM;
> dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
> goto err;
> }
>--
>2.30.2
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-05 12:47 [PATCH] vdpa: fix error code in vp_vdpa_probe() Dan Carpenter
2021-06-07 2:23 ` Jason Wang
2021-06-07 7:51 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).