From: Colin Ian King <colin.king@canonical.com>
To: Jim Quinlan <james.quinlan@broadcom.com>,
Markus Elfring <Markus.Elfring@web.de>
Cc: Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
"open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS"
<linux-pci@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jim Quinlan <jquinlan@broadcom.com>,
Alex Dewar <alex.dewar90@gmail.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check
Date: Tue, 22 Sep 2020 12:50:12 +0000 [thread overview]
Message-ID: <22b12b8a-4c16-5377-043d-00750597f822@canonical.com> (raw)
In-Reply-To: <CA+-6iNyGbL2jn1qUdX=AN17Xy5uX1-P=+Xi2NLSxHX-1FwLOwg@mail.gmail.com>
On 22/09/2020 13:43, Jim Quinlan wrote:
> On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>>
>>> The error return ret is not being check with an if statement and
>>
>> Wording alternative:
>> The return value from a call of the function “brcm_phy_start” was not checked and
>>
>>
>>> V2: disable clock as noted by Florian Fainelli and suggested by
>>> Jim Quinlan.
>>
>> Alex Dewar contributed another update suggestion.
>>
>> [PATCH v2] PCI: brcmstb: Add missing if statement and error path
>> https://lore.kernel.org/linux-arm-kernel/20200921211623.33908-1-alex.dewar90@gmail.com/
>> https://lore.kernel.org/patchwork/patch/1309860/
>>
>> The exception handling needs further development considerations
>> for this function implementation.
> Hello,
>
> I agree with Alex's patch. I should have suggested this at the
> beginning but as our upstream STB suspend/resume is not yet functional
> and the one-line change would have worked until we fixed
> suspend/resume.. But this is the proper modification.
Yup, go with Alex's patch. That one is correct.
>
> Thanks,
> Jim
>> Regards,
>> Markus
prev parent reply other threads:[~2020-09-22 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fe38fa7c-8ff7-8e83-968f-91007c058fcc@web.de>
2020-09-22 12:43 ` [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check Jim Quinlan
2020-09-22 12:50 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b12b8a-4c16-5377-043d-00750597f822@canonical.com \
--to=colin.king@canonical.com \
--cc=Markus.Elfring@web.de \
--cc=alex.dewar90@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jquinlan@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).