* Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check [not found] <fe38fa7c-8ff7-8e83-968f-91007c058fcc@web.de> @ 2020-09-22 12:43 ` Jim Quinlan 2020-09-22 12:50 ` Colin Ian King 0 siblings, 1 reply; 2+ messages in thread From: Jim Quinlan @ 2020-09-22 12:43 UTC (permalink / raw) To: Markus Elfring Cc: Rob Herring, Florian Fainelli, open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS, kernel-janitors, open list, Nicolas Saenz Julienne, Lorenzo Pieralisi, maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE, Jim Quinlan, Bjorn Helgaas, Colin Ian King, Alex Dewar, moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE [-- Attachment #1: Type: text/plain, Size: 1041 bytes --] On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring <Markus.Elfring@web.de> wrote: > > > The error return ret is not being check with an if statement and > > Wording alternative: > The return value from a call of the function “brcm_phy_start” was not checked and > > > > V2: disable clock as noted by Florian Fainelli and suggested by > > Jim Quinlan. > > Alex Dewar contributed another update suggestion. > > [PATCH v2] PCI: brcmstb: Add missing if statement and error path > https://lore.kernel.org/linux-arm-kernel/20200921211623.33908-1-alex.dewar90@gmail.com/ > https://lore.kernel.org/patchwork/patch/1309860/ > > The exception handling needs further development considerations > for this function implementation. Hello, I agree with Alex's patch. I should have suggested this at the beginning but as our upstream STB suspend/resume is not yet functional and the one-line change would have worked until we fixed suspend/resume.. But this is the proper modification. Thanks, Jim > Regards, > Markus [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4167 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check 2020-09-22 12:43 ` [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check Jim Quinlan @ 2020-09-22 12:50 ` Colin Ian King 0 siblings, 0 replies; 2+ messages in thread From: Colin Ian King @ 2020-09-22 12:50 UTC (permalink / raw) To: Jim Quinlan, Markus Elfring Cc: Rob Herring, Florian Fainelli, open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS, kernel-janitors, open list, Nicolas Saenz Julienne, Lorenzo Pieralisi, maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE, moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE, Bjorn Helgaas, Jim Quinlan, Alex Dewar, moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE On 22/09/2020 13:43, Jim Quinlan wrote: > On Tue, Sep 22, 2020 at 7:49 AM Markus Elfring <Markus.Elfring@web.de> wrote: >> >>> The error return ret is not being check with an if statement and >> >> Wording alternative: >> The return value from a call of the function “brcm_phy_start” was not checked and >> >> >>> V2: disable clock as noted by Florian Fainelli and suggested by >>> Jim Quinlan. >> >> Alex Dewar contributed another update suggestion. >> >> [PATCH v2] PCI: brcmstb: Add missing if statement and error path >> https://lore.kernel.org/linux-arm-kernel/20200921211623.33908-1-alex.dewar90@gmail.com/ >> https://lore.kernel.org/patchwork/patch/1309860/ >> >> The exception handling needs further development considerations >> for this function implementation. > Hello, > > I agree with Alex's patch. I should have suggested this at the > beginning but as our upstream STB suspend/resume is not yet functional > and the one-line change would have worked until we fixed > suspend/resume.. But this is the proper modification. Yup, go with Alex's patch. That one is correct. > > Thanks, > Jim >> Regards, >> Markus ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-22 12:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <fe38fa7c-8ff7-8e83-968f-91007c058fcc@web.de>
2020-09-22 12:43 ` [PATCH v2] PCI: brcmstb: fix a missing if statement on a return error check Jim Quinlan
2020-09-22 12:50 ` Colin Ian King
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).