From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Huacai Chen <chenhc@lemote.com>,
Jason Cooper <jason@lakedaemon.net>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [1/7] irqchip: Fix potential resource leaks
Date: Wed, 24 Jun 2020 09:56:04 +0000 [thread overview]
Message-ID: <423f83e0-c533-c346-ab8b-f2c6ccc828a2@loongson.cn> (raw)
In-Reply-To: <cc6b95ec-691e-f010-4a04-add39d706c4b@web.de>
On 06/24/2020 05:23 PM, Markus Elfring wrote:
>>> [PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks
>>> https://lore.kernel.org/linux-mips/1592984711-3130-11-git-send-email-yangtiezhu@loongson.cn/
>>> https://lore.kernel.org/patchwork/patch/1263191/
>>>
>>>
>>> Can it matter to omit the word “potential” from change descriptions
>>> after you detected that specific function calls were missing
>>> in if branches?
>> Oh, I find this issue through code review, I have no test environment
>> to trigger the error path, but I think it is better to release the resource
>> in the error path, so I use "potential" description.
> Did you determine that special function calls were generally missing
> in error cases?
Yes, I read many files in drivers/irqchip,
the resource is released in the error path.
>
> Were any known software analysis tools involved for the detection of
> questionable source code places?
kmemleak can detect memory leak,
but I do not know how to detect other kind of leaks.
I think consciously release resource in the error path can avoid leaks.
>
> Regards,
> Markus
next prev parent reply other threads:[~2020-06-24 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 15:55 [PATCH 1/7] irqchip: Fix potential resource leaks Markus Elfring
2020-06-24 1:44 ` Tiezhu Yang
2020-06-24 8:42 ` [1/7] " Markus Elfring
2020-06-24 9:16 ` Tiezhu Yang
2020-06-24 9:23 ` Markus Elfring
2020-06-24 9:56 ` Tiezhu Yang [this message]
2020-06-24 10:06 ` Markus Elfring
2020-06-24 11:30 ` Tiezhu Yang
2020-06-24 12:08 ` Markus Elfring
2020-06-28 3:27 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423f83e0-c533-c346-ab8b-f2c6ccc828a2@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=Markus.Elfring@web.de \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).