Re: [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks

* Re: [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks
@ 2020-06-19 15:03 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-06-19 15:03 UTC (permalink / raw)
  To: Denis Efremov, Coccinelle, Gilles Muller, Julia Lawall,
	Masahiro Yamada, Michal Marek, Nicolas Palix
  Cc: linux-kernel, kernel-janitors, Gustavo A. R. Silva, Kees Cook

> Changes in v2:
…
> - assignment operator used

I would prefer the distinction for the application of corresponding metavariables.

> Changes in v3:
…
>  - \(&E1\|&E2\) changed to &\(E1\|E2\)

Would it be more helpful to mention the movement of the ampersand
before SmPL disjunctions?

…
> +virtual context
> +virtual report
> +virtual org

Can the following SmPL code variant become more attractive?

+virtual context, report, org

…
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;

How do you think about the following SmPL code variant?

+expression subE1 <= as.E1,
+           subE2 <= as.E2,
+           as.E1,
+           as.E2,
+           E3;

…
> +coccilib.report.print_report(p2[0],
> +f"WARNING: same struct_size (line {p1[0].line})")

Please align such function parameters.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=5e857ce6eae7ca21b2055cca4885545e29228fe2#n93

+coccilib.report.print_report(p2[0],
+                             f"WARNING: same struct_size (line {p1[0].line})")

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread