Kernel Newbies archive on lore.kernel.org
 help / color / Atom feed
From: "Alexander Ivanov" <amivanov@fastmail.com>
To: kernelnewbies@kernelnewbies.org,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Subject: Re: GPIO Driver for Skylake-Y PCH
Date: Fri, 14 Jun 2019 12:01:28 -0700
Message-ID: <59c1b6d6-0545-4249-90cb-d1152b6ea728@www.fastmail.com> (raw)
In-Reply-To: <23630.1560537979@turing-police>

[-- Attachment #1.1: Type: text/plain, Size: 1281 bytes --]

Valdis,

Thanks for quick response!

On Fri, 14 Jun 2019 11:46 -07:00, Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
> On Fri, 14 Jun 2019 10:58:53 -0700, "Alexander Ivanov" said:
> 
> > I have a hardware platform with Skylake i7-6500 CPU and Skylake-Y PCH
> > southbridge, running 4.8.5 kernel fc25. The platform has 12 GPIO pins, however,
> > none are available. gpio-pch driver does not support D31:F2 device that manages
> > GPIO.
> 
> > Am I missing something here?
> 
> Well.. my copy of drivers/gpio/gpio-pch.c has this near line 440:
> 
> static const struct pci_device_id pch_gpio_pcidev_id[] = {
>  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
>  { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
>  { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) },
>  { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },
>  { 0, }
> };
> MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);
> 
> Though I'm having a hard time aligning that with "D31:F2". Are you confusing
> a PCI address with a PCI ID, or is this on a non-PCI bus?

No, I believe I am not. This borrowed from Intel doc (https://lab.whitequark.org/files/gpioke/Intel-332690-004EN.pdf, see Ch 2)
It is a PCI device with 8086/9d20 IDs.

--Alex
ps. I apologize, I mistyped "D31:F2" it's supposed to be D31:F1.


[-- Attachment #1.2: Type: text/html, Size: 2211 bytes --]

<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>Valdis,<br></div><div><br></div><div>Thanks for quick response!<br></div><div><br></div><div>On Fri, 14 Jun 2019 11:46 -07:00, Valdis Klētnieks &lt;valdis.kletnieks@vt.edu&gt; wrote:<br></div><blockquote type="cite" id="qt"><div>On Fri, 14 Jun 2019 10:58:53 -0700, "Alexander Ivanov" said:<br></div><div><br></div><div>&gt; I have a hardware platform with Skylake i7-6500 CPU and Skylake-Y PCH<br></div><div>&gt; southbridge, running 4.8.5 kernel fc25. The platform has 12 GPIO pins, however,<br></div><div>&gt; none are available. gpio-pch driver does not support D31:F2 device that manages<br></div><div>&gt; GPIO.<br></div><div><br></div><div>&gt; Am I missing something here?<br></div><div><br></div><div>Well.. my copy of drivers/gpio/gpio-pch.c has this near line 440:<br></div><div><br></div><div>static const struct pci_device_id pch_gpio_pcidev_id[] = {<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8043) },<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8803) },<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; { 0, }<br></div><div>};<br></div><div>MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);<br></div><div><br></div><div>Though I'm having a hard time aligning that with "D31:F2". Are you confusing<br></div><div>a PCI address with a PCI ID, or is this on a non-PCI bus?<br></div></blockquote><div><br></div><div>No, I believe I am not. This borrowed from Intel doc (<a href="https://lab.whitequark.org/files/gpioke/Intel-332690-004EN.pdf">https://lab.whitequark.org/files/gpioke/Intel-332690-004EN.pdf</a>, see&nbsp; Ch 2)<br></div><div>It is a PCI device with 8086/9d20 IDs.<br></div><div><br></div><div>--Alex<br></div><div><div>ps. I apologize, I mistyped "D31:F2" it's supposed to be D31:F1.<br></div><div><div><br></div></div></div><div><br></div></body></html>

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 17:58 Alexander Ivanov
2019-06-14 18:46 ` Valdis Klētnieks
2019-06-14 19:01   ` Alexander Ivanov [this message]
2019-06-14 19:09     ` Valdis Klētnieks
2019-06-14 20:25       ` Alexander Ivanov
2019-06-14 22:40         ` Alexander Ivanov
2019-06-15  8:53           ` Bjørn Mork
2019-06-15 19:30           ` Valdis Klētnieks
2019-06-15 19:38             ` Alexander Ivanov
2019-06-15 19:56               ` Greg KH
2019-06-16  1:50               ` Valdis Klētnieks
2019-06-16  2:45                 ` Alexander Ivanov
2019-06-16  8:54                   ` Bjørn Mork
2019-06-17  8:06             ` Andy Shevchenko
2019-06-18  0:00               ` Alexander Ivanov
2019-06-18  8:40                 ` Andy Shevchenko
2019-06-18 14:48                   ` Valdis Klētnieks
2019-06-18 15:57                     ` Andy Shevchenko
2019-06-18 16:17                       ` Alexander Ivanov
2019-06-14 19:12   ` Bjørn Mork

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59c1b6d6-0545-4249-90cb-d1152b6ea728@www.fastmail.com \
    --to=amivanov@fastmail.com \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Kernel Newbies archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernelnewbies/0 kernelnewbies/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernelnewbies kernelnewbies/ https://lore.kernel.org/kernelnewbies \
		kernelnewbies@kernelnewbies.org kernelnewbies@archiver.kernel.org
	public-inbox-index kernelnewbies


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernelnewbies.kernelnewbies


AGPL code for this site: git clone https://public-inbox.org/ public-inbox