Re: [MAINTAINER SUMMIT] Rethinking the acceptance policy for "trivial" patches

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Wed, 21 Apr 2021 20:04:17 -0700
Joe Perches <joe@perches.com> escreveu:

> On Wed, 2021-04-21 at 22:05 -0400, Martin K. Petersen wrote:
> > James,
> >   
> > > Our policy in SCSI for a long time has been no trivial patches
> > > accepted to maintained drivers,  
> > 
> > I'm afraid that ship sailed years ago. I am merging a ton of trivial
> > patches in SCSI.  
> 
> True and thank you.
> 
> Perhaps the primary thing that James' email shows is that he's not
> actively watching drivers/scsi/ git tree changes very much.
> 
> And I believe James is referring to whitespace style trivial patches.
> 
> > The reality is that not merging trivial patches is a losing battle. The
> > various static checkers appear to develop defect detection parity and
> > gcc and LLVM get more picky with every release.  
> 
> True, but perhaps most of the pickiness can be mitigated by moving
> various warnings to W=2 or W=3.

Not sure if this would solve anything. Also, it starts showing a lot
of false-positive issues, like those:

	./arch/x86/include/asm/bitops.h:283:28: warning: declaration of ‘ffs’ shadows a built-in function [-Wshadow]
	  283 | static __always_inline int ffs(int x)
	      |                            ^~~

	<stdin>:21: warning: macro "__IGNORE_stat64" is not used [-Wunused-macros]
	<stdin>:22: warning: macro "__IGNORE_lstat64" is not used [-Wunused-macros]
	<stdin>:157: warning: macro "__IGNORE_madvise1" is not used [-Wunused-macros]
	<stdin>:73: warning: macro "__IGNORE_llseek" is not used [-Wunused-macros]


Btw, -Wunused-macros is probably that it probably doesn't make any sense
to have "fixes". Having things like:

	#define SOME_UNUSED_FOO

won't cause any real issue, and attempts to drop those would result
on lots of ifdefs for no good reason, like:

#ifdef CONFIG_FOO
#  define SOMETHING_USED_ONLY_WHEN_CONFIG_FOO
#endif

I would move it to be out of W=2.

Thanks,
Mauro