From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 1/4] vfio-ccw: Refactor how the traces are built
Date: Tue, 15 Oct 2019 15:46:45 +0200 [thread overview]
Message-ID: <20191015154645.2c35dd32.cohuck@redhat.com> (raw)
In-Reply-To: <20191014180855.19400-2-farman@linux.ibm.com>
On Mon, 14 Oct 2019 20:08:52 +0200
Eric Farman <farman@linux.ibm.com> wrote:
> Commit 3cd90214b70f ("vfio: ccw: add tracepoints for interesting error
> paths") added a quick trace point to determine where a channel program
> failed while being processed. It's a great addition, but adding more
> traces to vfio-ccw is more cumbersome than it needs to be.
>
> Let's refactor how this is done, so that additional traces are easier
> to add and can exist outside of the FSM if we ever desire.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/Makefile | 4 ++--
> drivers/s390/cio/vfio_ccw_cp.h | 1 +
> drivers/s390/cio/vfio_ccw_fsm.c | 3 ---
> drivers/s390/cio/vfio_ccw_trace.c | 12 ++++++++++++
> drivers/s390/cio/vfio_ccw_trace.h | 2 ++
> 5 files changed, 17 insertions(+), 5 deletions(-)
> create mode 100644 drivers/s390/cio/vfio_ccw_trace.c
Looks good.
I'm wondering whether we could consolidate tracepoints and s390dbf
usage somehow. These two complement each other in a way (looking at a
live system vs. looking at a crash dump, integration with other parts
of the system), but they currently also cover at least partially
different code paths. Not sure how much sense it makes to have double
coverage at least for a subset of the functionality.
next prev parent reply other threads:[~2019-10-15 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:08 [RFC PATCH 0/4] vfio-ccw: A couple trace changes Eric Farman
2019-10-14 18:08 ` [RFC PATCH 1/4] vfio-ccw: Refactor how the traces are built Eric Farman
2019-10-15 13:46 ` Cornelia Huck [this message]
2019-10-15 15:30 ` Eric Farman
2019-10-14 18:08 ` [RFC PATCH 2/4] vfio-ccw: Trace the FSM jumptable Eric Farman
2019-10-15 10:01 ` Steffen Maier
2019-10-15 13:42 ` Eric Farman
2019-10-15 13:53 ` Cornelia Huck
2019-10-15 14:00 ` Steffen Maier
2019-10-14 18:08 ` [RFC PATCH 3/4] vfio-ccw: Add a trace for asynchronous requests Eric Farman
2019-10-15 9:54 ` Steffen Maier
2019-10-15 15:24 ` Eric Farman
2019-10-14 18:08 ` [RFC PATCH 4/4] vfio-ccw: Rename the io_fctl trace Eric Farman
2019-10-15 13:55 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015154645.2c35dd32.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).