From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 4/4] vfio-ccw: Rename the io_fctl trace
Date: Tue, 15 Oct 2019 15:55:55 +0200 [thread overview]
Message-ID: <20191015155555.24275800.cohuck@redhat.com> (raw)
In-Reply-To: <20191014180855.19400-5-farman@linux.ibm.com>
On Mon, 14 Oct 2019 20:08:55 +0200
Eric Farman <farman@linux.ibm.com> wrote:
> Rename this trace to the function name, so we remember what is being
> traced instead of an abstract reference to the function control bit
> of the SCSW (since that exists in the IRB, but not the ORB).
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_fsm.c | 4 ++--
> drivers/s390/cio/vfio_ccw_trace.c | 2 +-
> drivers/s390/cio/vfio_ccw_trace.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
That makes sense (I don't supposed this is used in any tooling, as it
is more of a low-level debug trace.)
prev parent reply other threads:[~2019-10-15 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:08 [RFC PATCH 0/4] vfio-ccw: A couple trace changes Eric Farman
2019-10-14 18:08 ` [RFC PATCH 1/4] vfio-ccw: Refactor how the traces are built Eric Farman
2019-10-15 13:46 ` Cornelia Huck
2019-10-15 15:30 ` Eric Farman
2019-10-14 18:08 ` [RFC PATCH 2/4] vfio-ccw: Trace the FSM jumptable Eric Farman
2019-10-15 10:01 ` Steffen Maier
2019-10-15 13:42 ` Eric Farman
2019-10-15 13:53 ` Cornelia Huck
2019-10-15 14:00 ` Steffen Maier
2019-10-14 18:08 ` [RFC PATCH 3/4] vfio-ccw: Add a trace for asynchronous requests Eric Farman
2019-10-15 9:54 ` Steffen Maier
2019-10-15 15:24 ` Eric Farman
2019-10-14 18:08 ` [RFC PATCH 4/4] vfio-ccw: Rename the io_fctl trace Eric Farman
2019-10-15 13:55 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015155555.24275800.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).