From: Steffen Maier <maier@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Eric Farman <farman@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] vfio-ccw: Trace the FSM jumptable
Date: Tue, 15 Oct 2019 16:00:09 +0200 [thread overview]
Message-ID: <4d9b1e87-18be-24f3-5f4d-796442b882a5@linux.ibm.com> (raw)
In-Reply-To: <20191015155339.0d714c75.cohuck@redhat.com>
On 10/15/19 3:53 PM, Cornelia Huck wrote:
> On Tue, 15 Oct 2019 12:01:12 +0200
> Steffen Maier <maier@linux.ibm.com> wrote:
>
>> On 10/14/19 8:08 PM, Eric Farman wrote:
>>> It would be nice if we could track the sequence of events within
>>> vfio-ccw, based on the state of the device/FSM and our calling
>>> sequence within it. So let's add a simple trace here so we can
>>> watch the states change as things go, and allow it to be folded
>>> into the rest of the other cio traces.
>>>
>>> Signed-off-by: Eric Farman <farman@linux.ibm.com>
>>> ---
>>> drivers/s390/cio/vfio_ccw_private.h | 1 +
>>> drivers/s390/cio/vfio_ccw_trace.c | 1 +
>>> drivers/s390/cio/vfio_ccw_trace.h | 26 ++++++++++++++++++++++++++
>>> 3 files changed, 28 insertions(+)
>
> (...)
>
>>> diff --git a/drivers/s390/cio/vfio_ccw_trace.h b/drivers/s390/cio/vfio_ccw_trace.h
>>> index 2a2937a40124..24a8152acfdf 100644
>>> --- a/drivers/s390/cio/vfio_ccw_trace.h
>>> +++ b/drivers/s390/cio/vfio_ccw_trace.h
>>> @@ -17,6 +17,32 @@
>>>
>>> #include <linux/tracepoint.h>
>>>
>>> +TRACE_EVENT(vfio_ccw_fsm_event,
>>> + TP_PROTO(struct subchannel_id schid, int state, int event),
>>> + TP_ARGS(schid, state, event),
>>> +
>>> + TP_STRUCT__entry(
>>> + __field(u8, cssid)
>>> + __field(u8, ssid)
>>> + __field(u16, schno)
>>> + __field(int, state)
>>> + __field(int, event)
>>> + ),
>>> +
>>> + TP_fast_assign(
>>> + __entry->cssid = schid.cssid;
>>> + __entry->ssid = schid.ssid;
>>> + __entry->schno = schid.sch_no;
>>> + __entry->state = state;
>>> + __entry->event = event;
>>> + ),
>>> +
>>> + TP_printk("schid=%x.%x.%04x state=%x event=%x",
>>
>> /sys/kernel/debug/tracing/events](0)# grep -R '%[^%]*x'
>>
>> Many existing TPs often seem to format hex output with a 0x prefix (either
>> explicit with 0x%x or implicit with %#x). Since some of your other TPs also
>> output decimal integer values, I wonder if a distinction would help
>> unexperienced TP readers.
>
> I generally agree. However, we explicitly don't want to do that for
> schid formatting (as it should match the bus id). For event, it might
> become relevant should we want to introduce a high number of new events
> in the future (currently, there's a grand total of four events.)
Yeah, thanks for clarifying. I meant just state and event, not schid.
>
>>
>>> + __entry->cssid, __entry->ssid, __entry->schno,
>>> + __entry->state,
>>> + __entry->event)
>>> +);
>>> +
>>> TRACE_EVENT(vfio_ccw_io_fctl,
>>> TP_PROTO(int fctl, struct subchannel_id schid, int errno, char *errstr),
>>> TP_ARGS(fctl, schid, errno, errstr),
>>>
>>
>>
>
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2019-10-15 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:08 [RFC PATCH 0/4] vfio-ccw: A couple trace changes Eric Farman
2019-10-14 18:08 ` [RFC PATCH 1/4] vfio-ccw: Refactor how the traces are built Eric Farman
2019-10-15 13:46 ` Cornelia Huck
2019-10-15 15:30 ` Eric Farman
2019-10-14 18:08 ` [RFC PATCH 2/4] vfio-ccw: Trace the FSM jumptable Eric Farman
2019-10-15 10:01 ` Steffen Maier
2019-10-15 13:42 ` Eric Farman
2019-10-15 13:53 ` Cornelia Huck
2019-10-15 14:00 ` Steffen Maier [this message]
2019-10-14 18:08 ` [RFC PATCH 3/4] vfio-ccw: Add a trace for asynchronous requests Eric Farman
2019-10-15 9:54 ` Steffen Maier
2019-10-15 15:24 ` Eric Farman
2019-10-14 18:08 ` [RFC PATCH 4/4] vfio-ccw: Rename the io_fctl trace Eric Farman
2019-10-15 13:55 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9b1e87-18be-24f3-5f4d-796442b882a5@linux.ibm.com \
--to=maier@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).