From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, david@redhat.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH v2 5/7] s390x: smp: Wait for cpu setup to finish
Date: Thu, 16 Jan 2020 07:05:11 -0500 [thread overview]
Message-ID: <20200116120513.2244-6-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200116120513.2244-1-frankja@linux.ibm.com>
We store the user provided psw address into restart new, so a psw
restart does not lead us through setup again.
Also we wait on smp_cpu_setup() until the cpu has finished setup
before returning. This is necessary for z/VM and LPAR where sigp is
asynchronous.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
lib/s390x/smp.c | 2 ++
s390x/cstart64.S | 2 ++
2 files changed, 4 insertions(+)
diff --git a/lib/s390x/smp.c b/lib/s390x/smp.c
index f984a34..0a0bc1c 100644
--- a/lib/s390x/smp.c
+++ b/lib/s390x/smp.c
@@ -199,6 +199,8 @@ int smp_cpu_setup(uint16_t addr, struct psw psw)
/* Start processing */
smp_cpu_restart_nolock(addr, NULL);
+ /* Wait until the cpu has finished setup and started the provided psw */
+ while (lc->restart_new_psw.addr != psw.addr) { mb(); }
out:
spin_unlock(&lock);
return rc;
diff --git a/s390x/cstart64.S b/s390x/cstart64.S
index 86dd4c4..9af6bb3 100644
--- a/s390x/cstart64.S
+++ b/s390x/cstart64.S
@@ -159,6 +159,8 @@ smp_cpu_setup_state:
xgr %r1, %r1
lmg %r0, %r15, GEN_LC_SW_INT_GRS
lctlg %c0, %c0, GEN_LC_SW_INT_CRS
+ /* We should only go once through cpu setup and not for every restart */
+ stg %r14, GEN_LC_RESTART_NEW_PSW + 8
br %r14
pgm_int:
--
2.20.1
next prev parent reply other threads:[~2020-01-16 12:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:05 [kvm-unit-tests PATCH v2 0/7] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 1/7] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-16 12:13 ` David Hildenbrand
2020-01-16 13:01 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 2/7] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-16 12:18 ` David Hildenbrand
2020-01-16 13:01 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 3/7] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-16 12:17 ` David Hildenbrand
2020-01-16 13:04 ` Janosch Frank
2020-01-16 13:19 ` David Hildenbrand
2020-01-16 13:59 ` Cornelia Huck
2020-01-16 14:11 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 4/7] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-16 14:14 ` Cornelia Huck
2020-01-16 14:44 ` Janosch Frank
2020-01-16 15:05 ` Cornelia Huck
2020-01-16 12:05 ` Janosch Frank [this message]
2020-01-16 12:19 ` [kvm-unit-tests PATCH v2 5/7] s390x: smp: Wait for cpu setup to finish David Hildenbrand
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 6/7] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-16 12:24 ` David Hildenbrand
2020-01-16 13:07 ` Janosch Frank
2020-01-16 13:18 ` David Hildenbrand
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 7/7] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-01-17 10:20 ` David Hildenbrand
2020-01-17 10:29 ` Thomas Huth
2020-01-17 10:41 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116120513.2244-6-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).