From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 6/7] s390x: smp: Test all CRs on initial reset
Date: Thu, 16 Jan 2020 14:18:05 +0100 [thread overview]
Message-ID: <6f2c30a7-78a6-ef85-20dd-865e3087cdd0@redhat.com> (raw)
In-Reply-To: <400dc0d2-86bc-cdc8-ec8a-7d1148ebd5fa@linux.ibm.com>
On 16.01.20 14:07, Janosch Frank wrote:
> On 1/16/20 1:24 PM, David Hildenbrand wrote:
>> On 16.01.20 13:05, Janosch Frank wrote:
>>> All CRs are set to 0 and CRs 0 and 14 are set to pre-defined values,
>>> so we also need to test 1-13 and 15 for 0.
>>>
>>> And while we're at it, let's also set some values to cr 1, 7 and 13, so
>>> we can actually be sure that they will be zeroed.
>>>
>>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>>> ---
>>> s390x/smp.c | 19 ++++++++++++++++++-
>>> 1 file changed, 18 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/s390x/smp.c b/s390x/smp.c
>>> index d430638..ce3215d 100644
>>> --- a/s390x/smp.c
>>> +++ b/s390x/smp.c
>>> @@ -176,16 +176,31 @@ static void test_emcall(void)
>>> report_prefix_pop();
>>> }
>>>
>>> +/* Used to dirty registers of cpu #1 before it is reset */
>>> +static void test_func_initial(void)
>>> +{
>>> + lctlg(1, 0x42000UL);
>>> + lctlg(7, 0x43000UL);
>>> + lctlg(13, 0x44000UL);
>>> + testflag = 1;
>>> + mb();
>>> + cpu_loop();
>>
>> Can we make cpu_loop() the default when this function returns? (IOW, an
>> endless loop whenever a cpu finished executing the function?)
>
> So adding it to cstart64.S after the br 14?
Yes I think so.
>
>>
>> Do we need the mb() here?
>
> Would the compiler reorder the lctlcg and testflag if it could?
lctlg() does not have a "memory" constraint, so I guess it would be
valid if it would reorder.
I assume the mb() would have to be moved in front of the testflag=1?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-16 13:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:05 [kvm-unit-tests PATCH v2 0/7] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 1/7] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-16 12:13 ` David Hildenbrand
2020-01-16 13:01 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 2/7] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-16 12:18 ` David Hildenbrand
2020-01-16 13:01 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 3/7] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-16 12:17 ` David Hildenbrand
2020-01-16 13:04 ` Janosch Frank
2020-01-16 13:19 ` David Hildenbrand
2020-01-16 13:59 ` Cornelia Huck
2020-01-16 14:11 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 4/7] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-16 14:14 ` Cornelia Huck
2020-01-16 14:44 ` Janosch Frank
2020-01-16 15:05 ` Cornelia Huck
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 5/7] s390x: smp: Wait for cpu setup to finish Janosch Frank
2020-01-16 12:19 ` David Hildenbrand
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 6/7] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-16 12:24 ` David Hildenbrand
2020-01-16 13:07 ` Janosch Frank
2020-01-16 13:18 ` David Hildenbrand [this message]
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 7/7] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-01-17 10:20 ` David Hildenbrand
2020-01-17 10:29 ` Thomas Huth
2020-01-17 10:41 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f2c30a7-78a6-ef85-20dd-865e3087cdd0@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).