From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/7] s390x: smp: Only use smp_cpu_setup once
Date: Thu, 16 Jan 2020 13:18:43 +0100 [thread overview]
Message-ID: <9847c5e8-2950-add1-e86b-0d14f0aca0bd@redhat.com> (raw)
In-Reply-To: <20200116120513.2244-3-frankja@linux.ibm.com>
On 16.01.20 13:05, Janosch Frank wrote:
> Let's stop and start instead of using setup to run a function on a
> cpu.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> ---
> s390x/smp.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/s390x/smp.c b/s390x/smp.c
> index 02204fd..d430638 100644
> --- a/s390x/smp.c
> +++ b/s390x/smp.c
> @@ -47,7 +47,7 @@ static void test_start(void)
> psw.mask = extract_psw_mask();
> psw.addr = (unsigned long)test_func;
>
> - smp_cpu_setup(1, psw);
> + smp_cpu_start(1, psw);
> wait_for_flag();
> report(1, "start");
> }
> @@ -132,9 +132,8 @@ static void test_ecall(void)
>
> report_prefix_push("ecall");
> testflag = 0;
> - smp_cpu_destroy(1);
>
> - smp_cpu_setup(1, psw);
> + smp_cpu_start(1, psw);
> wait_for_flag();
> testflag = 0;
> sigp(1, SIGP_EXTERNAL_CALL, 0, NULL);
> @@ -167,9 +166,8 @@ static void test_emcall(void)
>
> report_prefix_push("emcall");
> testflag = 0;
> - smp_cpu_destroy(1);
>
> - smp_cpu_setup(1, psw);
> + smp_cpu_start(1, psw);
> wait_for_flag();
> testflag = 0;
> sigp(1, SIGP_EMERGENCY_SIGNAL, 0, NULL);
> @@ -187,7 +185,7 @@ static void test_reset_initial(void)
> psw.addr = (unsigned long)test_func;
>
> report_prefix_push("reset initial");
> - smp_cpu_setup(1, psw);
> + smp_cpu_start(1, psw);
>
> sigp_retry(1, SIGP_INITIAL_CPU_RESET, 0, NULL);
> sigp(1, SIGP_STORE_STATUS_AT_ADDRESS, (uintptr_t)status, NULL);
> @@ -218,7 +216,7 @@ static void test_reset(void)
> psw.addr = (unsigned long)test_func;
>
> report_prefix_push("cpu reset");
> - smp_cpu_setup(1, psw);
> + smp_cpu_start(1, psw);
>
> sigp_retry(1, SIGP_CPU_RESET, 0, NULL);
> report(smp_cpu_stopped(1), "cpu stopped");
> @@ -227,6 +225,7 @@ static void test_reset(void)
>
> int main(void)
> {
> + struct psw psw;
> report_prefix_push("smp");
>
> if (smp_query_num_cpus() == 1) {
> @@ -234,6 +233,12 @@ int main(void)
> goto done;
> }
>
> + /* Setting up the cpu to give it a stack and lowcore */
> + psw.mask = extract_psw_mask();
> + psw.addr = (unsigned long)cpu_loop;
> + smp_cpu_setup(1, psw);
> + smp_cpu_stop(1);
> +
> test_start();
> test_stop();
> test_stop_store_status();
> @@ -242,6 +247,7 @@ int main(void)
> test_emcall();
> test_reset();
> test_reset_initial();
> + smp_cpu_destroy(1);
>
> done:
> report_prefix_pop();
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-16 12:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:05 [kvm-unit-tests PATCH v2 0/7] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 1/7] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-16 12:13 ` David Hildenbrand
2020-01-16 13:01 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 2/7] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-16 12:18 ` David Hildenbrand [this message]
2020-01-16 13:01 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 3/7] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-16 12:17 ` David Hildenbrand
2020-01-16 13:04 ` Janosch Frank
2020-01-16 13:19 ` David Hildenbrand
2020-01-16 13:59 ` Cornelia Huck
2020-01-16 14:11 ` Janosch Frank
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 4/7] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-16 14:14 ` Cornelia Huck
2020-01-16 14:44 ` Janosch Frank
2020-01-16 15:05 ` Cornelia Huck
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 5/7] s390x: smp: Wait for cpu setup to finish Janosch Frank
2020-01-16 12:19 ` David Hildenbrand
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 6/7] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-16 12:24 ` David Hildenbrand
2020-01-16 13:07 ` Janosch Frank
2020-01-16 13:18 ` David Hildenbrand
2020-01-16 12:05 ` [kvm-unit-tests PATCH v2 7/7] s390x: smp: Dirty fpc before initial reset test Janosch Frank
2020-01-17 10:20 ` David Hildenbrand
2020-01-17 10:29 ` Thomas Huth
2020-01-17 10:41 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9847c5e8-2950-add1-e86b-0d14f0aca0bd@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).