From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, david@redhat.com, cohuck@redhat.com
Subject: [kvm-unit-tests PATCH v4 2/9] s390x: smp: Only use smp_cpu_setup once
Date: Tue, 21 Jan 2020 08:42:47 -0500 [thread overview]
Message-ID: <20200121134254.4570-3-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200121134254.4570-1-frankja@linux.ibm.com>
Let's stop and start instead of using setup to run a function on a
cpu.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: David Hildenbrand <david@redhat.com>
---
s390x/smp.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/s390x/smp.c b/s390x/smp.c
index e37eb56..3e8cf3e 100644
--- a/s390x/smp.c
+++ b/s390x/smp.c
@@ -53,7 +53,7 @@ static void test_start(void)
psw.addr = (unsigned long)test_func;
set_flag(0);
- smp_cpu_setup(1, psw);
+ smp_cpu_start(1, psw);
wait_for_flag();
report(1, "start");
}
@@ -109,6 +109,7 @@ static void test_store_status(void)
report(1, "status written");
free_pages(status, PAGE_SIZE * 2);
report_prefix_pop();
+ smp_cpu_stop(1);
report_prefix_pop();
}
@@ -137,9 +138,8 @@ static void test_ecall(void)
report_prefix_push("ecall");
set_flag(0);
- smp_cpu_destroy(1);
- smp_cpu_setup(1, psw);
+ smp_cpu_start(1, psw);
wait_for_flag();
set_flag(0);
sigp(1, SIGP_EXTERNAL_CALL, 0, NULL);
@@ -172,9 +172,8 @@ static void test_emcall(void)
report_prefix_push("emcall");
set_flag(0);
- smp_cpu_destroy(1);
- smp_cpu_setup(1, psw);
+ smp_cpu_start(1, psw);
wait_for_flag();
set_flag(0);
sigp(1, SIGP_EMERGENCY_SIGNAL, 0, NULL);
@@ -192,7 +191,7 @@ static void test_reset_initial(void)
psw.addr = (unsigned long)test_func;
report_prefix_push("reset initial");
- smp_cpu_setup(1, psw);
+ smp_cpu_start(1, psw);
sigp_retry(1, SIGP_INITIAL_CPU_RESET, 0, NULL);
sigp(1, SIGP_STORE_STATUS_AT_ADDRESS, (uintptr_t)status, NULL);
@@ -223,7 +222,7 @@ static void test_reset(void)
psw.addr = (unsigned long)test_func;
report_prefix_push("cpu reset");
- smp_cpu_setup(1, psw);
+ smp_cpu_start(1, psw);
sigp_retry(1, SIGP_CPU_RESET, 0, NULL);
report(smp_cpu_stopped(1), "cpu stopped");
@@ -232,6 +231,7 @@ static void test_reset(void)
int main(void)
{
+ struct psw psw;
report_prefix_push("smp");
if (smp_query_num_cpus() == 1) {
@@ -239,6 +239,12 @@ int main(void)
goto done;
}
+ /* Setting up the cpu to give it a stack and lowcore */
+ psw.mask = extract_psw_mask();
+ psw.addr = (unsigned long)cpu_loop;
+ smp_cpu_setup(1, psw);
+ smp_cpu_stop(1);
+
test_start();
test_stop();
test_stop_store_status();
@@ -247,6 +253,7 @@ int main(void)
test_emcall();
test_reset();
test_reset_initial();
+ smp_cpu_destroy(1);
done:
report_prefix_pop();
--
2.20.1
next prev parent reply other threads:[~2020-01-21 13:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:42 [kvm-unit-tests PATCH v4 0/9] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 1/9] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-21 13:42 ` Janosch Frank [this message]
2020-01-23 13:45 ` [kvm-unit-tests PATCH v4 2/9] s390x: smp: Only use smp_cpu_setup once David Hildenbrand
2020-01-23 13:54 ` Janosch Frank
2020-01-23 13:56 ` David Hildenbrand
2020-01-24 8:28 ` David Hildenbrand
2020-01-24 8:38 ` David Hildenbrand
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 3/9] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-23 10:02 ` Janosch Frank
2020-01-23 10:03 ` [kvm-unit-tests PATCH] " Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 4/9] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-21 17:40 ` David Hildenbrand
2020-01-22 8:25 ` Janosch Frank
2020-01-23 9:14 ` [kvm-unit-tests PATCH] " Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 5/9] s390x: smp: Wait for cpu setup to finish Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 6/9] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-01-21 14:28 ` Cornelia Huck
2020-01-21 17:36 ` David Hildenbrand
2020-01-23 13:32 ` David Hildenbrand
2020-01-23 13:47 ` Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 7/9] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-01-21 14:30 ` Cornelia Huck
2020-01-21 17:36 ` David Hildenbrand
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 8/9] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 9/9] s390x: smp: Dirty fpc before initial reset test Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121134254.4570-3-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).