From: Cornelia Huck <cohuck@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v4 6/9] s390x: smp: Loop if secondary cpu returns into cpu setup again
Date: Tue, 21 Jan 2020 15:28:44 +0100 [thread overview]
Message-ID: <20200121152844.22fd9e03.cohuck@redhat.com> (raw)
In-Reply-To: <20200121134254.4570-7-frankja@linux.ibm.com>
On Tue, 21 Jan 2020 08:42:51 -0500
Janosch Frank <frankja@linux.ibm.com> wrote:
> Up to now a secondary cpu could have returned from the function it was
> executing and ending up somewhere in cstart64.S. This was mostly
> circumvented by an endless loop in the function that it executed.
>
> Let's add a loop to the end of the cpu setup, so we don't have to rely
> on added loops in the tests.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/cstart64.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/s390x/cstart64.S b/s390x/cstart64.S
> index 9af6bb3..5fd8d2f 100644
> --- a/s390x/cstart64.S
> +++ b/s390x/cstart64.S
> @@ -162,6 +162,8 @@ smp_cpu_setup_state:
> /* We should only go once through cpu setup and not for every restart */
> stg %r14, GEN_LC_RESTART_NEW_PSW + 8
> br %r14
> + /* If the function returns, just loop here */
> +0: j 0
>
> pgm_int:
> SAVE_REGS
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-01-21 14:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:42 [kvm-unit-tests PATCH v4 0/9] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 1/9] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 2/9] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-23 13:45 ` David Hildenbrand
2020-01-23 13:54 ` Janosch Frank
2020-01-23 13:56 ` David Hildenbrand
2020-01-24 8:28 ` David Hildenbrand
2020-01-24 8:38 ` David Hildenbrand
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 3/9] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-23 10:02 ` Janosch Frank
2020-01-23 10:03 ` [kvm-unit-tests PATCH] " Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 4/9] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-21 17:40 ` David Hildenbrand
2020-01-22 8:25 ` Janosch Frank
2020-01-23 9:14 ` [kvm-unit-tests PATCH] " Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 5/9] s390x: smp: Wait for cpu setup to finish Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 6/9] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-01-21 14:28 ` Cornelia Huck [this message]
2020-01-21 17:36 ` David Hildenbrand
2020-01-23 13:32 ` David Hildenbrand
2020-01-23 13:47 ` Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 7/9] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-01-21 14:30 ` Cornelia Huck
2020-01-21 17:36 ` David Hildenbrand
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 8/9] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-21 13:42 ` [kvm-unit-tests PATCH v4 9/9] s390x: smp: Dirty fpc before initial reset test Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121152844.22fd9e03.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).