* [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test
@ 2020-02-05 15:29 Paolo Bonzini
2020-02-05 15:49 ` Sean Christopherson
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2020-02-05 15:29 UTC (permalink / raw)
To: kvm; +Cc: sean.j.christopherson, vkuznets
The PCID test checks for exceptions when PCID=0 or INVPCID=0 in
CPUID. Cover that by adding a separate testcase with different
CPUID.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
x86/unittests.cfg | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index aae1523..f2401eb 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -228,7 +228,12 @@ extra_params = --append "10000000 `date +%s`"
[pcid]
file = pcid.flat
-extra_params = -cpu qemu64,+pcid
+extra_params = -cpu qemu64,+pcid,+invpcid
+arch = x86_64
+
+[pcid-disabled]
+file = pcid.flat
+extra_params = -cpu qemu64,-pcid,-invpcid
arch = x86_64
[rdpru]
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test
2020-02-05 15:29 [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test Paolo Bonzini
@ 2020-02-05 15:49 ` Sean Christopherson
2020-02-05 17:22 ` Andrew Jones
0 siblings, 1 reply; 4+ messages in thread
From: Sean Christopherson @ 2020-02-05 15:49 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, vkuznets
On Wed, Feb 05, 2020 at 04:29:40PM +0100, Paolo Bonzini wrote:
> The PCID test checks for exceptions when PCID=0 or INVPCID=0 in
> CPUID. Cover that by adding a separate testcase with different
> CPUID.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> x86/unittests.cfg | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index aae1523..f2401eb 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -228,7 +228,12 @@ extra_params = --append "10000000 `date +%s`"
>
> [pcid]
> file = pcid.flat
> -extra_params = -cpu qemu64,+pcid
> +extra_params = -cpu qemu64,+pcid,+invpcid
> +arch = x86_64
> +
> +[pcid-disabled]
> +file = pcid.flat
> +extra_params = -cpu qemu64,-pcid,-invpcid
> arch = x86_64
Hrm, but "-cpu qemu64,-pcid,+invpcid" is arguably the more interesting test
from a KVM perspective because of the logic in KVM to hide invpcid if pcid
isn't supported.
And +pcid,-invpcid is also interesting.
Is there an easy-ish change that can be made to allow iterating over
multiple CPU configurations for single test case?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test
2020-02-05 15:49 ` Sean Christopherson
@ 2020-02-05 17:22 ` Andrew Jones
2020-02-05 17:41 ` Sean Christopherson
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Jones @ 2020-02-05 17:22 UTC (permalink / raw)
To: Sean Christopherson; +Cc: Paolo Bonzini, kvm, vkuznets
On Wed, Feb 05, 2020 at 07:49:04AM -0800, Sean Christopherson wrote:
> On Wed, Feb 05, 2020 at 04:29:40PM +0100, Paolo Bonzini wrote:
> > The PCID test checks for exceptions when PCID=0 or INVPCID=0 in
> > CPUID. Cover that by adding a separate testcase with different
> > CPUID.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > x86/unittests.cfg | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index aae1523..f2401eb 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -228,7 +228,12 @@ extra_params = --append "10000000 `date +%s`"
> >
> > [pcid]
> > file = pcid.flat
> > -extra_params = -cpu qemu64,+pcid
> > +extra_params = -cpu qemu64,+pcid,+invpcid
> > +arch = x86_64
> > +
> > +[pcid-disabled]
> > +file = pcid.flat
> > +extra_params = -cpu qemu64,-pcid,-invpcid
> > arch = x86_64
>
> Hrm, but "-cpu qemu64,-pcid,+invpcid" is arguably the more interesting test
> from a KVM perspective because of the logic in KVM to hide invpcid if pcid
> isn't supported.
>
> And +pcid,-invpcid is also interesting.
>
> Is there an easy-ish change that can be made to allow iterating over
> multiple CPU configurations for single test case?
>
Just a small change to Paolo's patch
[pcid]
file = pcid.flat
extra_params = -cpu qemu64,+pcid,+invpcid
arch = x86_64
group = pcid
[pcid-disabled]
file = pcid.flat
extra_params = -cpu qemu64,-pcid,-invpcid
arch = x86_64
group = pcid
[pcid-more-interesting]
file = pcid.flat
extra_params = -cpu qemu64,-pcid,+invpcid
arch = x86_64
group = pcid
Then run the group with ./run_tests.sh -g pcid
Thanks,
drew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test
2020-02-05 17:22 ` Andrew Jones
@ 2020-02-05 17:41 ` Sean Christopherson
0 siblings, 0 replies; 4+ messages in thread
From: Sean Christopherson @ 2020-02-05 17:41 UTC (permalink / raw)
To: Andrew Jones; +Cc: Paolo Bonzini, kvm, vkuznets
On Wed, Feb 05, 2020 at 06:22:05PM +0100, Andrew Jones wrote:
> On Wed, Feb 05, 2020 at 07:49:04AM -0800, Sean Christopherson wrote:
> > On Wed, Feb 05, 2020 at 04:29:40PM +0100, Paolo Bonzini wrote:
> > > The PCID test checks for exceptions when PCID=0 or INVPCID=0 in
> > > CPUID. Cover that by adding a separate testcase with different
> > > CPUID.
> > >
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > > x86/unittests.cfg | 7 ++++++-
> > > 1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > > index aae1523..f2401eb 100644
> > > --- a/x86/unittests.cfg
> > > +++ b/x86/unittests.cfg
> > > @@ -228,7 +228,12 @@ extra_params = --append "10000000 `date +%s`"
> > >
> > > [pcid]
> > > file = pcid.flat
> > > -extra_params = -cpu qemu64,+pcid
> > > +extra_params = -cpu qemu64,+pcid,+invpcid
> > > +arch = x86_64
> > > +
> > > +[pcid-disabled]
> > > +file = pcid.flat
> > > +extra_params = -cpu qemu64,-pcid,-invpcid
> > > arch = x86_64
> >
> > Hrm, but "-cpu qemu64,-pcid,+invpcid" is arguably the more interesting test
> > from a KVM perspective because of the logic in KVM to hide invpcid if pcid
> > isn't supported.
> >
> > And +pcid,-invpcid is also interesting.
> >
> > Is there an easy-ish change that can be made to allow iterating over
> > multiple CPU configurations for single test case?
> >
>
> Just a small change to Paolo's patch
>
> [pcid]
> file = pcid.flat
> extra_params = -cpu qemu64,+pcid,+invpcid
> arch = x86_64
> group = pcid
>
> [pcid-disabled]
> file = pcid.flat
> extra_params = -cpu qemu64,-pcid,-invpcid
> arch = x86_64
> group = pcid
>
> [pcid-more-interesting]
> file = pcid.flat
> extra_params = -cpu qemu64,-pcid,+invpcid
> arch = x86_64
> group = pcid
>
> Then run the group with ./run_tests.sh -g pcid
Ya, I was thinking more long term, e.g. syntax like:
[pcid]
file = pcid.flat
permute_features = pcid,invpcid
arch = x86_64
In general, I would love to have infrastructure to permute over *all* the
interesting bits of KVM, e.g. module params and whatnot.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-05 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 15:29 [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test Paolo Bonzini
2020-02-05 15:49 ` Sean Christopherson
2020-02-05 17:22 ` Andrew Jones
2020-02-05 17:41 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).