From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v7 07/12] s390x: Library resources for CSS tests
Date: Tue, 26 May 2020 18:30:05 +0200 [thread overview]
Message-ID: <20200526183005.76fc9124.cohuck@redhat.com> (raw)
In-Reply-To: <1589818051-20549-8-git-send-email-pmorel@linux.ibm.com>
On Mon, 18 May 2020 18:07:26 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> Provide some definitions and library routines that can be used by
> tests targeting the channel subsystem.
>
> Debug function can be activated by defining DEBUG_CSS before the
> inclusion of the css.h header file.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> lib/s390x/css.h | 259 +++++++++++++++++++++++++++++++++++++++++++
> lib/s390x/css_dump.c | 157 ++++++++++++++++++++++++++
> s390x/Makefile | 1 +
> 3 files changed, 417 insertions(+)
> create mode 100644 lib/s390x/css.h
> create mode 100644 lib/s390x/css_dump.c
>
(...)
> +struct ccw1 {
> + unsigned char code;
> + unsigned char flags;
> + unsigned short count;
I'm wondering why you're using unsigned {char,short} here, instead of
the uint*_t types everywhere else? It's not wrong, but probably better
to be consistent?
> + uint32_t data_address;
> +} __attribute__ ((aligned(4)));
> +
> +#define SID_ONE 0x00010000
> +
I think it would be beneficial for the names to somewhat match the
naming in Linux and/or QEMU -- or more speaking names (as you do for
some), which is also good.
> +#define ORB_M_KEY 0xf0000000
> +#define ORB_F_SUSPEND 0x08000000
> +#define ORB_F_STREAMING 0x04000000
> +#define ORB_F_MODIFCTRL 0x02000000
> +#define ORB_F_SYNC 0x01000000
> +#define ORB_F_FORMAT 0x00800000
> +#define ORB_F_PREFETCH 0x00400000
> +#define ORB_F_INIT_IRQ 0x00200000
ORB_F_ISIC? (As it does not refer to 'initialization', but 'initial'.)
> +#define ORB_F_ADDRLIMIT 0x00100000
> +#define ORB_F_SUSP_IRQ 0x00080000
ORB_F_SSIC? (As it deals with suppression.)
> +#define ORB_F_TRANSPORT 0x00040000
> +#define ORB_F_IDAW2 0x00020000
ORB_F_IDAW_FMT2?
Or following Linux/QEMU, use ORB_F_C64 for a certain retro appeal :)
> +#define ORB_F_IDAW_2K 0x00010000
> +#define ORB_M_LPM 0x0000ff00
> +#define ORB_F_LPM_DFLT 0x00008000
That's a default lpm of 0x80, right? It's a bit buried between the orb
definitions, and it also seems to be more of a implementation choice --
move it out from the flags here?
> +#define ORB_F_ILSM 0x00000080
ORB_F_ILS?
> +#define ORB_F_CCW_IND 0x00000040
ORB_F_MIDAW? I had a hard time figuring out that one :)
> +#define ORB_F_ORB_EXT 0x00000001
(...)
> +/*
> + * Try o have a more human representation of the PMCW flags
s/o/to/
> + * each letter in the string represent the first
s/represent/represents/
> + * letter of the associated bit in the flag fields.
> + */
(...)
Generally, looks good to me.
next prev parent reply other threads:[~2020-05-26 16:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 16:07 [kvm-unit-tests PATCH v7 00/12] s390x: Testing the Channel Subsystem I/O Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 01/12] s390x: saving regs for interrupts Pierre Morel
2020-05-26 10:30 ` Janosch Frank
2020-05-26 11:39 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 02/12] s390x: Use PSW bits definitions in cstart Pierre Morel
2020-05-26 10:17 ` Janosch Frank
2020-05-26 11:40 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 03/12] s390x: Move control register bit definitions and add AFP to them Pierre Morel
2020-05-25 18:57 ` Thomas Huth
2020-05-26 11:51 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 04/12] s390x: interrupt registration Pierre Morel
2020-05-26 18:08 ` Thomas Huth
2020-05-27 15:54 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 05/12] s390x: export the clock get_clock_ms() utility Pierre Morel
2020-05-26 18:10 ` Thomas Huth
2020-06-04 6:49 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 06/12] s390x: use get_clock_ms() to calculate a delay in ms Pierre Morel
2020-05-26 18:16 ` Thomas Huth
2020-06-04 7:21 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 07/12] s390x: Library resources for CSS tests Pierre Morel
2020-05-26 16:30 ` Cornelia Huck [this message]
2020-06-04 7:42 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 08/12] s390x: css: stsch, enumeration test Pierre Morel
2020-05-25 19:12 ` Thomas Huth
2020-05-26 10:41 ` Janosch Frank
2020-05-26 10:49 ` Thomas Huth
2020-05-26 11:38 ` Pierre Morel
2020-05-27 8:55 ` Cornelia Huck
2020-06-04 11:35 ` Pierre Morel
2020-06-04 11:45 ` Thomas Huth
2020-06-04 12:27 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 09/12] s390x: css: msch, enable test Pierre Morel
2020-05-27 9:42 ` Cornelia Huck
2020-06-04 12:46 ` Pierre Morel
2020-06-04 13:29 ` Cornelia Huck
2020-06-05 7:37 ` Pierre Morel
2020-06-05 8:24 ` Pierre Morel
2020-06-05 9:00 ` Cornelia Huck
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 10/12] s390x: define function to wait for interrupt Pierre Morel
2020-05-26 10:42 ` Janosch Frank
2020-05-26 11:40 ` Pierre Morel
2020-05-27 9:45 ` Cornelia Huck
2020-06-04 12:47 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 11/12] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2020-05-27 10:09 ` Cornelia Huck
2020-06-05 7:37 ` Pierre Morel
2020-06-05 9:02 ` Cornelia Huck
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 12/12] s390x: css: ping pong Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526183005.76fc9124.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).