From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v7 08/12] s390x: css: stsch, enumeration test
Date: Wed, 27 May 2020 10:55:01 +0200 [thread overview]
Message-ID: <20200527105501.53681762.cohuck@redhat.com> (raw)
In-Reply-To: <1589818051-20549-9-git-send-email-pmorel@linux.ibm.com>
On Mon, 18 May 2020 18:07:27 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> First step for testing the channel subsystem is to enumerate the css and
> retrieve the css devices.
>
> This tests the success of STSCH I/O instruction, we do not test the
> reaction of the VM for an instruction with wrong parameters.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> s390x/Makefile | 1 +
> s390x/css.c | 89 +++++++++++++++++++++++++++++++++++++++++++++
> s390x/unittests.cfg | 4 ++
> 3 files changed, 94 insertions(+)
> create mode 100644 s390x/css.c
(...)
> +static void test_enumerate(void)
> +{
> + struct pmcw *pmcw = &schib.pmcw;
> + int cc;
> + int scn;
> + int scn_found = 0;
> + int dev_found = 0;
> +
> + for (scn = 0; scn < 0xffff; scn++) {
> + cc = stsch(scn|SID_ONE, &schib);
> + switch (cc) {
> + case 0: /* 0 means SCHIB stored */
> + break;
> + case 3: /* 3 means no more channels */
> + goto out;
> + default: /* 1 or 2 should never happened for STSCH */
> + report(0, "Unexpected cc=%d on subchannel number 0x%x",
> + cc, scn);
> + return;
> + }
> +
> + /* We currently only support type 0, a.k.a. I/O channels */
> + if (PMCW_CHANNEL_TYPE(pmcw) != 0)
> + continue;
> +
> + /* We ignore I/O channels without valid devices */
> + scn_found++;
> + if (!(pmcw->flags & PMCW_DNV))
> + continue;
> +
> + /* We keep track of the first device as our test device */
> + if (!test_device_sid)
> + test_device_sid = scn | SID_ONE;
> +
> + dev_found++;
> + }
> +
> +out:
> + report(dev_found,
> + "Tested subchannels: %d, I/O subchannels: %d, I/O devices: %d",
> + scn, scn_found, dev_found);
Just wondering: with the current invocation, you expect to find exactly
one subchannel with a valid device, right?
> +}
> +
> +static struct {
> + const char *name;
> + void (*func)(void);
> +} tests[] = {
> + { "enumerate (stsch)", test_enumerate },
> + { NULL, NULL }
> +};
> +
> +int main(int argc, char *argv[])
> +{
> + int i;
> +
> + report_prefix_push("Channel Subsystem");
> + for (i = 0; tests[i].name; i++) {
> + report_prefix_push(tests[i].name);
> + tests[i].func();
> + report_prefix_pop();
> + }
> + report_prefix_pop();
> +
> + return report_summary();
> +}
> diff --git a/s390x/unittests.cfg b/s390x/unittests.cfg
> index 07013b2..a436ec0 100644
> --- a/s390x/unittests.cfg
> +++ b/s390x/unittests.cfg
> @@ -83,3 +83,7 @@ extra_params = -m 1G
> [sclp-3g]
> file = sclp.elf
> extra_params = -m 3G
> +
> +[css]
> +file = css.elf
> +extra_params =-device ccw-pong
Hm... you could test enumeration even with a QEMU that does not include
support for the pong device, right? Would it be worthwhile to split out
a set of css tests that use e.g. a virtio-net-ccw device, and have a
css-pong set of tests that require the pong device?
next prev parent reply other threads:[~2020-05-27 8:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 16:07 [kvm-unit-tests PATCH v7 00/12] s390x: Testing the Channel Subsystem I/O Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 01/12] s390x: saving regs for interrupts Pierre Morel
2020-05-26 10:30 ` Janosch Frank
2020-05-26 11:39 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 02/12] s390x: Use PSW bits definitions in cstart Pierre Morel
2020-05-26 10:17 ` Janosch Frank
2020-05-26 11:40 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 03/12] s390x: Move control register bit definitions and add AFP to them Pierre Morel
2020-05-25 18:57 ` Thomas Huth
2020-05-26 11:51 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 04/12] s390x: interrupt registration Pierre Morel
2020-05-26 18:08 ` Thomas Huth
2020-05-27 15:54 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 05/12] s390x: export the clock get_clock_ms() utility Pierre Morel
2020-05-26 18:10 ` Thomas Huth
2020-06-04 6:49 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 06/12] s390x: use get_clock_ms() to calculate a delay in ms Pierre Morel
2020-05-26 18:16 ` Thomas Huth
2020-06-04 7:21 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 07/12] s390x: Library resources for CSS tests Pierre Morel
2020-05-26 16:30 ` Cornelia Huck
2020-06-04 7:42 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 08/12] s390x: css: stsch, enumeration test Pierre Morel
2020-05-25 19:12 ` Thomas Huth
2020-05-26 10:41 ` Janosch Frank
2020-05-26 10:49 ` Thomas Huth
2020-05-26 11:38 ` Pierre Morel
2020-05-27 8:55 ` Cornelia Huck [this message]
2020-06-04 11:35 ` Pierre Morel
2020-06-04 11:45 ` Thomas Huth
2020-06-04 12:27 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 09/12] s390x: css: msch, enable test Pierre Morel
2020-05-27 9:42 ` Cornelia Huck
2020-06-04 12:46 ` Pierre Morel
2020-06-04 13:29 ` Cornelia Huck
2020-06-05 7:37 ` Pierre Morel
2020-06-05 8:24 ` Pierre Morel
2020-06-05 9:00 ` Cornelia Huck
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 10/12] s390x: define function to wait for interrupt Pierre Morel
2020-05-26 10:42 ` Janosch Frank
2020-05-26 11:40 ` Pierre Morel
2020-05-27 9:45 ` Cornelia Huck
2020-06-04 12:47 ` Pierre Morel
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 11/12] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2020-05-27 10:09 ` Cornelia Huck
2020-06-05 7:37 ` Pierre Morel
2020-06-05 9:02 ` Cornelia Huck
2020-05-18 16:07 ` [kvm-unit-tests PATCH v7 12/12] s390x: css: ping pong Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527105501.53681762.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).