From: Thomas Huth <email@example.com> To: Janosch Frank <firstname.lastname@example.org>, email@example.com Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files Date: Thu, 14 Jan 2021 09:54:03 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 13/01/2021 13.15, Janosch Frank wrote: > On 1/13/21 1:04 PM, Thomas Huth wrote: >> On 12/01/2021 14.20, Janosch Frank wrote: >>> I've added too much to cstart64.S which is not start related >>> already. Now that I want to add even more code it's time to split >>> cstart64.S. lib.S has functions that are used in tests. macros.S >>> contains macros which are used in cstart64.S and lib.S >>> >>> Signed-off-by: Janosch Frank <email@example.com> >>> Acked-by: Claudio Imbrenda <firstname.lastname@example.org> >>> --- >>> s390x/Makefile | 6 +-- >>> s390x/cstart64.S | 119 ++--------------------------------------------- >>> s390x/lib.S | 65 ++++++++++++++++++++++++++ >> >> lib.S is a very generic name ... maybe rather use cpuasm.S or something similar? > > instr.S ? Hmm, no, if I read something like that, I'd expect wrapper functions for single instructions, which is not what we have here. Looking at the two functions, both are related to CPU stuff (reset and state), so something with "cpu" in the name would be best, I think. Maybe just cpu.S ? Or if you intend to add non-CPU related stuff here later, maybe something like misc.S ? > Or maybe entry.S to make it similar to the kernel? No, entry.S sounds like a startup code, which we already have in cstart64.S, so I'd rather avoid that name. Thomas
next prev parent reply other threads:[~2021-01-14 8:58 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-12 13:20 [kvm-unit-tests PATCH v4 0/9] s390x: Add SIE library and simple tests Janosch Frank 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 1/9] s390x: Add test_bit to library Janosch Frank 2021-01-14 13:55 ` Claudio Imbrenda 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 2/9] s390x: Consolidate sclp read info Janosch Frank 2021-01-14 13:57 ` Claudio Imbrenda 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 3/9] s390x: SCLP feature checking Janosch Frank 2021-01-13 11:02 ` Cornelia Huck 2021-01-14 13:47 ` Claudio Imbrenda 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files Janosch Frank 2021-01-13 11:04 ` Cornelia Huck 2021-01-13 12:04 ` Thomas Huth 2021-01-13 12:15 ` Janosch Frank 2021-01-14 8:54 ` Thomas Huth [this message] 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 5/9] s390x: sie: Add SIE to lib Janosch Frank 2021-01-13 12:44 ` Thomas Huth 2021-01-13 13:34 ` Janosch Frank 2021-01-14 14:43 ` Claudio Imbrenda 2021-01-14 15:03 ` Janosch Frank 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 6/9] s390x: sie: Add first SIE test Janosch Frank 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 7/9] s390x: Add diag318 intercept test Janosch Frank 2021-01-13 11:12 ` Cornelia Huck 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 8/9] s390x: Fix sclp.h style issues Janosch Frank 2021-01-12 13:20 ` [kvm-unit-tests PATCH v4 9/9] s390x: sclp: Add CPU entry offset comment Janosch Frank 2021-01-12 15:51 ` Thomas Huth 2021-01-13 10:25 ` David Hildenbrand 2021-01-13 11:06 ` Janosch Frank 2021-01-13 11:09 ` Cornelia Huck 2021-01-13 13:16 ` Thomas Huth 2021-01-14 14:45 ` Claudio Imbrenda 2021-01-18 9:43 ` [kvm-unit-tests PATCH v4 0/9] s390x: Add SIE library and simple tests Janosch Frank
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [kvm-unit-tests PATCH v4 4/9] s390x: Split assembly into multiple files' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).