[PATCH] kvm_stat: ignore events that have never occured

[PATCH] kvm_stat: ignore events that have never occured

[Avi Kivity]

Less cluttered display.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 kvm/kvm_stat |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kvm/kvm_stat b/kvm/kvm_stat
index 4a16277..d373c60 100755
--- a/kvm/kvm_stat
+++ b/kvm/kvm_stat
@@ -315,6 +315,8 @@ def tui(screen, stats):
             if row >= screen.getmaxyx()[0]:
                 break
             values = s[key]
+            if not values[0] and not values[1]:
+                break
             col = 1
             screen.addstr(row, col, key)
             col += label_width
-- 
1.7.1

Re: [PATCH] kvm_stat: ignore events that have never occured

[Jes Sorensen]

On 09/01/10 09:17, Avi Kivity wrote:
> Less cluttered display.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  kvm/kvm_stat |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kvm/kvm_stat b/kvm/kvm_stat
> index 4a16277..d373c60 100755
> --- a/kvm/kvm_stat
> +++ b/kvm/kvm_stat
> @@ -315,6 +315,8 @@ def tui(screen, stats):
>              if row >= screen.getmaxyx()[0]:
>                  break
>              values = s[key]
> +            if not values[0] and not values[1]:
> +                break
>              col = 1
>              screen.addstr(row, col, key)
>              col += label_width

Is this just for the live display update, or does it also affect single
run outputs?

If the latter, it will break scripting where you do a first run, then a
second run and then calculate the result based on the changes.

Cheers,
Jes

Re: [PATCH] kvm_stat: ignore events that have never occured

[Avi Kivity]

  On 09/06/2010 11:39 AM, Jes Sorensen wrote:
> On 09/01/10 09:17, Avi Kivity wrote:
>> Less cluttered display.
>>
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>> ---
>>   kvm/kvm_stat |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/kvm/kvm_stat b/kvm/kvm_stat
>> index 4a16277..d373c60 100755
>> --- a/kvm/kvm_stat
>> +++ b/kvm/kvm_stat
>> @@ -315,6 +315,8 @@ def tui(screen, stats):
>>               if row>= screen.getmaxyx()[0]:
>>                   break
>>               values = s[key]
>> +            if not values[0] and not values[1]:
>> +                break
>>               col = 1
>>               screen.addstr(row, col, key)
>>               col += label_width
> Is this just for the live display update, or does it also affect single
> run outputs?
>

Just the live update.

-- 
error compiling committee.c: too many arguments to function