From: firas ashkar <firas.ashkar@savoirfairelinux.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio: uio_pci_generic: add memory mappings
Date: Tue, 27 Apr 2021 10:06:39 -0400 [thread overview]
Message-ID: <878b461c295c084aa7152b56668b3e61aa78f744.camel@savoirfairelinux.com> (raw)
In-Reply-To: <YIetS88K/xLGHlXB@kroah.com>
Hi,
The reason for these extra changes is the result of running
fashkar@barbarian:~/Downloads/linux_mainline$ clang-format -style=file
-i drivers/uio/uio_pci_generic.c
fashkar@barbarian:~/Downloads/linux_mainline$ ./scripts/checkpatch.pl
0001-uio-uio_pci_generic-add-memory-mappings.patch
i shall undo those changes and retry again, ty
--
Firas Ashkar
Developpeur Système Embarqué
savoirfairelinux.com | Montréal, Québec
Tél.: +1 514 276 5468 ext. 118
On Tue, 2021-04-27 at 08:20 +0200, Greg KH wrote:
> On Mon, Apr 26, 2021 at 03:03:46PM -0400, Firas Ashkar wrote:
> > import memory resources from underlying pci device, thus allowing
> > userspace applications to memory map those resources.
>
> You also did other things in this patch that have nothing to do with
> this change, why?
>
> Always describe what your patch does properly, otherwise we have to
> ignore it.
>
> > Signed-off-by: Firas Ashkar <firas.ashkar@savoirfairelinux.com>
> > ---
> > :100644 100644 c7d681fef198 809eca95b5bb M drivers/uio/uio_pci_gen
> > eric.c
> > drivers/uio/uio_pci_generic.c | 52 +++++++++++++++++++++++++++++
> > ------
> > 1 file changed, 43 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/uio/uio_pci_generic.c
> > b/drivers/uio/uio_pci_generic.c
> > index c7d681fef198..809eca95b5bb 100644
> > --- a/drivers/uio/uio_pci_generic.c
> > +++ b/drivers/uio/uio_pci_generic.c
> > @@ -24,9 +24,9 @@
> > #include <linux/slab.h>
> > #include <linux/uio_driver.h>
> >
> > -#define DRIVER_VERSION "0.01.0"
> > -#define DRIVER_AUTHOR "Michael S. Tsirkin <mst@redhat.com>"
> > -#define DRIVER_DESC "Generic UIO driver for PCI 2.3
> > devices"
> > +#define DRIVER_VERSION "0.01.0"
> > +#define DRIVER_AUTHOR "Michael S. Tsirkin <mst@redhat.com>"
> > +#define DRIVER_DESC "Generic UIO driver for PCI 2.3 devices"
>
> Like this, why change these lines???
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-04-27 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 19:03 [PATCH] uio: uio_pci_generic: add memory mappings Firas Ashkar
2021-04-27 6:20 ` Greg KH
2021-04-27 14:06 ` firas ashkar [this message]
2021-04-27 16:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878b461c295c084aa7152b56668b3e61aa78f744.camel@savoirfairelinux.com \
--to=firas.ashkar@savoirfairelinux.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).