From: Greg KH <gregkh@linuxfoundation.org>
To: Firas Ashkar <firas.ashkar@savoirfairelinux.com>
Cc: mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio: uio_pci_generic: add memory mappings
Date: Tue, 27 Apr 2021 08:20:59 +0200 [thread overview]
Message-ID: <YIetS88K/xLGHlXB@kroah.com> (raw)
In-Reply-To: <20210426190346.173919-1-firas.ashkar@savoirfairelinux.com>
On Mon, Apr 26, 2021 at 03:03:46PM -0400, Firas Ashkar wrote:
> import memory resources from underlying pci device, thus allowing
> userspace applications to memory map those resources.
You also did other things in this patch that have nothing to do with
this change, why?
Always describe what your patch does properly, otherwise we have to
ignore it.
>
> Signed-off-by: Firas Ashkar <firas.ashkar@savoirfairelinux.com>
> ---
> :100644 100644 c7d681fef198 809eca95b5bb M drivers/uio/uio_pci_generic.c
> drivers/uio/uio_pci_generic.c | 52 +++++++++++++++++++++++++++++------
> 1 file changed, 43 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
> index c7d681fef198..809eca95b5bb 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -24,9 +24,9 @@
> #include <linux/slab.h>
> #include <linux/uio_driver.h>
>
> -#define DRIVER_VERSION "0.01.0"
> -#define DRIVER_AUTHOR "Michael S. Tsirkin <mst@redhat.com>"
> -#define DRIVER_DESC "Generic UIO driver for PCI 2.3 devices"
> +#define DRIVER_VERSION "0.01.0"
> +#define DRIVER_AUTHOR "Michael S. Tsirkin <mst@redhat.com>"
> +#define DRIVER_DESC "Generic UIO driver for PCI 2.3 devices"
Like this, why change these lines???
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-27 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 19:03 [PATCH] uio: uio_pci_generic: add memory mappings Firas Ashkar
2021-04-27 6:20 ` Greg KH [this message]
2021-04-27 14:06 ` firas ashkar
2021-04-27 16:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIetS88K/xLGHlXB@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=firas.ashkar@savoirfairelinux.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).