kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: firas ashkar <firas.ashkar@savoirfairelinux.com>
Cc: mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uio: uio_pci_generic: add memory mappings
Date: Tue, 27 Apr 2021 18:14:00 +0200	[thread overview]
Message-ID: <YIg4SLWo3YEzO/U8@kroah.com> (raw)
In-Reply-To: <878b461c295c084aa7152b56668b3e61aa78f744.camel@savoirfairelinux.com>

On Tue, Apr 27, 2021 at 10:06:39AM -0400, firas ashkar wrote:
> Hi,
> The reason for these extra changes is the result of running 
> fashkar@barbarian:~/Downloads/linux_mainline$ clang-format -style=file
> -i drivers/uio/uio_pci_generic.c

Please do not mix coding style changes with real fixes/additions.

And always review what a tool does, some of those changes were wrong.

thanks,

greg k-h

      reply	other threads:[~2021-04-27 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 19:03 [PATCH] uio: uio_pci_generic: add memory mappings Firas Ashkar
2021-04-27  6:20 ` Greg KH
2021-04-27 14:06   ` firas ashkar
2021-04-27 16:14     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIg4SLWo3YEzO/U8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=firas.ashkar@savoirfairelinux.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).