* Re: KVM: x86: Fix emulation of sysenter
[not found] <AM0PR83MB0307F44E915135F79E291058F1EA0@AM0PR83MB0307.EURPRD83.prod.outlook.com>
@ 2019-06-18 14:12 ` Paolo Bonzini
2019-06-19 12:47 ` Saar Amar
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2019-06-18 14:12 UTC (permalink / raw)
To: Saar Amar, kvm; +Cc: Radim Krčmář
On 18/06/19 15:19, Saar Amar wrote:
> I found a bug in sysenter emulation. Patch attached both in plaintext
> and as patch file.
Do you have a testcase for this? RF is cleared for all instructions here:
if (ctxt->rep_prefix && (ctxt->d & String))
ctxt->eflags |= X86_EFLAGS_RF;
else
ctxt->eflags &= ~X86_EFLAGS_RF;
just before em_sysenter is called.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: KVM: x86: Fix emulation of sysenter
2019-06-18 14:12 ` KVM: x86: Fix emulation of sysenter Paolo Bonzini
@ 2019-06-19 12:47 ` Saar Amar
0 siblings, 0 replies; 2+ messages in thread
From: Saar Amar @ 2019-06-19 12:47 UTC (permalink / raw)
To: Paolo Bonzini, kvm; +Cc: Radim Krčmář
Yeah I see there is not flow to en_sysenter which doesn't pass this logic. Thanks
-----Original Message-----
From: Paolo Bonzini <pbonzini@redhat.com>
Sent: Tuesday, June 18, 2019 5:12 PM
To: Saar Amar <Saar.Amar@microsoft.com>; kvm@vger.kernel.org
Cc: Radim Krčmář <rkrcmar@redhat.com>
Subject: Re: KVM: x86: Fix emulation of sysenter
On 18/06/19 15:19, Saar Amar wrote:
> I found a bug in sysenter emulation. Patch attached both in plaintext
> and as patch file.
Do you have a testcase for this? RF is cleared for all instructions here:
if (ctxt->rep_prefix && (ctxt->d & String))
ctxt->eflags |= X86_EFLAGS_RF;
else
ctxt->eflags &= ~X86_EFLAGS_RF;
just before em_sysenter is called.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-19 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <AM0PR83MB0307F44E915135F79E291058F1EA0@AM0PR83MB0307.EURPRD83.prod.outlook.com>
2019-06-18 14:12 ` KVM: x86: Fix emulation of sysenter Paolo Bonzini
2019-06-19 12:47 ` Saar Amar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).